rust-tempfile-3 update to 3.2.0 breaks sequoia build

rust-tempfile-3 update to 3.2.0 breaks sequoia build

[Hartmut Goebel]

Hi Nicolas,

building sequoia is currently broken in master with
"syn::export::ToTokens" not found.

I tracked this down to 6513650d40f74 "gnu: rust-tempfile-3: Update to
3.2.0." (2021-02-16). The updated package also updates some
dependency-requirements: cfg-if 0.1 -> 1, rand 0.7 -> 0.8 and
redox-syscall 0.1 -> 0.2.

While in theory - according to semantic versioning -, updating 3.1.x to
3.2.x should not any effect on others packages, this updates has :-(

I tried building with rust-tempfile-3.1, with no success - this fails
with "rand::rngs::OsRng" missing. Updating rust-rand-core-0.6 to 0.6.2
(since 0.6.1 was yanked), did not help either - then I gave up.

Any ideas how to make sequoia build again?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: rust-tempfile-3 update to 3.2.0 breaks sequoia build

[Nicolas Goaziou]

Hello,

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> building sequoia is currently broken in master with
> "syn::export::ToTokens" not found.
>
> I tracked this down to 6513650d40f74 "gnu: rust-tempfile-3: Update to
> 3.2.0." (2021-02-16). The updated package also updates some
> dependency-requirements: cfg-if 0.1 -> 1, rand 0.7 -> 0.8 and
> redox-syscall 0.1 -> 0.2.
>
> While in theory - according to semantic versioning -, updating 3.1.x to
> 3.2.x should not any effect on others packages, this updates has :-(

Ouch :(

> I tried building with rust-tempfile-3.1, with no success - this fails
> with "rand::rngs::OsRng" missing. Updating rust-rand-core-0.6 to 0.6.2
> (since 0.6.1 was yanked), did not help either - then I gave up.

I confirm this.

> Any ideas how to make sequoia build again?

Not really. Is it possible to upgrade it to a more recent commit? I see
that Cargo.lock references tempfile 3.2.0 in HEAD.

Regards,
-- 
Nicolas Goaziou

Re: rust-tempfile-3 update to 3.2.0 breaks sequoia build

[Hartmut Goebel]

Am 04.04.21 um 11:08 schrieb Nicolas Goaziou:
> Not really. Is it possible to upgrade it to a more recent commit? I see
> that Cargo.lock references tempfile 3.2.0 in HEAD.

The issue is not in tempfile, it's just caused by this update. Thus I'm
not confident updating sequoia to a more recent version will fix the issue.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: rust-tempfile-3 update to 3.2.0 breaks sequoia build

[Hartmut Goebel]

Hi Nicolas,

I was able to fix sequoia by updating to 1.1 and applying some more
changes. Please review <http://issues.guix.gnu.org/issue/48154> so we
can get it into upcoming guix 1.3. Thanks in advance

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: rust-tempfile-3 update to 3.2.0 breaks sequoia build

[Nicolas Goaziou]

Hello,

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> I was able to fix sequoia by updating to 1.1 and applying some more
> changes.

Thank you.

> Please review <http://issues.guix.gnu.org/issue/48154> so we
> can get it into upcoming guix 1.3. Thanks in advance

I don't use sequoia but I confirm it builds on my x86_64 system.

nitpick: Your "cargo can't ..." comment ought to start with
a single semicolon.

In `fix-permissions' phase, are you sure you need #o644 permission?
Otherwise, you may want to use `make-file-writeable'.

Anyway, LGTM!

Regards,

-- 
Nicolas Goaziou

Re: rust-tempfile-3 update to 3.2.0 breaks sequoia build

[Hartmut Goebel]

Hi Nicolas,

thanks for the review, Unfortunately I pushed the change just a few 
minutes ago :-(

> In `fix-permissions' phase, are you sure you need #o644 permission?
> Otherwise, you may want to use `make-file-writeable'.

Thanks for this tip, I didn't know this function. I'll keep it in mind 
for further patches.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |