From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mJ05E07TuWDhRAEAgWs5BA (envelope-from ) for ; Fri, 04 Jun 2021 09:16:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6BPNDk7TuWC4KAAAB5/wlQ (envelope-from ) for ; Fri, 04 Jun 2021 07:16:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6E66C1119A for ; Fri, 4 Jun 2021 09:16:29 +0200 (CEST) Received: from localhost ([::1]:58126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lp44B-00067b-OI for larch@yhetil.org; Fri, 04 Jun 2021 03:16:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lp3nM-00034S-HM for bug-guix@gnu.org; Fri, 04 Jun 2021 02:59:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lp3nJ-0002te-Ma for bug-guix@gnu.org; Fri, 04 Jun 2021 02:59:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lp3nJ-0005Wc-NU for bug-guix@gnu.org; Fri, 04 Jun 2021 02:59:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47698: [powerpc64le-linux] "check" package fails to build Resent-From: Chris Marusich Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 04 Jun 2021 06:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47698 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 47698@debbugs.gnu.org Received: via spool by 47698-submit@debbugs.gnu.org id=B47698.162278991621202 (code B ref 47698); Fri, 04 Jun 2021 06:59:01 +0000 Received: (at 47698) by debbugs.gnu.org; 4 Jun 2021 06:58:36 +0000 Received: from localhost ([127.0.0.1]:45210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp3mt-0005Vt-L4 for submit@debbugs.gnu.org; Fri, 04 Jun 2021 02:58:35 -0400 Received: from mail-pj1-f51.google.com ([209.85.216.51]:41666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp3mr-0005Vg-MO for 47698@debbugs.gnu.org; Fri, 04 Jun 2021 02:58:34 -0400 Received: by mail-pj1-f51.google.com with SMTP id b15-20020a17090a550fb029015dad75163dso5363849pji.0 for <47698@debbugs.gnu.org>; Thu, 03 Jun 2021 23:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0xAl6OtMm0+I+xN4bwwgHz3Fbc4YVYNBLh+cXAkM2ng=; b=VXe0X7J6w60k4hMBssHq23s7C5nOmN6Gt5uCCbrUOHoLFeEsahdPkihzR4z5VXjxl4 P053ZSUsa6weRMp11IyPi0jKJgcxxLfvnbWEC6SsdtS82pPAb1+hutziTJMcuqrHo0Q5 WlAvKlZuf8xr7+L/Q9s4K0w9otRvupfuquO6ZHxc6lsPvc06GWCUZg+gDtyZF8VFiqxk pz9HjZUGd14zoaFvx4/q5VK2cf6hYRnXN2bSl31W6W/xdIXme1oeF4OTbGo4Hz8qhJIt X0Gyv18023ZDxrytLahmGI27KbkI8tehggFAK+kCzCIBs6yPn9woE4U8+jEXpvaJPPG7 Fjmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=0xAl6OtMm0+I+xN4bwwgHz3Fbc4YVYNBLh+cXAkM2ng=; b=ubHoaU2DNb8NYFDM0bF4C2OOwoxiGjRR80eBoLvRN/NBoKFlYYhefiioF5eVpAy6wY kpPzCRjaTSA2hm07t4Rlwe31XBZSz7Y4r/FF2yArxl5BSLvD/7YDi1JnsY3BYByL1P/e 99pv603cOsLQ15ULGau58Gf9hXUKRWHH1x4TjhTMQbYyKgu6WUQG3MSRWCjILHs5Yc/r Z/kQ+1kcRGivOLi8eFxUX6njSB9ycNsrikUH1OF+ohOJ62xTKsp4As3xAg76bFw6Uiv+ 7M21b7P7nhMNnaw7Q/PTmQxvb7h4DDIRVAj3ukV8DSDUExEHr0tsNA4lmwANl3iumO5e 0f9w== X-Gm-Message-State: AOAM533M4HLQIvQ3PgC8vcVDvq6FNxgzdl3TC1s9ql2ADukTQ7+2gFz5 8Y/aJza5axjKtRytNNiDuR0= X-Google-Smtp-Source: ABdhPJw1nOZKHtyU2H+TDITKH83c7A5xBdH5bg1XYkKRujiiT1NF9YdxcPxedgl+/2aUTluMYgENNQ== X-Received: by 2002:a17:90a:5883:: with SMTP id j3mr15945649pji.89.1622789907519; Thu, 03 Jun 2021 23:58:27 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::b043]) by smtp.gmail.com with ESMTPSA id ca6sm4049027pjb.21.2021.06.03.23.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 23:58:26 -0700 (PDT) From: Chris Marusich References: <87v98ty6rr.fsf@gmail.com> <87wns1daic.fsf@gmail.com> Date: Thu, 03 Jun 2021 23:58:21 -0700 In-Reply-To: <87wns1daic.fsf@gmail.com> (Chris Marusich's message of "Fri, 14 May 2021 00:45:15 -0700") Message-ID: <87eedit8tu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622790989; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=0xAl6OtMm0+I+xN4bwwgHz3Fbc4YVYNBLh+cXAkM2ng=; b=kA6pUbOXke2Zc49UxwgUf4Icc453nqbeMS+FKlxsjV3fkubyqNfCuCuoKB8dmxx/nD0lLN p8mK8HNH07P27arVFb1VeIZlOMAg3NiBlu8MvX8cBz85oIeFblL9CVcr0Ff0VCVeSCt1Ti CQFNPqhw9KPM8u5I1JhppT1fASCrXHCJOSN3+riKwjKtwtW8QL9JaniHSM3ichTLqYh3MM waJ6q/pw5cdwsKp21zfQdbrXu0AGL07VUftuHwNFSFJKfJtqeKYZgoE92wdnXdseXFzcDe uA5kLzFVApJVgKUvlLUMM/SlgP6v9xl5mbozdbQo95d65Sr8XFGubPo3shVjHQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622790989; a=rsa-sha256; cv=none; b=g0NAQyA1X3GfAY0YuYi62wJ5bscHEO9ZHwX64pVMy6LhHqfl8QnFf83B3uGC43Cuk3Fu6O zA0C1gEEH8C0Vial8PHL5KLbEv+cZ6tZUoZuWtybDmTpx/QCmCnkSKSuw8Gjvc2P2oAlzF pjuh+WZNL1lMyl2l8/uJml8kHR7/kbuqV6czpZYq9oo2R3/1mUtV4/leeT20QlyAI/jAHh ifml9d3lxOW8/HG8TYhv1gFSpcUU+kjsUOTr4363LKBG2RtZofbzXp4I8kp+Y2wyni14Ty LZgIIqp4VAkZ8hI9kTXSeyfiPG3qLEoGwnRs7gRuJKZcdAPdvKoVxCzffytpXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=VXe0X7J6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -0.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=VXe0X7J6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 6E66C1119A X-Spam-Score: -0.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: oL92gtNA3YCG --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Chris Marusich writes: > [...] I've reported this issue upstream: > https://github.com/libcheck/check/issues/333 Branden Archer replied in the above issue. In short, the unreleased upstream commit 4fbe702fa4f35bee8a90512f9f59d1441c4ae82e fixes this issue on PPC platforms. Here's what the commit does: https://github.com/libcheck/check/commit/4fbe702fa4f35bee8a90512f9f59d1441c= 4ae82e.patch Adjust test suite for 106-bit long double precision On PowerPC architectures (ppc, ppc64el, powerp) 'long double' has a precision of 106-bit, compared to 80-bit precision on amd64. This leads to the test_ck_assert_(float|double|ldouble)_eq_tol succeed rather than fail as expected, cause 0.003-0.002 will be actually slightly bigger than 0.001 and not slightly smaller. Increase the change to the tolerance, so it will be on all architectures smaller than the difference of ~0.001 and the unit tests will fail as expected. This commit was merged to the check repository's master branch after its latest release (0.15.2). It will be included in the next check release, but until then, we will have to apply the fix as a patch to our check package. I've attached a patch that does this. =2D-=20 Chris --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-check-Fix-failing-tests-on-powerpc64le-linux.patch Content-Transfer-Encoding: quoted-printable From=207692295f970a292a3f3db31fc21d05efd97dcb25 Mon Sep 17 00:00:00 2001 From: Chris Marusich Date: Thu, 3 Jun 2021 23:12:24 -0700 Subject: [PATCH] gnu: check: Fix failing tests on powerpc64le-linux. * gnu/packages/check.scm (check)[source]: Apply unreleased upstream commit 4fbe702 as a patch. =2D-- gnu/packages/check.scm | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 6641a0de58..069d4e05fc 100644 =2D-- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -146,7 +146,27 @@ like Jasmine or Mocha.") version "/check-" version ".tar.gz")) (sha256 (base32 =2D "02m25y9m46pb6n46s51av62kpd936lkfv3b13kfpckgvmh5lxpm8")))) + "02m25y9m46pb6n46s51av62kpd936lkfv3b13kfpckgvmh5lxpm8")) + (patches + (list + ;; This patch fixes some tests that would otherwise fail on + ;; powerpc64le-linux. Without this patch, the tests make certain + ;; assumptions about floating point number precision that are not = true + ;; on that platform. + ;; + ;; TODO: Remove this patch when updating to the next check release, + ;; since it will be included there. See: + ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D47698 + (origin + (method url-fetch) + (uri + (string-append "https://github.com/libcheck/check/commit/" + "4fbe702fa4f35bee8a90512f9f59d1441c4ae82e.patch"= )) + (file-name (string-append name + "-fix-test-precision-for-ppc.patch")) + (sha256 + (base32 + "04qg1p9afdd6453k18qskazrvscysdcjz9j6w4i6p5x4xyma19v6"))))))) (build-system gnu-build-system) (home-page "https://libcheck.github.io/check/") (synopsis "Unit test framework for C") =2D-=20 2.30.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmC5zw0VHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadc68QANQLIommJvgPGkSki6rT2JVcuxQd qXPZDRxcGS2kOVu321wHGuScMZJ9rUjtmTjA7dqN56CfqqEe+AM+E1NP2GKcAqsD macemd285NyoRIFuMcJwBguMMDd06RsQJIxtNzmE4fzxbbrcJ/F6QD2DZKXbRzvw 6cbKyoj7sk3iGUMz8agsD9Wlspi+PzNwp0OihZY48QPc9l/hppUHzYl79+1Gr8ER 5CRX8YfAy02Wn/px/u0FQKab0QCTw56AetsThvS8PMkhJJpZN35ejtS5HVFvLYBN VoY4ILJR6GHdyk4jzeiVgx9wWoNXbieFBV0bQhc+/8HaL53t7Lhzi5iOrSFY69cK C9NCIiSfO8K7WrS4bkm9yrdJnxPdPrF/QxDXqJuI0FmJH2FYYcSEAtIL7hOEyp9S ph/3I0EmbaGsrgtnhhT9nSHmqPo4fUKTnfhpw3UJJ8w1fpOfADDl3ZfVzD+fmhha YIMWpZ+aFVcbQbhsEDhLLkPKF5TB+CcogFUiF3r6nF4U0roOioMgaoNyTDOq3CIG 33LIL/T9+qtIvXY/tbhfnP80dHPlIvL9pIYvd4r6iTAiKSNGDV0Yqc8wMcWqx17X ZXNSqz6uqQPOvI2ZjoRCv9QRH9AkgR6YaLzRXG1B1inKXHDMNy/hHUtoDvBnwlyX 0hsxKndWeu3H2bXP =+RVt -----END PGP SIGNATURE----- --==-=-=--