From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8NLgLicdU2Fl7gAAgWs5BA (envelope-from ) for ; Tue, 28 Sep 2021 15:48:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wFyQKicdU2GrGwAA1q6Kng (envelope-from ) for ; Tue, 28 Sep 2021 13:48:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1388AAFAF for ; Tue, 28 Sep 2021 15:48:23 +0200 (CEST) Received: from localhost ([::1]:43636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVDT4-00070j-6j for larch@yhetil.org; Tue, 28 Sep 2021 09:48:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49600) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVDNu-000745-My for guix-patches@gnu.org; Tue, 28 Sep 2021 09:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60827) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVDNu-0003xs-Da for guix-patches@gnu.org; Tue, 28 Sep 2021 09:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVDNu-0000k8-9x for guix-patches@gnu.org; Tue, 28 Sep 2021 09:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50133] [PATCH 0/6] Add lxd package and service. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Sep 2021 13:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50133 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Whatson Cc: 50133@debbugs.gnu.org Received: via spool by 50133-submit@debbugs.gnu.org id=B50133.16328365362803 (code B ref 50133); Tue, 28 Sep 2021 13:43:02 +0000 Received: (at 50133) by debbugs.gnu.org; 28 Sep 2021 13:42:16 +0000 Received: from localhost ([127.0.0.1]:44139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVDNA-0000j9-GM for submit@debbugs.gnu.org; Tue, 28 Sep 2021 09:42:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVDN7-0000ir-PM for 50133@debbugs.gnu.org; Tue, 28 Sep 2021 09:42:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43900) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVDN2-0003Ha-J7; Tue, 28 Sep 2021 09:42:08 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=60500 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVDN1-00035p-9h; Tue, 28 Sep 2021 09:42:08 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210820124524.117090-1-whatson@gmail.com> <20210820124524.117090-6-whatson@gmail.com> Date: Tue, 28 Sep 2021 15:42:04 +0200 In-Reply-To: <20210820124524.117090-6-whatson@gmail.com> (Andrew Whatson's message of "Fri, 20 Aug 2021 22:45:24 +1000") Message-ID: <87ee98akb7.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632836903; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=xj8V8mplTr1EpthC13zfLP/l2LKyj/v7GbpneQELsco=; b=MWFSDcQU0eqnDI6GwLYwFCaU6GqciFzy6mR4wCw8bA1d9G6LV7RSSSzbeTuTbZ+jPsoZrZ Wklx6PLWeh6154J4Z+pVV0QhLw2miD+6QHINL+/OejJNfe7kbTr/kH/lS3bSqhbjzsFF7h Fm9BYHNaE64iW4l8zZX8Q3AT1O6Nj+aUBM3XZi3+oWueryY6R/4ziVg2lXLQKBzTOEN4sY 6IMqqYv0epb4TSUHvJefQdfmlfXJCRbi3jbrTM6zaM4TPq79pnWY8YbAyk3Ot2sHz6/6LE zR+02tOtBEBTRx6EjlAvkodJJ8NSeroYPq/OlPDVTHWvmYzslIxqe7nstxoC5A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632836903; a=rsa-sha256; cv=none; b=RojyiDMY6TRK7KGqtm6AtDpyR46H/7C0jVakTWS6YqoK9Lz/D8M3BzQap+QOewhukvwmOg 7bJeA1VjLMcEumf34tYXDi8LmDC+Lqlj8LK3OTPIbder45MLhm1F2U4SAyruOJC6k6yAS4 YT0YPIewkEfkPF6UzutSA/noLq6MB/3IX1A2gRMxYmoI3Pz5pSQWoAEb6xWukBfbZ9m9IB o79M7xZmlg15/lSIOP4TeqBxGD2Plc3R44E1z2XwBZu9x4NsCIeZRnvWoZpyzNTtjSuFto 1vX8oUb3ULThkvudfkAwE0SnMSk1Yg1IUqpK5NmcdpHqmm+VWavoN4e2EB/9Rg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1388AAFAF X-Spam-Score: -2.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: n0+YUD7J+UVS Hi Andrew, The whole series LGTM and I=E2=80=99ve already applied patch 1=E2=80=935. Some comments below about the service: Andrew Whatson skribis: > * gnu/services/virtualization.scm (lxd-configuration): New type. > (%lxd-accounts, lxd-service-type): New variables. > (%lxd-activation, lxd-shepherd-service): New procedures. > * gnu/system/file-systems.scm (%elogind-file-systems): Add > "/sys/fs/cgroup/systemd" file-system. [...] > +(define lxd-service-type > + (service-type > + (name 'lxd) > + (extensions > + (list (service-extension activation-service-type > + %lxd-activation) > + (service-extension shepherd-root-service-type > + lxd-shepherd-service) > + (service-extension account-service-type > + (const %lxd-accounts)))) > + (default-value (lxd-configuration)))) Please add a =E2=80=98description=E2=80=99 field. > index b9eda80958..7c3777298b 100644 > --- a/gnu/system/file-systems.scm > +++ b/gnu/system/file-systems.scm > @@ -499,6 +499,17 @@ TARGET in the other system." > (check? #f) > (options "none,name=3Delogind") > (create-mount-point? #t) > + (dependencies (list (car %control-groups)))) > + ;; The systemd cgroup needs to exist to run systemd inside linux > + ;; containers (eg. via LXD). This is *not* required for elogin= d, but > + ;; keeping it with the other systemd hacks seemed sensible, for= now. > + (file-system > + (device "cgroup") > + (mount-point "/sys/fs/cgroup/systemd") > + (type "cgroup") > + (check? #f) > + (options "none,name=3Dsystemd") > + (create-mount-point? #t) > (dependencies (list (car %control-groups))))) > %control-groups)) Instead of adding it here, how about extending =E2=80=98file-system-service-type=E2=80=99 instead, similar to what =E2=80=98qemu-binfmt-service-type=E2=80=99 does? That way, the extra requi= rement would be limited to LXD. Two other things, could you add: 1. documentation in the manual under =E2=80=9CVirtualization Services=E2= =80=9D, with a commented config example? 2. (ideally) a system test to ensure that the basics of the service are working? TIA! Ludo=E2=80=99.