From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oEhXJBC+WmF6JwEAgWs5BA (envelope-from ) for ; Mon, 04 Oct 2021 10:40:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0Gb6HxC+WmHSGwAAB5/wlQ (envelope-from ) for ; Mon, 04 Oct 2021 08:40:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3519DF2A7 for ; Mon, 4 Oct 2021 10:40:48 +0200 (CEST) Received: from localhost ([::1]:34300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXJWh-00057Q-9H for larch@yhetil.org; Mon, 04 Oct 2021 04:40:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXJGU-000605-W3 for guix-patches@gnu.org; Mon, 04 Oct 2021 04:24:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52270) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXJGU-0003Ld-Ek for guix-patches@gnu.org; Mon, 04 Oct 2021 04:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mXJGU-0007hy-BG for guix-patches@gnu.org; Mon, 04 Oct 2021 04:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50960] [PATCH 00/10] Add 'guix shell' to subsume 'guix environment' Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Oct 2021 08:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50960 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "pelzflorian (Florian Pelz)" Cc: 50960@debbugs.gnu.org Received: via spool by 50960-submit@debbugs.gnu.org id=B50960.163333579429575 (code B ref 50960); Mon, 04 Oct 2021 08:24:02 +0000 Received: (at 50960) by debbugs.gnu.org; 4 Oct 2021 08:23:14 +0000 Received: from localhost ([127.0.0.1]:35583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXJFa-0007gq-U9 for submit@debbugs.gnu.org; Mon, 04 Oct 2021 04:23:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXJFW-0007fy-9i for 50960@debbugs.gnu.org; Mon, 04 Oct 2021 04:23:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44350) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXJFQ-00028b-P8; Mon, 04 Oct 2021 04:22:56 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=60528 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXJFQ-0003Zi-FT; Mon, 04 Oct 2021 04:22:56 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20211002102116.27726-1-ludo@gnu.org> <20211002115958.rzupz4afq7elehq4@pelzflorian.localdomain> <87sfxjzgsv.fsf_-_@gnu.org> <20211002150851.7xa2wdb225dbjtpi@pelzflorian.localdomain> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 =?UTF-8?Q?Vend=C3=A9miaire?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 04 Oct 2021 10:22:54 +0200 In-Reply-To: <20211002150851.7xa2wdb225dbjtpi@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Sat, 2 Oct 2021 17:08:51 +0200") Message-ID: <87ee91ryg1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633336848; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=ppxDS83q9KOJ7aseu6g5Jo60g3A2uWUbjrI8eC3/e4k=; b=OXdeLkwh9AZivbcnabwU6i9Uw6d7sTgyms3itf7BxcIOiGv1ldXbMRyn3/BuGX/+uVrlj9 1evTjRxxRvataryhDJdcgIwcni09tUbfBaiLo1+gJrYY4xA2iO1WLKnVxpXPZDCaSEYxcx CL9cx9Es8DiUygZp/8wpceMa43GA0EK46DZgQQjv8BRmGEbwyycPERjylys7gwv/zv7MJT QEtydpjOLve0CZ6T5BmhEmKEedu4KJJoWUL7Z29OopjkdAfiC6gD3FZgFwOetEUEkH3pRI O60miLpti7Oo2IC0Teujl8kE/Dr1WR0t51C9kIWRZ8e8nR6xJgJS4fpwQNLUsw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633336848; a=rsa-sha256; cv=none; b=hIYsh7UhVV5jeYpKGHyCVp6rZpn170QuwrplmGs1E3f2a1RtsiIrPCV3vzxrJz7YWDKDDz Mo+K6AX4lBuxdyfkNU2eegmJfLkqB15YY9q6M2teR5jEl8u98HbrW48rv6oZFm6HtrNT6i 9auo3/ERtmUZSIMi7efPRSFlpQXmwEjuUJsmklwjJER0vHUkNzF1XwWxQwDT5MGOlgLO2s cnZRL0I0ZZCfb6ELe/a6LMrhgkwqUJX2Dvmgz0T6lUNQLNezHL8kjsu0JEnm8CDmDpBqG5 SO5FeIrTde2yd8mqB4acuOBP02USWHc+n9Uy2FoSw25o8ewYeI5eu/lgmLGs0A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.71 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3519DF2A7 X-Spam-Score: -3.71 X-Migadu-Scanner: scn1.migadu.com X-TUID: dySWVMZTaIxQ Hi, "pelzflorian (Florian Pelz)" skribis: > On Sat, Oct 02, 2021 at 03:40:00PM +0200, Ludovic Court=C3=A8s wrote: >> "pelzflorian (Florian Pelz)" skribis: >> > On Sat, Oct 02, 2021 at 12:21:16PM +0200, Ludovic Court=C3=A8s wrote: >> >> 2. =E2=80=98guix shell=E2=80=99, without arguments, loads =E2=80=98gu= ix.scm=E2=80=99 or =E2=80=98manifest.scm=E2=80=99 >> >> from the current directory or one of its ancestors. >> > This however is concerning. Users will not expect guix to execute >> > arbitrary code. Maybe print a suggestion to maybe --file the file >> > instead. >> I think it=E2=80=99s fine as long as, as in the case of =E2=80=98haunt b= uild=E2=80=99 or =E2=80=98make=E2=80=99 >> or =E2=80=98git=E2=80=99, it=E2=80=99s properly documented. Also, =E2= =80=98guix shell=E2=80=99 unconditionally >> writes a message. > > Let=E2=80=99s say I have downloaded undesirable code to a file > /home/florian/Downloads/guix.scm and am hacking on source code in > /home/florian/Downloads/something/ where I run `guix shell`, but > /home/florian/Downloads/something/ does not in fact contain a > guix.scm file. Now I=E2=80=99d have accidentally run the other guix.scm. Sure, but it=E2=80=99s all under your control; it=E2=80=99s not very differ= ent from someone knowingly running =E2=80=9Cguix build -f guix.scm=E2=80=9D on an un= trusted file, is it? > Also `make` is typically used without arguments, but a novice `guix > shell` user might know `guix shell program-a program-b` but is > surprised when running `guix shell` without arguments in an untrusted > directory. We have the advantage that =E2=80=98guix shell=E2=80=99 is a new command, s= o we can document it from the start as behaving this way without arguments. WDYT? Thanks, Ludo=E2=80=99.