From: Guillaume Le Vaillant <glv@posteo.net>
To: Artem Chernyak <artemchernyak@gmail.com>
Cc: 51232@debbugs.gnu.org
Subject: [bug#51232] [PATCH 0/2] gnu: Update udiskie to 2.3.3
Date: Mon, 18 Oct 2021 09:00:11 +0000 [thread overview]
Message-ID: <87ee8iwvja.fsf@kitej> (raw)
In-Reply-To: <CALP7HJv-ynHeet6s=S9M0y0uNjskqT64QnBU-OwTa8hOz5RsQg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
Artem Chernyak <artemchernyak@gmail.com> skribis:
> Since we now have libappindicator packaged, we can safely remove the
> patch instead of updating it for the new version.
>
> Artem Chernyak (2):
> gnu: Update udiskie to 2.3.3
> gnu: Remove udiskie-no-appindicator.patch
>
> gnu/packages/freedesktop.scm | 8 +-
> .../patches/udiskie-no-appindicator.patch | 155 ------------------
> 2 files changed, 3 insertions(+), 160 deletions(-)
> delete mode 100644 gnu/packages/patches/udiskie-no-appindicator.patch
When removing a patch file, you must also remove it in the
'dist_patch_DATA' list of patches in the "gnu/local.mk" file.
Also, you don't need to split the patch removal in several commits (see
commit 2f0986b0f7cbf4dec5a3e575c67a508cf71c6dd5 for example).
Could you send an updated patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next prev parent reply other threads:[~2021-10-18 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 3:30 [bug#51232] [PATCH 0/2] gnu: Update udiskie to 2.3.3 Artem Chernyak
2021-10-16 3:33 ` [bug#51232] [PATCH 1/2] " Artem Chernyak
2021-10-16 3:34 ` [bug#51232] [PATCH 2/2] gnu: Remove udiskie-no-appindicator.patch Artem Chernyak
2021-10-18 9:00 ` Guillaume Le Vaillant [this message]
2021-10-18 12:14 ` [bug#51232] [PATCH] gnu: Update udiskie to 2.3.3 Artem Chernyak
2021-10-18 14:44 ` bug#51232: " Guillaume Le Vaillant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee8iwvja.fsf@kitej \
--to=glv@posteo.net \
--cc=51232@debbugs.gnu.org \
--cc=artemchernyak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.