From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +HT3Niq/j2GCJwEAgWs5BA (envelope-from ) for ; Sat, 13 Nov 2021 14:35:38 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wMB5Miq/j2GzaQAAbx9fmQ (envelope-from ) for ; Sat, 13 Nov 2021 13:35:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 23CF622794 for ; Sat, 13 Nov 2021 14:35:37 +0100 (CET) Received: from localhost ([::1]:53486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mltBw-000690-CF for larch@yhetil.org; Sat, 13 Nov 2021 08:35:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mltBP-00068n-HL for help-guix@gnu.org; Sat, 13 Nov 2021 08:35:03 -0500 Received: from [2a02:c205:2020:6054::1] (port=53024 helo=tobias.gr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mltBM-0004jn-LB for help-guix@gnu.org; Sat, 13 Nov 2021 08:35:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=KfpAFhS66EEjS 3pNwwwqNepTS5qh+FsufwVxvzGwS3Q=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=Wgi1Yw26BRI5AFSj7ececzuuyicaXZt12eqmk0 QcfwKC+6sqvp50Yj0a9YJigRAOGhN93xBZr2dG40Ep8CWernMwicSY68EvwCZ464EyRIix 9b775ctxonEVEh4BhMw/BUbD1VxlnZkqh6ILOZUUP3TJ8jAGOED3njqyHt5f/l6noOz1YL 7rLoJkmsgrgM+1dvGwndy0xJQ6HCTwjvjKFSN1FdwJZ3aDiM4YKTmx64O6VRDfOXtrij+b B/IxmBXudm1/Vf9lSbG5sk7u7BOs42IEBgefceG6K1JyzruLsr91hYXCSoAu/Ayymp4oQS YqYLQ8sCNHPxRpTOdcLwk6vQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 5f7682c5 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 13 Nov 2021 13:34:53 +0000 (UTC) References: <2cc0eaa33fd6bd50b5ecc0dab0ef2491@tobias.gr> <877dddhrcp.fsf@nckx> From: Tobias Geerinckx-Rice To: phodina Cc: help-guix Subject: Re: Custom libre kernel configuration devolving into Anbox review I guess Date: Sat, 13 Nov 2021 13:23:47 +0100 In-reply-to: BIMI-Selector: v=BIMI1; s=default; Message-ID: <87ee7kjhzw.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:c205:2020:6054::1 (failed) Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: "Help-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636810537; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=KfpAFhS66EEjS3pNwwwqNepTS5qh+FsufwVxvzGwS3Q=; b=jdhEmsOaL0fqtXYFWo2Z77Pdv3UYzD02G3176NMwMl+douaRLNEHXy97Lh0fDFWqAM03Lt Tz2ex/Ntkn/oVcuo4DaZh/PfziyURdsokprjMoGiMhxEJil2UAeQhr38AmCnhJGR/RgT8C dCSGwfNfycWJbHAQ/E5Wnjj++6ufqgGS70bPvRePu/DZtLqanBazL7XFyaP9JYYwUJ0cQ/ ShhMEIAuP0Take3n+hLipwkFSvJx4oCWGzf54h6GrLy6CksznCkso3i/KjlY5NeRQYKlnh +ap3U7xlFdZ7nMkTMyo1sMe+vLs5AhrIlloDDaBK+6EZKnF3oO1uygLFK031rg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636810537; a=rsa-sha256; cv=none; b=E4tBkZg/2tYah9hB7cO2sjPxn47+sHRHGpBpbNJ3XJ3mMgnYq5h3MQahEwtlBqN6huB4nS gR/kTfHrFKaZZn9JoE1eCsWZLiBsXDJavH4Fj1cMWkoQSaUViF4qkhMLPhRcvLACETtaM3 IewEKQ5jXlZ+fXb69BOitcQQeSpLBRnwUCEAbsHOGHCry7e8I3RzCaGAxSYX2kCpAlV+QA Pk2b5oNZXfL5N8OrQvLCsarWwPDdgLuzMdSnq5PSMeV5VnIFmQQc7dsIhnhkDFJKzCBffa axO8RBKB7FG2zob3G+6sN0khV/c+vd4UF2RjsNWX4U5cqaCfs35FKKu1a8dTmw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=tobias.gr header.s=2018 header.b=Wgi1Yw26; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Migadu-Spam-Score: -5.63 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=tobias.gr header.s=2018 header.b=Wgi1Yw26; dmarc=pass (policy=reject) header.from=tobias.gr; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Migadu-Queue-Id: 23CF622794 X-Spam-Score: -5.63 X-Migadu-Scanner: scn1.migadu.com X-TUID: 0m2XajOkDhLj --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Petr, phodina =E5=86=99=E9=81=93=EF=BC=9A > Though the issue seems to come from the Archlinux Wiki[1] where=20 > they supply wrong CONFIG options. Well=E2=80=A6 yes, it's a wiki. The Arch one in particular has a=20 reputation to uphold. Still, it[1] doesn't suggest either of the problematic + ("CONFIG_ASHMEM" . m) + ("CONFIG_ANDROID_BINDER_IPC" . m) values. These can't work: config ASHMEM bool "Enable the Anonymous Shared Memory Subsystem" config ANDROID_BINDER_IPC bool "Android Binder IPC Driver" So don't waste time hunting down dependencies which don't exist.=20 The third-party modules[2] were never part of Linux and are by now=20 well obsolete. From=20the same wiki: > CONFIG_ANDROID_BINDER_DEVICES=3D"binder,hwbinder,vndbinder" > [lalala lala] > With your new kernel, you will need to append the following to=20 > your > boot arguments: > binder.devices=3Dbinder,hwbinder,vndbinder,anbox-binder,\ > anbox-hwbinder,anbox-vndbinder Why does it first recommend a different value from what =E2=80=98you will=20 need=E2=80=99 to boot with later? Merely because it's the Kconfig=20 default? This does not fill me with confidence. Later(!) on, it suggests yet a third, seemingly preferred, option: > scripts/config --set-str CONFIG_ANDROID_BINDER_DEVICES "" > [because] > Not everybody was happy with the binder module in Linux. To=20 > address > the issues, binderfs was created. One has to choose between the=20 > old > and the new way when compiling the kernel. With the options=20 > [above], > one will use binderfs instead. So=E2=80=A6 maybe that's the cool (and more secure) new thing and we=20 should be using binderfs without any DEVICES instead? Is binderfs=20 some kind of /dev/pts for them? Have you tested Waydroid without=20 any? I'm picky because I want to suggest the following, which makes it=20 important that at least one person understands these changes and=20 that we get them right: Do we really need yet another kernel variant? Building=20 nearly-identical kernels on CI is quite expensive, especially on=20 ARM. Let's not add them lightly. Is this code so dubious =E2=80=94 compared to the rest of CONFIG_STAGING,=20 which we already enable =E2=80=94 that it must be quarantined in a=20 separate kernel? If so, why? Do these options make practical sense to enable on non-ARM=20 kernels? Does Android run on them? Why was CONFIG_ANDROID_BINDERFS set to #f in your previous=20 patch[0]? Typo? Evolved knowledge? I often forget to do so myself but still recommend adding a=20 human-readable =E2=80=98v1 -> v2=E2=80=99 changelog (that won't be added to= the=20 git commit message) to explain such changes and catch any=20 unintented ones. Kind regards, T G-R PS: Another nitpick, but as CONFIG_ANDROID =E2=80=98unlocks=E2=80=99=20 CONFIG_ASHMEM, please move the latter to the end of the list. [0]: https://issues.guix.gnu.org/51771#1 [1]: https://wiki.archlinux.org/title/Waydroid [2]: https://github.com/anbox/anbox-modules/issues/75 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYY+/Iw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW157vgA/1y6AQ/G7dtNJfxiEv6V7Ac2B795Iz9L4tkAlHUE k+JfAQCzGGWShionGMe+S39UHYX3k7jrfMUHMV0sVTFRaBOyAg== =S0PO -----END PGP SIGNATURE----- --=-=-=--