From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qBW+Gl3Jj2FQNwEAgWs5BA (envelope-from ) for ; Sat, 13 Nov 2021 15:19:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SCBFFl3Jj2FgBgAAbx9fmQ (envelope-from ) for ; Sat, 13 Nov 2021 14:19:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EBEE32CB57 for ; Sat, 13 Nov 2021 15:19:08 +0100 (CET) Received: from localhost ([::1]:39762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlts3-0001aw-5G for larch@yhetil.org; Sat, 13 Nov 2021 09:19:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mltry-0001an-7m for guix-patches@gnu.org; Sat, 13 Nov 2021 09:19:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35236) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mltrx-0002He-VL for guix-patches@gnu.org; Sat, 13 Nov 2021 09:19:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mltrx-0006WG-L7 for guix-patches@gnu.org; Sat, 13 Nov 2021 09:19:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51663] [PATCH] gnu: u-boot: Fix rk3399 boot from emmc. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 13 Nov 2021 14:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vagrant Cascadian Cc: Pierre Langlois , 51663@debbugs.gnu.org Received: via spool by 51663-submit@debbugs.gnu.org id=B51663.163681308424977 (code B ref 51663); Sat, 13 Nov 2021 14:19:01 +0000 Received: (at 51663) by debbugs.gnu.org; 13 Nov 2021 14:18:04 +0000 Received: from localhost ([127.0.0.1]:46782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mltr2-0006Un-4S for submit@debbugs.gnu.org; Sat, 13 Nov 2021 09:18:04 -0500 Received: from mout.gmx.net ([212.227.17.21]:46117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mltqy-0006UB-NK for 51663@debbugs.gnu.org; Sat, 13 Nov 2021 09:18:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1636813072; bh=PzHhrZZYW/UUzQZaXqTfcoWgMDZdDMqMzPJIcL0kca0=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=J5EF3MhnM11PoAJGQfli+gAzIzCm5f15bouJ61KWmsaAjHrl02DEV0Thml6sx+6td YD2f3qEXiEHua+Rq1wj8/2tw4owrWz0Vm5QKTY4bGHr4llzsz83IEfPrwg35ouDp6d f/U3jgOKG0EkOse/J3ctAik1HCQeE6nbjn1LAY+I= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MBUqF-1mqbct0gpj-00D1S0; Sat, 13 Nov 2021 15:17:52 +0100 References: <87a6igav2l.fsf@gmx.com> <87sfw1fcxd.fsf@yucca> User-agent: mu4e 1.6.9; emacs 27.2 From: Pierre Langlois Date: Sat, 13 Nov 2021 13:35:09 +0000 In-reply-to: <87sfw1fcxd.fsf@yucca> Message-ID: <87ee7kcf79.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:W4k+CJtxMdyj0pIm5RgE7cOlM3mx4yIMuIcE7pUP8bvIXk/AcRK vcAxMUdlVk7qw2KeuN2ghemXxuS9KxRDanFBr/nq8aGklWt3njpULduN90+HwyGbeWSY5nq i/az4X1toJL2vx+nQM0461korcOuQ5zt37IJXwZA42J0co1pXt1Gu3/X6GeWRUBa4/mk2yJ x59FfjVdKxHjM6wGv+yIg== X-UI-Out-Filterresults: notjunk:1;V03:K0:/tFDT/k9S8c=:r9NRewB1NldQGPEd/PK2j8 M8k2Ynh7ZDtVFGltOeac5DoBnXTztZNaTj91Oixot9bQeKyP+C8NejBYtVNZQb13q4yqC7WSC xzQOtjPLpaSTDcV9eutQISRnajbkpWa0MAb6xsc1Jo9JSQz9vxfhtpqiXLsyDrgwvoHnSF/RF 0k4BKIBAxJm8kZ/wAryO6KcPmgku/M2gxeOONL8c4peUxsvmbzt+6IJYh9PKjzBIeHwtnQUOJ 7Bx2v/tra0EZWuTdnV4nr8XUHK3sS31sbK38V4ac6vrStGnP+J67rmW2CTYDuYOgjwQRQ5d4z 9t8KM5yHyNNLmta+ITUxPR9/SBY6soy2DG/HUuG5a2YICk7IeaOR6XNzecdxAwfNaafVjbIX3 nmjAFtYXsYL+IzLEwxWw/uBeyJVPmyE/K8gviffqfie2KHoRuJ0tFjRAiu53ztp6hSuJXPh1W /vOSMzX0fvMGy37zUdmknxqckS7HvPqMWj4A470cpvhgLBD3xqGd09KWvwONAH50sSX78Jk+4 AKvXrT3YuaGJtJ/Ee07xSUXcwjQ8O2CxtXwXMPQwYV+pMdgMLB6ngkWi8gV1+1kINhPh+OJHJ IUuUOavZh1zz+Hg99iSSH1XWf3mEBP3PbuKPO+e6/FtQIsCsUi+97Cq8tekPJPUFt+jvtocvs VTAGXDy2hinG/lQHOMBiHWOVNx6CWlB/V6yL8KLG5KdcrJg9MHikRXmValRjzwZGR7hkHistM XsVncU132b1SWbC/Ztg418eYS9Z0y1OaziVOVS88QLOwGNgI/2IZc7KicMz6+lv3fha7HDkx1 9/CXWw7pSs/Kv1o95k/Mluk7tmdLPiMFwaxD6SlngkBrpzHuh3NJkZWLE93w1x7MXq1RQlexp b+mJSW86UX4PKfRuxpeW+m3jyv4x6o74C/ivG8Hos9KsD9U5dyFy9yNm1nojqTVm5q3/tF3e/ ZwAQAUIExqIINbDUBo5Ie0MhHITZcks6kQAjwwFJeGcAq0OHMp4R55YpFhCmv+4+e75/t1cqA OruRLtysI6v1wCsxsoSmj68JGg0YPhJo6d5Dg/A5gEV50x+DTWapKSQwBAFiBRZbBKk9utZbx 8IQ+LETmisPhLI= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636813149; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=w5oYMQQEpXgUWBDG988yVSlgT4Ufq+B5cTYNmbmxofg=; b=JzmhJ/kx9bEJnpw96vBJKR1BEBzA34d1Ho61D98yX0V3py61WaoD6vk+7w1gmQEj2446Jo 6h7tXJBvuoqAckMaNGReYZEm63qDNCp/RH5bZ4um7v99wwd7UP1x5g5Z9Tr4ALk+GYf+Zh ky7GugYT1e2XzRRFr6rnZM1Ef5txFBlhYHdck3997pIkEk8AlLcipe8aon88tzlZRoNtS6 UrR0K9plmaGIaKH3MintXrxLEAmnG3TjetQakelWxQzwJCjkEeCIJOBFNAMdnN+3MdJSZ+ INtMD69PcUmjqSB6IBjEBKd3XA9wL+wy8PUvD9r/UsrVDCEvmbbfR+g/dhyc2A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636813149; a=rsa-sha256; cv=none; b=ZCZ/w6BAZd1rwfFeHjHRyfmo6y4zu+zvbEGYTMD1Ajw/tTqZN7WnvCyV4PGjOo7bpq/keE H58X7KxSVzZCp7yDbSXFbZku7JYsQ1wOIHW2DPqBBeUkkGmljit87wKSakK+KuxaF5KVv2 BwkpsIOUCusl74tTupumbWsEzIIOB9OYQ3u+wen6J0mjOLO8bWofRSBVwlm8RqBxIMlF/s Mj7Apgg7HHbsvUwngapzU+LWYjzNoiIo7WQfjAklHZHqcRRbAO3mZhe1x6hiJD78re6A4x /vuI993PP9he/NMJd8yP+Q4XOvxmmLsiWMyHhgHE5pGVuJagsTDImn9zSzNz8w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=J5EF3Mhn; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=J5EF3Mhn; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: EBEE32CB57 X-Spam-Score: -3.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: Fw5aMjOXvElU --=-=-= Content-Type: text/plain Hi, Vagrant Cascadian writes: > [[PGP Signed Part:Undecided]] > On 2021-11-07, Pierre Langlois wrote: >> I'm afraid the last u-boot update broke booting the rockpro64 and >> pinebook-pro from the eMMC card :-/. Going through the u-boot ML, I saw >> that it was reported [0], and this fix [1] should be applied. >> >> So here's a patch! I tested it on on both the pinebook-pro and >> rockpro64. >> >> OK to apply? >> >> Thanks, >> Pierre >> >> [0]: https://lists.denx.de/pipermail/u-boot/2021-November/466329.html >> [1]: https://patchwork.ozlabs.org/project/uboot/patch/20211101044347.17822-1-yifeng.zhao@rock-chips.com/ > ... >> diff --git a/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch >> new file mode 100644 >> index 0000000000..f14a9ce104 >> --- /dev/null >> +++ b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch >> @@ -0,0 +1,26 @@ >> +adapting commit ac804143cf ("mmc: rockchip_sdhci: add phy and clock >> +config for rk3399") to fix the issue "Not found emmc phy device". > > I'm a little confused about this comment in the patch... is ac804143cf > the commit which fixed the issue or broke it? is there a reference to an > upstream commit and/or issue that fixes it? Yeah it's not very clear to me either, I think ac804143cf is the commit that introduced the regression indeed. Doing a bit of digging, I don't think the fix was merged upstream yet though :-(. Instead, I see Fedora opted to revert the problematic patch, along with another dependent one. Probably before the fix was posted to the list: https://src.fedoraproject.org/rpms/uboot-tools/c/37df227bc0961f9f0dc4dafa9e983290dbdb2bc3 https://bugzilla.redhat.com/show_bug.cgi?id=2014182#c3 Given it's not upstream, it could be safer to do what Fedora did and revert a couple of patches, what do you think? The fix is from the original author so I'm inclined to trust it, I'd be surprised if it doesn't get merged. Thanks, Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmGPyQoYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UaQgH/2INSVLAYFCGTcx68Cjx4ewG cFx8SmJC2t2dhMSPrkO9/LSsgdekBAk9Dwj5DPwXfNSmfyOCZDoFvKo6DQ6qXNl5 lvXMRi6R8hZAgzjlgn/BK4ecvcwzOvpZk61tIDTHo2cmwFg2+8pdWppOsaJH+dVM uY/87Jyd+pL81Q/nK7rnJS7F3LetLD0HGCkcPtLd2lQpC6sR83Bt2u7ZkvKfoBwt 0LCWt2Lhs/X1QLkTJJRQKGyOGmV4LUa52F/+SdfqLE/E7UZcrya7h75z00jexi32 Jh9m644BelmrCbpWMoBG4HFT4To+2gTetzO2uevrN5hL7xQUVm+fdGy/90chaU8= =C4QF -----END PGP SIGNATURE----- --=-=-=--