From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MJrXKwAetmEy+QAAgWs5BA (envelope-from ) for ; Sun, 12 Dec 2021 17:06:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oC5zJwAetmFnJgAAB5/wlQ (envelope-from ) for ; Sun, 12 Dec 2021 16:06:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7281198CB for ; Sun, 12 Dec 2021 17:06:24 +0100 (CET) Received: from localhost ([::1]:54688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwRMl-000564-Ku for larch@yhetil.org; Sun, 12 Dec 2021 11:06:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwRMQ-0004e2-Ly for guix-patches@gnu.org; Sun, 12 Dec 2021 11:06:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41367) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwRMQ-0005P9-CZ for guix-patches@gnu.org; Sun, 12 Dec 2021 11:06:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwRMQ-000088-1e for guix-patches@gnu.org; Sun, 12 Dec 2021 11:06:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v3 00/43] guix: node-build-system: Support compiling add-ons with node-gyp. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Dec 2021 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath Cc: 51838@debbugs.gnu.org, Timothy Sample , Pierre Langlois , Jelle Licht , Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.1639325102405 (code B ref 51838); Sun, 12 Dec 2021 16:06:02 +0000 Received: (at 51838) by debbugs.gnu.org; 12 Dec 2021 16:05:02 +0000 Received: from localhost ([127.0.0.1]:52908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwRLR-00006M-R9 for submit@debbugs.gnu.org; Sun, 12 Dec 2021 11:05:02 -0500 Received: from mout.gmx.net ([212.227.17.20]:50829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwRLO-00005t-Jv for 51838@debbugs.gnu.org; Sun, 12 Dec 2021 11:04:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1639325087; bh=Zx3VEd2LVXvT8hLxbgmVlyTMAY00wLTwl0GNnD54tGs=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=i5l1J/vfz/AAnkyA89t+fucfOuComXQeL1tbbHpkmpezbvEimYUHseY/VFzxtLm+q ChE5nbYOdeUSehHUMlqYk63ttOebK2Zi3Vxt9wt+FZSl2HKc9AZi4qOpd9uy9j5Gnl o99Oede2YLdA6S3OS6Zrp5DO18UwTYKHCytl7Sjs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mlw3X-1mELAC2J5n-00j3zb; Sun, 12 Dec 2021 17:04:47 +0100 References: <46a042bc08eb72a068b1e8c69bfe28cf2d4b2e53.camel@gmail.com> <20211208202838.752542-1-philip@philipmcgrath.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Pierre Langlois Date: Sun, 12 Dec 2021 16:01:41 +0000 In-reply-to: <20211208202838.752542-1-philip@philipmcgrath.com> Message-ID: <87ee6h24it.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:vMzPQsySHxztWcZ5ENqbAOo/Uh9SvsoOINz32egJRIjX3nFiUEE H49DG3Lh3YTV/PIKV5fuaGi3s6qwjd7+bSlkpknDjEU+BeqIdHzYt4OnFfRWAVNjNpVRmWu z3bMEW+kXbU/Y5OX5PpQdqMTPM0nsi/S8m7WNK8lKOuJ+5CIT75NpYLV14bniZ2BMP6uQ4e E2lyHO3cj+qWJAngiUamQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:2e/8UlNOSlU=:9CElUvKRdL2efw5Ytj+YrP 7wZzXyQHvL3qBWb4YFgQPC/Ou/coBDZ7O65oULAtLtNwFmhp9XcnBoHUedSs5KtffkTdPxbAA fEATTVfWVDqhrm+lIpOLSz7twcfS0Y5025WBbxpGANauBVIebBpMmwULodaIfISRWmKLXihPa NwJxsPH86sLwu+kS5h/ny3yGk0qSqZSdxqs7V2U/AmPPhaAo9i+x9NHDrOl2WAvKu3/pVNEIw 0GgBtBQAVZDvTj71HQztBBVOC4G9+8VkuPgOO0mgzks5ocMeTbt3KlSaF8ACeCkBa90Vc3me/ 8/vogb38mWZygTAYjX62kMyM47ecvP8FG6z/aHLIc+o8xjzv6labvYzM+d3bVHgeyh63CNXfA BV2FgdW7ffhUh5moeBry+37EI5uBuZMmk/luOP6O0OncdswB7N6omwQb208qGgPfh/4ejqAlP q+XP59CJw+UDLNLdZl1tIUE1MrAxgXCm2/sFhy/opYjLvyVCPPl7RY71b5JgSECL6HK4KySD1 otXxbj+Jys8BPK7qotWzHlILuIVAMK1H9mxdCJH5jHorrmcOPY6kdCORTyl157MUeoZcwbwzd 43eIJRP55Wtm5GdIu+YL7yh8PEtWcmbm00yvf+qOgo+uWbjeEga9z4zxIjmnpQSOquE8mOHdu rn3wlUYo1kUvRkjAAFIixkDqtFPVEYx0NOXwSyI8RUUr5NdDjtATvePnPX7ro8vATunAsTNnk 2Q2jCHYPq8VeXXwgBhX4YH4DZG3fjgC5SsyH3b02uKrJYBkMvJ/JxZ1DUvk12OcEcuJ/CW3wG 6+VCbljzGooS39cRvv6QIjoah4jzIzy6HjE1soa5C4vRkutnwT3f8RJY8EIT7GUIN5ERb+s6I uLF1qO/RPQbDeUGlDK+VnO27RPCTHdZdChdOZLXOM/hA5vbOabJM6KN6vym+pGGpztQb2JG18 O/LxbHezuq8FfLi7192riVJpPUgdQxIobZk2rxuTj8eQr/MfrlEToWBvvsVhnVY1wg/LluFyg dKM2aKwDH+fmDhZcLEApeMsXqYFyD9V65NNXq8y+2WgZAx4gGyh8Jd/O7Ge9Je+dnsQl0z8lS wOcAdGdN3cAVho= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639325184; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Zx3VEd2LVXvT8hLxbgmVlyTMAY00wLTwl0GNnD54tGs=; b=G0Gfw0PsX1qDEoDFTM21VGqq73+3XKB6XUPHC778e7CMWbRgZamlgxevBvos7jdFXRbVC6 SiFNY9DKnO/XBg+Zdx5i6Qqo2NGLVae4fezcdbdWSQd3riEC9bEWLHklwzAONJKUTNRr5n 6wWypmNgxEvQ5yB8HsNc1z3vqHHudGI3KkkCVIOp0AAlYP5atriVupZyxiyT3l8dufQV00 peMSrVe9cEPK3aSqK6RFP1iorn2TOFIT0ODk/pmgoa1HmsCj0VY3GQCVTULTarOA3vJycs FhR/eryO9BfJiDczJzX+tD3A8rFnJAjFAsC1fDtpO/5Ex6FPP6xsWXlJ0tG20w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639325184; a=rsa-sha256; cv=none; b=g9nOXvacB8CfO2HMlqMUU1F65M7IsW83hPguYwSJRly/klwCS3kZawPkghFiUDSvZSww9T isCSHFT62cEc/XWonKaAxGMQTmCUISH9DcXLRdv7WaRF6WOMP0n35zpom8jv5VIIeAw9Fd aNuMeAEDxrSEc5aJxG51FfD77kRyG2biLladeVZHuv8XvLhZgcVZok5vbfqCvzLqk0h5ZW v9xcTWAsVVbfpKrWq8vA1YaG60iBhgdLBkb1uBNI43N+bb0bYygDG3FnyqHQz5tqnqmOCo EAswNJ9+6944Q5fvxIq8gByPb7W46vUpg4iuz2eNJmLF/6j5nfO164/EG4qPNQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b="i5l1J/vf"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.47 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b="i5l1J/vf"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7281198CB X-Spam-Score: -2.47 X-Migadu-Scanner: scn1.migadu.com X-TUID: mY6jZ5WiMSUD --=-=-= Content-Type: text/plain Hi Philip, Philip McGrath writes: > Hi! > > Here is a v3 of this patch series, hopefully incorporating all of the > suggestions. In particular, as Timothy suggested > in , I've tried to make sure the earlier > patches, at least through #:absent-dependencies, are able to be applied even > if there is more discussion needed on the later patches. > > As I mentioned in , while experimenting > with v2 of this series, I discovered an issue with the install script > automatically generated by npm. Patch 21 ``guix: node-build-system: Add > avoid-node-gyp-rebuild phase.'' fixed the issue: I explain the details in > comments there. > > This series also adds two additional leaf packages, `node-segfault-handler' > and `node-serialport', that confirm these patches can support additional > styles of native addons. In particular, because the native addon for > `node-serialport' is actually in one of the intermediate packages, > `node-serialport-bindings', it serves as a test case for the new > `avoid-node-gyp-rebuild' phase. > > I've also put these patches up > at , > if anyone finds that useful. Thanks for working on this! I've tested the series and rebased my own work on top locally, it's working for me so feel free to add: Tested-by: Pierre Langlois The series looks good to me overall, I'll add comments in each patch. Thanks, Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmG2HZoYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UG54H/0cQAunqiscLjtpyMzbMzBPQ QrWZEpyAehJkOUubyG2TwTaQb3ZuHpZMaXoNBJwlUuNOTA0nO9JDSkpwhytCZxHy M5xFXY+BA109EMoxfWRP4bz2n+fkvqwTrg82j9bKZN/wpFE2v4wq3bgfy5jfXFrC hgLWXu9eP+538JQhI0OFJRWgIzMf7qs/Aj/f8RuYIJPO2DqU8Lzgob/2hy2uFq6D bHdeGUjFKNK/2kPeQ8Qa+9EJta1wUjjw0OlRXqjeogvfFIOHGUA8foOvIFQ0/OvG RKQ/hBv5wjZ0QBPZxJbVHhHJTIXwS25HTBLi3rCiOITdEViyXUDzN65a1+G36FY= =Y2U9 -----END PGP SIGNATURE----- --=-=-=--