From: Ricardo Wurmus <rekado@elephly.net>
To: 48735@debbugs.gnu.org
Subject: [bug#48735] [PATCH] gnu: Add clojure-tools.
Date: Wed, 12 Jan 2022 09:45:02 +0100 [thread overview]
Message-ID: <87ee5d5oc3.fsf@elephly.net> (raw)
In-Reply-To: <87o8ct6kfe.fsf@reilysiegel.com>
Hi Reily,
this new patch set looks good. Thank you very much!
I just have a few minor comments/questions:
- build phases and snippets no longer need to end on #t or #true
- nitpick: I’m not a fan of the somewhat unusual location of the
“home-page” field, but I understand that you’re reusing the URL. My
personal preference is not to do that and to move the “home-page”
field above the “synopsis” field.
- some packages have disabled tests; it would be good to add a comment
as to why the tests are disabled
- some descriptions are not complete sentences.
If you can tell me about these disabled tests (e.g. in
clojure-tools-deps-alpha), I can add comments and make the changes I
suggested above when applying the patches. (You don’t need to send new
patches.)
Thanks again!
--
Ricardo
next prev parent reply other threads:[~2022-01-12 9:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 2:10 [bug#48735] [PATCH] gnu: Add clojure-tools Reily Siegel
2021-05-31 9:15 ` Maxime Devos
2021-09-03 16:11 ` Ludovic Courtès
[not found] ` <87r1e5636w.fsf@reilysiegel.com>
2021-09-06 7:56 ` bug#48735: " Ludovic Courtès
2021-12-23 23:04 ` [bug#48735] [PATCH v2 01/10] gnu: Add maven-resolver-transport-file Reily Siegel
2021-12-23 23:04 ` [bug#48735] [PATCH v2 02/10] gnu: Add maven-resolver-transport-http Reily Siegel
2021-12-23 23:04 ` [bug#48735] [PATCH v2 03/10] build: clojure-utils: Don't try to compile Clojure Reily Siegel
2021-12-23 23:04 ` [bug#48735] [PATCH v2 04/10] gnu: Add clojure-test-check Reily Siegel
2021-12-23 23:04 ` [bug#48735] [PATCH v2 05/10] gnu: Add clojure-tools-gitlibs Reily Siegel
2021-12-23 23:04 ` [bug#48735] [PATCH v2 06/10] gnu: Add clojure-data-codec Reily Siegel
2021-12-23 23:04 ` [bug#48735] [PATCH v2 07/10] gnu: Add clojure-data-xml Reily Siegel
2021-12-23 23:04 ` [bug#48735] [PATCH v2 08/10] gnu: Add clojure-tools-deps-alpha Reily Siegel
2021-12-23 23:04 ` [bug#48735] [PATCH v2 09/10] gnu: Add clojure-tools Reily Siegel
2021-12-23 23:04 ` [bug#48735] [PATCH v2 10/10] gnu: clojure: Remove wrapper in favor of using Reily Siegel
2022-01-12 8:45 ` Ricardo Wurmus [this message]
2022-01-12 16:44 ` bug#48735: [PATCH] gnu: Add clojure-tools Ricardo Wurmus
2022-01-12 9:23 ` [bug#48735] " Reily Siegel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee5d5oc3.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=48735@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.