From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 3K8VNeIxW2JYdAAAgWs5BA (envelope-from ) for ; Sat, 16 Apr 2022 23:15:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MF69MeIxW2LY0AAA9RJhRA (envelope-from ) for ; Sat, 16 Apr 2022 23:15:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9DB6D173CB for ; Sat, 16 Apr 2022 23:15:12 +0200 (CEST) Received: from localhost ([::1]:45864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfpl9-0004OA-Rt for larch@yhetil.org; Sat, 16 Apr 2022 17:15:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfpl0-0004Nu-Ao for guix-patches@gnu.org; Sat, 16 Apr 2022 17:15:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nfpkz-0002p1-UF for guix-patches@gnu.org; Sat, 16 Apr 2022 17:15:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nfpkz-0007gf-Pi for guix-patches@gnu.org; Sat, 16 Apr 2022 17:15:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#53765] V3 Patches Resent-From: Reily Siegel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Apr 2022 21:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53765 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 53765@debbugs.gnu.org Received: via spool by 53765-submit@debbugs.gnu.org id=B53765.165014369729528 (code B ref 53765); Sat, 16 Apr 2022 21:15:01 +0000 Received: (at 53765) by debbugs.gnu.org; 16 Apr 2022 21:14:57 +0000 Received: from localhost ([127.0.0.1]:34466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfpku-0007gC-TJ for submit@debbugs.gnu.org; Sat, 16 Apr 2022 17:14:57 -0400 Received: from mout-p-201.mailbox.org ([80.241.56.171]:38518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfpkp-0007fv-Vb for 53765@debbugs.gnu.org; Sat, 16 Apr 2022 17:14:55 -0400 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4KgmDP61ggz9sQW; Sat, 16 Apr 2022 23:14:45 +0200 (CEST) From: Reily Siegel DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=reilysiegel.com; s=MBO0001; t=1650143683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KbHLAavOKfMjMnlbP96j0l+ZrpbzwwlNBBKQyDSyyHY=; b=RubJglPCWodd5DoeyBHMXspwM8djLnRGBNtxSoiaY/Dy0sramEeKS38XS1M+vMtSHTv5+o gKu92TSy/AyZ6Zql9yexR84SFp6sKpZJPaoI+BQkZTYwbiP9jaoMuJDZGhu9cGNOa3F7AB E+9wvVJHr/Pa6Ln9NY/fckev+db0/M3TW+rkvbjMrpQiZqWtiLsq0dxxUB/0KsM0G9yT1c qO8CtyZw7OS8bzDwjCgZ3GyVGtTgFw84U6xn+08T+oXvS/wb/CnhKb28/7GWI/pxwdaWjK 3a/i2nKwd+Wq7xpqVwZNo5qPfhFuruyDli2Dr2DHpabLbajrwQk2HfOcct5G1Q== In-Reply-To: <493d15b8061c427b3ee2bf59f2b909291195b375.camel@telenet.be> References: <87zgkmlad7.fsf@reilysiegel.com> <242fe49e1d65869b2eb72f64041e3e08ef57702e.camel@telenet.be> <87tuatgc6b.fsf@reilysiegel.com> <87r15whlds.fsf@reilysiegel.com> <0635ca7dec80f3541efe49c8056844928d346ee5.camel@telenet.be> <87ilr8hjjc.fsf@reilysiegel.com> <493d15b8061c427b3ee2bf59f2b909291195b375.camel@telenet.be> Date: Sat, 16 Apr 2022 23:14:41 +0200 Message-ID: <87ee1whgse.fsf@reilysiegel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650143712; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=KbHLAavOKfMjMnlbP96j0l+ZrpbzwwlNBBKQyDSyyHY=; b=o3EHqd7omxcXYTQXym9VmSz0Di0mRznC5v2ejDVPeOnzN7Rd/Ad/o5t4gNIxiHGeqA/o9y yT50qWvBWaA88l6+vBDQ4P4mxzmA7OJej+3MmIBwW+IZtsN/lCbLlX651E0XJeBWDao8Sn lhsHq7z+TyTa7ZbAUUaSrlTz7LOHZD1w1fJVziB14jB6+8U9iL1N2GOD3MIMfpxqc+0Rs9 icGRAH42UMHnzqv42G4iuzaGnqpPbpOjXVEMMTnAZJXWYhoQa2SdkdU7e2mU8zV0fvt0K/ WNd/GY4m9EDtKn7SqZuMXivYzDYTccRsLQ9TTOALSBeVakWJ463/he1zsVJB2A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650143712; a=rsa-sha256; cv=none; b=gsstsTVUoAyGK70hjHE9shygSRoIpgYs/Zf2id7txJ/o52VEqf3wN1xjkFUyzo69FQeJft RLX+2ae3eSn5TXXaG8bvYzUE57DxREe9fV7gxdlyt2QhxXw7fMGcfD6btvN4LOEThI7rDy aurtd2szNv0oye5d4iY3301mb0zuEaSCVyUy4pF2gi8yU3nGREaKs3yHtThDOmV7B06JmH j34WGn1y1QVZMJu7Sfh0l+rjlAFfZE4XOpRh7YX8/Qt6FhQ94wOEOR+EtKSV28SVR96Mno iJMaRngeIgigyh7gOtzztzQ9NU/Ix1uqQJWeOG9FAdJqXLNxOWdijplVk+zevw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=reilysiegel.com header.s=MBO0001 header.b=RubJglPC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.76 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=reilysiegel.com header.s=MBO0001 header.b=RubJglPC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9DB6D173CB X-Spam-Score: 0.76 X-Migadu-Scanner: scn1.migadu.com X-TUID: 8Ct0sE5gJV8Z Maxime Devos writes: > Reily Siegel schreef op za 16-04-2022 om 22:15 [+0200]: >> Maxime Devos writes: >> >> > > Is this issue blocking for the inclusion of the package? >> > > >> > > [1]: https://github.com/cognitect-labs/aws-api/issues/116 >> > >> > From my POV, yes. >> >> In this case, would you like me to submit an alternative patch that >> keeps these features patched out, but silences the warnings printed that >> S3 classes are not available? > > When do these warnings happen? Only if the user asked to do some S3 > things, or also when no S3 things are done at all? If it's the former, > I don't see a reason to patch out the warnings, though if it's the > latter I agree. These warnings happen every time the tool is run, here is what it looks like: "Warning: failed to load the S3TransporterFactory class" It is very trivial to patch out. > I haven't looked at the v3 patches in detail yet, but if the > com-cognitect-aws-s3 package is not part of the v4, then I expect the > v4 to be good. > > FWIW, I don't think I'll have time to look again anytime soonish. If I simply patch out this one feature, the resulting patchset will be much simpler. Most of this patch is adding dependencies of aws-api. If that can be patched out, the only change needed over the existing clojure-tools package is to remove the one line responsible for printing this warning from the file, should be doable with an easy substitution. -- Reily Siegel