From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iJusJZEht2LgcQEAbAwnHQ (envelope-from ) for ; Sat, 25 Jun 2022 16:54:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mGSSJZEht2LBSQAAauVa8A (envelope-from ) for ; Sat, 25 Jun 2022 16:54:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8541115ABC for ; Sat, 25 Jun 2022 16:54:08 +0200 (CEST) Received: from localhost ([::1]:44460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o57Al-0002TS-In for larch@yhetil.org; Sat, 25 Jun 2022 10:54:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o57Ag-0002T3-2A for guix-patches@gnu.org; Sat, 25 Jun 2022 10:54:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52117) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o57Af-0003pI-QY for guix-patches@gnu.org; Sat, 25 Jun 2022 10:54:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o57Af-0004wZ-Pe for guix-patches@gnu.org; Sat, 25 Jun 2022 10:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55891] [PATCH] gnu: Add iec16022 Resent-From: Remco van 't Veer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Jun 2022 14:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55891 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55891@debbugs.gnu.org Received: via spool by 55891-submit@debbugs.gnu.org id=B55891.165616881318969 (code B ref 55891); Sat, 25 Jun 2022 14:54:01 +0000 Received: (at 55891) by debbugs.gnu.org; 25 Jun 2022 14:53:33 +0000 Received: from localhost ([127.0.0.1]:46014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o57AC-0004vs-T8 for submit@debbugs.gnu.org; Sat, 25 Jun 2022 10:53:33 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:49639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o57AB-0004vf-11 for 55891@debbugs.gnu.org; Sat, 25 Jun 2022 10:53:32 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A0DD35C00F8; Sat, 25 Jun 2022 10:53:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 25 Jun 2022 10:53:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1656168805; x=1656255205; bh=O/70zX3/eQ lcnHSBcueyWRWydRAvfYyIEO+yDgRnNbc=; b=SCcorm2FdRi9W9dC5cxbtaWxgu hRRJyBe/0ICMZctOPvxsPmyWMTSQfJimkcLBNwZS68IjQ6HYg0fQfal05Hz9XewK NJGehyf9/TcrJwgWI5cICMo/4dNjhYSJCCWdt7ZDS8FxiPAGutlW1seHM/1Pb8zf QrVzyL5F+ZEXMtdUd5fctMRoJ8KJfI79gLNnotdGJl5DAv/ct0oXWR5AsThrvpwZ KV8KiQMrBkQvCqkUcC5dFiv4BrXQ4WJSSyaGNI6HJk+JBu0tn5NMmA+cKsH3j6YM oe9PRWQayrwthLBlC/LW0Yz3UVslrzjukis/3goT71ZXTr1ukKBMAmmGk1IA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1656168805; x=1656255205; bh=O/70zX3/eQlcnHSBcueyWRWydRAv fYyIEO+yDgRnNbc=; b=URUDjdnd5M7BhfyzNGMCEpuuaU6cMFG2QST77HzFPMG7 AIqtm5PZ96F8JxuryGR2hMgPeJnF3ZkDe0fzTDEA1Ykm3CCRisizeUKwVWobBVad gFEbe8Ql3HbotR6VaOQ7SsofHXAZRiDa3ApLRnjALikIrbNwlK3IoqQPpMe7E5UG 99bXXnorJLiPJXSnYJ11ktFi398pSiSn0ean65eNDK11Qk9kzeUKgdqwg0ND2r7P qr2OYKnllvegT480w3mZBpLIvtbDycjKbpMm/PG4xstR1lblyU6BUOhMBU3qnA8d bfM/sS2yi5dz1vjD0AhkVWIdOXZMhryDq9bKK+CHGg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeguddgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefujgffkfggtgesthdtredttdertdenucfhrhhomheptfgvmhgt ohcuvhgrnhcukdhtucggvggvrhcuoehrvghmtghosehrvghmfihorhhkshdrnhgvtheqne cuggftrfgrthhtvghrnhepueekteetudejueefueegudegteduleelieehiedtvddvfffg hfeifeeikeelhefhnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvghmtghosehrvghmfiho rhhkshdrnhgvth X-ME-Proxy: Feedback-ID: i568842cc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Jun 2022 10:53:24 -0400 (EDT) References: <20220610150448.9513-1-remco@remworks.net> <2dfe4787038a3c9b6fe21982aea621c4447eca75.camel@telenet.be> <877d5opgd4.fsf@remworks.net> <87mtejhe1d.fsf@remworks.net> User-agent: mu4e 1.6.11; emacs 28.1 From: Remco van 't Veer In-reply-to: <87mtejhe1d.fsf@remworks.net> Date: Sat, 25 Jun 2022 16:53:19 +0200 Message-ID: <87edzceqw0.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656168849; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=O/70zX3/eQlcnHSBcueyWRWydRAvfYyIEO+yDgRnNbc=; b=P7i0/0Mno2K1CQc79focR4oMyvLrdprEeAbwy3/f6PfL4yLZSwM59CaDRSIPqmuO8ZNR1M uRlyewVrtASEgsuJbrQMQNbdonKmC8uDXIstMvLqOZ8eVq1EIGBNkaaSsMdRY3FmgqrWLi xGV3AFbCgnP00N7nFRiporygHCVG0X0RPGtafzeitXC0KQ3EOmTlae8kNveDXQFTKNNBUr qN0hl360hd0Ybo4TwHQkHHOlIVvbPIVcf7g8P5Gpt7fmHnjgwuezA9wrLnJLrL3i0o5M35 NU6DDDcC4tAcsf6YvPps2hP96WoK0mZed5c0YKeS3BsjauGedT8dsVEQEcpOfw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656168849; a=rsa-sha256; cv=none; b=L6FPJgRcigcWBg2QEk5ckYkgAD9IGCfzhTKbM72Ei/HISZQ/RnpxquD4m5tkeR0lXRMzxI mNFjJuy7xYQGxew9x+DId6T2AyPpuLp5Lj1/evfKbFNuXstxh3CDOWy8EnCa5Jz5DKGvcz q4aP2t/APm2kDszLgX8olXYAH8fw6qgBb305g02/19YLOzLTw60gyayppoiXZvLOH3gx13 TyEPX5YfxX8Wno6kM+8CmeceHR1DZYoO9FoQdUmaoVaafRXKprfCsxcSBgHdEKZXPauKs8 VZhoMyGO2gCSxfdE4DH0F0nx1zCPlOAjj047q/EfuDDUaqwo00+gn+7XNLvfug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=remworks.net header.s=fm1 header.b=SCcorm2F; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=URUDjdnd; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=remworks.net header.s=fm1 header.b=SCcorm2F; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=URUDjdnd; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8541115ABC X-Spam-Score: 1.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: NEr/KpIsEpSM 2022/06/10 23:47, Maxime Devos: > I think it's ok, _if_ the bugs are eventually at least reported > upstream if we (i.e., you) cannot fix them timely (needs some > contrived circumstances to trigger the bug). The maintainer's stance on not checking malloc response (from https://github.com/rdoeffinger/iec16022/pull/17#issuecomment-1152892833): > > I'll open an issue for the unchecked [mc]alloc and write calls > > instead if you do and maybe have another stab at fixing these issues > > when my C-programming skills have improved. > > I agree on the unchecked writes. For the unchecked [mc]alloc I am more > tempted towards removing the existing checks, since I am not convinced > checking won't always do more harm than good for those. He elaborated on this at: https://github.com/rdoeffinger/iec16022/pull/17#issuecomment-1153103749 Boiling down to: when memory is that low exiting with a proper error messages and doing cleanup probably won't work anyway and the OOM killer will have swept in before the situation exists. Which makes sense, IMHO, but I am no expert. I've created an issue for the unchecked writes: https://github.com/rdoeffinger/iec16022/issues/18 HTH, Remco