From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aOYlGM6YNGOWZAEAbAwnHQ (envelope-from ) for ; Wed, 28 Sep 2022 20:56:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QOcfGM6YNGMoewAA9RJhRA (envelope-from ) for ; Wed, 28 Sep 2022 20:56:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 117C0F1D1 for ; Wed, 28 Sep 2022 20:56:14 +0200 (CEST) Received: from localhost ([::1]:50138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odcE9-0003hG-7I for larch@yhetil.org; Wed, 28 Sep 2022 14:56:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odblv-0002y6-5L for guix-patches@gnu.org; Wed, 28 Sep 2022 14:27:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odblu-0002UB-Mu for guix-patches@gnu.org; Wed, 28 Sep 2022 14:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odblu-0007q7-HQ for guix-patches@gnu.org; Wed, 28 Sep 2022 14:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57667] [PATCH] gnu: Add emacs-flymake-collection. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 28 Sep 2022 18:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57667 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgart@dismail.de Cc: 57667@debbugs.gnu.org, Nicolas Goaziou Received: via spool by 57667-submit@debbugs.gnu.org id=B57667.166438958230081 (code B ref 57667); Wed, 28 Sep 2022 18:27:02 +0000 Received: (at 57667) by debbugs.gnu.org; 28 Sep 2022 18:26:22 +0000 Received: from localhost ([127.0.0.1]:34611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odblG-0007p7-Ea for submit@debbugs.gnu.org; Wed, 28 Sep 2022 14:26:22 -0400 Received: from mail-qt1-f181.google.com ([209.85.160.181]:36811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odblF-0007ou-4w for 57667@debbugs.gnu.org; Wed, 28 Sep 2022 14:26:21 -0400 Received: by mail-qt1-f181.google.com with SMTP id h21so8487167qta.3 for <57667@debbugs.gnu.org>; Wed, 28 Sep 2022 11:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date; bh=aANNHX4NYaVzk9lz+ya9d4NiLLU9OdM2hy+BH3fTL04=; b=kR081tbdK/bxD7NFfWTXBIp0qq1J7m6XoopviZFcVO+Wk8zSaJ2zLqHoVVKMe52HA6 mxSSO6EQkmo5FIJyAS6ui86s92g/ecRGos+LWtWsvSTMQMb0UzbvgZyWVbG5IwcHOs1S liT4RDGWgyIXPNgrCWb7TVqXjIno5uIv/FZFp7F/rT26wZ9LJdmZpkwmgSx5++7fyqtw Gg4cd+eqLiulGgWaIiPfgyT4a1ZjYDM4rvDS7n1t56BL0P2OQmOgGgfKH4iQfk0K94GV NDTRsdrBTIXzb2ISikHWZ/pIKFbTanZIzG/cBgdrTZiA3uXMXxVvauJNPbN9z0T3TnYz mRLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date; bh=aANNHX4NYaVzk9lz+ya9d4NiLLU9OdM2hy+BH3fTL04=; b=kdWI3WImzJmDMkgpczXvq2Dvwwm24jN5IpSp/YdOMaWUiQxOVeLs6zyQikaXoYht2r mGHZvRZqBetzpPeRCPG5ghmksgLHnMx+68Em6s+VpYiVeLmMoZaiU/M6eiz4Vu1j6f+2 mpvwqeCwE1d5jrjYvN+uItURc86zHOBHBjNRKuuAGdzujEK5EFfnortC67RRP6GYzjXh 73hrpNKvIwyHfK0UlqdSwK+cEF/d9SCffB0r7PZrks2WntwUdfgUZ8UkVb7X+Rwd3NGh gKC2WFIBl8owMMxcMuTpaw1zpBg7Jh/FjFn3QoOCLd11D+HN3MkLmb4szouYpb8we5Y/ c7pw== X-Gm-Message-State: ACrzQf3hhZ/u4RJ60U8cE9ZHQGzmYbvL+yt8hWszQhkU5E9A85Wv3ji4 cplfvzV0F1d+qrmbIlqgxXbGbousKc/CFQ== X-Google-Smtp-Source: AMsMyM4c4n9tYXxv5hL0K9lyLK2t7b9LDikaAP7OK3IRkbf7dRd+QFZqknlcUvveyqYYJU9inB2rgg== X-Received: by 2002:ac8:7d14:0:b0:35c:bdbe:5b97 with SMTP id g20-20020ac87d14000000b0035cbdbe5b97mr28437827qtb.272.1664389575680; Wed, 28 Sep 2022 11:26:15 -0700 (PDT) Received: from hurd (dsl-148-95.b2b2c.ca. [66.158.148.95]) by smtp.gmail.com with ESMTPSA id q14-20020a37f70e000000b006bba46e5eeasm3537565qkj.37.2022.09.28.11.26.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 11:26:15 -0700 (PDT) From: Maxim Cournoyer References: <20220908034931.10742-1-jgart@dismail.de> <874jxhko25.fsf@nicolasgoaziou.fr> Date: Wed, 28 Sep 2022 14:26:14 -0400 In-Reply-To: <874jxhko25.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Fri, 09 Sep 2022 09:24:34 +0200") Message-ID: <87edvvuzi1.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664391374; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=aANNHX4NYaVzk9lz+ya9d4NiLLU9OdM2hy+BH3fTL04=; b=tV2Qmr6uJE1z2tdKkdLIIhcpTdGSEyYE0yJqoFvOIYdzxrG/49xvG2Fl0VQwyr3IpoJSIL kA6vUvbKT1FuY3npGZys003NrnsA0T9HSkalxgs/oz7sChWPYShwUWrzW6X8HDtNb0Nm9y o0amftk7dFdxzhXQmwJBXzzXQ7IgitprI6Pe4OssC0m2p5G/CT1rvREudiHft4UyLQk3+e OYgBfVc++k8/XHID/xECqJ2tUm0a+/T9RDd8EiLpiyjq+r/cA/q0zeWVZkg+1IGNFZwRt+ V3H4lLFLV0wrJss+LGI64yWG8HHtzVxZVu3808uWhzQK06UwlqY3D+sZz4zgDg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664391374; a=rsa-sha256; cv=none; b=IRcJHTMJABlwIAz/828YL0qnBDI9j5oGQ0FrBLz2livAccIhGlo76RGaWjqj3OFJuVK9S4 m9bcz+tA5SRD/YFxlKCV3GJkIPnH4K/bSm/qAiwweBizjhJHd1r+yi6wRKCkMgnRNbDKAO ShlAxTxjOBPZlv6v5qIhPpqibH3lznQuz8Ud2duVhelcadTKadG+7+inTdDDnx++mw2QHJ BLBU1W8K0HC26Q4RxZAyjB2q5jP5EVlxx/VNuEVi6r0S6bEWeb3KCx0ChLxHGkSehHjghL UWBEe3lHGePRW1Yd1OOTTC5o0zcIbO7oTnffWqzCm+1Vvnb/fJWvW+sTTO1Vbw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=kR081tbd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.15 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=kR081tbd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 117C0F1D1 X-Spam-Score: 6.15 X-Migadu-Scanner: scn1.migadu.com X-TUID: pvOBDLEFopT2 Hi jgart! Nicolas had done the review below: Nicolas Goaziou writes: > Hello, > > jgart via Guix-patches via writes: > >> * gnu/packages/emacs-xyz.scm (emacs-flymake-collection): New variable. > > Thanks. Some comments below. > >> +(define-public emacs-flymake-collection >> + (package >> + (name "emacs-flymake-collection") >> + (version "20220612.1340") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append "https://melpa.org/packages/flymake-collecti= on-" >> + version ".tar")) > > We don't fetch tarballs from MELPA because those are not stable. Could > you use Github as upstream instead? > >> + (sha256 >> + (base32 "1ivf7hqjnpgya6bkn83134yhw6nc29fic642jb73w60j461l2a69")= ))) >> + (build-system emacs-build-system) >> + (home-page "https://github.com/mohkale/flymake-collection/") >> + (synopsis "Collection of checkers for flymake") > > Nitpick: Flymake > >> + (description >> +"This package tries to provide a comprehensive list of > > This package provides=E2=80=A6 > >> +diagnostic-functions for use with flymake, give users the tools to >> +easily define new syntax checkers and help selectively enable or disable >> +diagnostic-functions based on major-modes.") > > Nitpick: major modes Could you please address the comments and send a v2? Thank you, Maxim