From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wNvZAmMWjWPC/gAAbAwnHQ (envelope-from ) for ; Sun, 04 Dec 2022 22:51:31 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id COLWAmMWjWOSdAEAauVa8A (envelope-from ) for ; Sun, 04 Dec 2022 22:51:31 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 91259BFFD for ; Sun, 4 Dec 2022 22:51:30 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1wt7-0001jT-JV; Sun, 04 Dec 2022 16:51:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1wt5-0001jE-3L for guix-patches@gnu.org; Sun, 04 Dec 2022 16:51:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1wt4-0003NW-RM for guix-patches@gnu.org; Sun, 04 Dec 2022 16:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1wt4-0003Bg-ET for guix-patches@gnu.org; Sun, 04 Dec 2022 16:51:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Dec 2022 21:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59822 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "(" Cc: 59822@debbugs.gnu.org Received: via spool by 59822-submit@debbugs.gnu.org id=B59822.167019063912239 (code B ref 59822); Sun, 04 Dec 2022 21:51:02 +0000 Received: (at 59822) by debbugs.gnu.org; 4 Dec 2022 21:50:39 +0000 Received: from localhost ([127.0.0.1]:59989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1wsh-0003BL-33 for submit@debbugs.gnu.org; Sun, 04 Dec 2022 16:50:39 -0500 Received: from relay.yourmailgateway.de ([188.68.63.166]:56547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1wse-0003BF-PY for 59822@debbugs.gnu.org; Sun, 04 Dec 2022 16:50:37 -0500 Received: from mors-relay-8202.netcup.net (localhost [127.0.0.1]) by mors-relay-8202.netcup.net (Postfix) with ESMTPS id 4NQL2g1cjHz4BPX; Sun, 4 Dec 2022 22:50:35 +0100 (CET) Received: from policy02-mors.netcup.net (unknown [46.38.225.35]) by mors-relay-8202.netcup.net (Postfix) with ESMTPS id 4NQL2g1DYrz4BCD; Sun, 4 Dec 2022 22:50:35 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at policy02-mors.netcup.net Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy02-mors.netcup.net (Postfix) with ESMTPS id 4NQL2f49MQz8sjq; Sun, 4 Dec 2022 22:50:33 +0100 (CET) Received: from florianrock64 (ip5b40a50f.dynamic.kabel-deutschland.de [91.64.165.15]) by mxe217.netcup.net (Postfix) with ESMTPSA id DE9E09FA1C; Sun, 4 Dec 2022 22:50:27 +0100 (CET) From: "pelzflorian (Florian Pelz)" References: <20221204195007.20997-1-paren@disroot.org> Date: Sun, 04 Dec 2022 22:50:26 +0100 In-Reply-To: <20221204195007.20997-1-paren@disroot.org> (guix-patches@gnu.org's message of "Sun, 4 Dec 2022 19:50:07 +0000") Message-ID: <87edterg7x.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DE9E09FA1C X-Spamd-Result: default: False [-5.00 / 15.00]; BAYES_HAM(-4.90)[98.56%]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:3209, ipnet:91.64.0.0/14, country:DE]; RCVD_COUNT_ZERO(0.00)[0]; RCPT_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[] X-Rspamd-Server: rspamd-worker-8404 X-NC-CID: OpbhkD2TJaYZ+iYBWLUjMs2i1HtjrbExK3GMhBmv1Gi+xTJWXJNxUUm3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670190690; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=eEcp33BNinVWvSwwOPQ8yXgqSvkiX/F8Od4qMoFDmJI=; b=tL0eOnn6TUJASnPn5H2mHeQm4rT8qARC8vQOgpRu/EAkQMxLg/vMzp1DyvHvj7I3YB981X Jg5RNkKHTdi2fGDlizBOl+plQaqohfRDR+AvgrjzowDHpbYnDUD2mZ2rCykPWfb2+c91I1 k7TxKvkfde+eGNANbjGIt08ySDunMqjNP+/8N2n3qC7ID8zj2cLLfJaJoXF8oLn+TlTM0M j7OoGQMdi34hQ8gr2hCVYeCZ0X26Oc7RD6DvpgcQz7rWAqs/Afg7Bz7RUw+OzlMxsW/zCx VVuaN65m19gv5dsaEn+bjLQK10tKdtm1vAC8BKKAA/zR/veg7VMIp59UZmQByg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670190690; a=rsa-sha256; cv=none; b=Vcasckyx1fWT6kHi+4zAQLiM4uq1VqCU8rA1dsqNxQxVJm9FJwGrXmFJmIWpuMjv8apcUH EIbRJyNgnrEaafIZoyCq6GxCwUhQ1EVymGukQZ46+3t7SDERpFrG10vaTAFrUsYooP6bLh Q6CKSMFuTc1FuQzPjfDJkDLQV/YA3T9XrVEOh+JzsgPfE1WauylVPJiJZhKTMPzqRwygBp yqOs5mptuBoNKbp/jcq1XDgW6QDmWwg03fM0hYiwnoChIXHzYdM6zluJtPvK3gXlGNUDjw Eya02fcxylDb4Q1jdJD16co9xGkZ/DZX5XDji82wKrESQ87ELC9Bxn/d6uu83g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.76 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 91259BFFD X-Spam-Score: -4.76 X-Migadu-Scanner: scn0.migadu.com X-TUID: wDUXxHwQhKS3 Hello ( "( via Guix-patches" via writes: > * website/apps/base/templates/home.scm (home-t)[#:content]: Add a > 'DOWNLOAD LATEST' button. Good idea. Would you add a copyright line or copyright disclaimer line and send an updated patch? > #:label (apply string-append > (C_ "button" `("DOWNLOAD v" ,(latest-guix-versio= n) ""))) > [=E2=80=A6] > " " ; A space for readability in non-CSS browsers. > + ,(button-big > + #:label (apply string-append > + (C_ "button" `("DOWNLOAD LATEST"))) In the DOWNLOAD LATEST button, could you remove the (apply string-append and its now unmatched parenthesis? It is a trick to concatenate the translations for "DOWNLOAD v", the latest-guix-version and the translation for "". But for "DOWNLOAD LATEST", it is unneeded. And maybe untabify the lines you change. Other than that, LGTM, thank you! Regards, Florian