From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sPKdLQEd3WOgDQEAbAwnHQ (envelope-from ) for ; Fri, 03 Feb 2023 15:41:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mDN/LQEd3WO3QwEAauVa8A (envelope-from ) for ; Fri, 03 Feb 2023 15:41:05 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7D3893848E for ; Fri, 3 Feb 2023 15:41:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNxFQ-00047Y-Bn; Fri, 03 Feb 2023 09:41:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNxFO-00047L-PJ for guix-patches@gnu.org; Fri, 03 Feb 2023 09:41:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNxFO-0000pD-HR for guix-patches@gnu.org; Fri, 03 Feb 2023 09:41:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNxFO-0001K8-E3 for guix-patches@gnu.org; Fri, 03 Feb 2023 09:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61207] [PATCH] gnu: Add opentaxsolver. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 03 Feb 2023 14:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61207 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Skylar Hill , 61207@debbugs.gnu.org Received: via spool by 61207-submit@debbugs.gnu.org id=B61207.16754352185028 (code B ref 61207); Fri, 03 Feb 2023 14:41:02 +0000 Received: (at 61207) by debbugs.gnu.org; 3 Feb 2023 14:40:18 +0000 Received: from localhost ([127.0.0.1]:36947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNxEg-0001J2-0f for submit@debbugs.gnu.org; Fri, 03 Feb 2023 09:40:18 -0500 Received: from jpoiret.xyz ([206.189.101.64]:47934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNxEe-0001Is-96 for 61207@debbugs.gnu.org; Fri, 03 Feb 2023 09:40:16 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id BA84718531B; Fri, 3 Feb 2023 14:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1675435215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x1D4s8ixqcNzAj0e0GpA55nn0S2kOWuNgGaCzmoCC1M=; b=pikTHgYuRbijw1LV+gjqLRhz4j+OeE63ay1frKOISUmXNrEmXKwgpBrh0PQTWToAeneFD2 Ls3740+vGoL/EXim3F5MJxGVv3d9InyF3dn0oJG6r6XpQCuyPH3KvT+Nw2vRMMzqRrZWTh pLU2XqWo0rSg5UPjgI1uW8q1Fx64V9nEQ2EsomYI1BKNO9KdsfnIPpb/nEZ6qhtITwkgvb iL4hwZpgBpwPvhWQun1v79rMdjzR79KchoDPEhFU8+IFiTGZQF/aMtDVeeTswc1PgCyELn H2cZ9gZr4S4YHhldlYdtAWr1lVMi2HnMBDcL6jeC76+Dne/8++otjnqm3MzTEg== In-Reply-To: <87y1pfg5pk.fsf@posteo.net> References: <87v8kmyoyf.fsf@posteo.net> <87o7qbx6ky.fsf@jpoiret.xyz> <87y1pfg5pk.fsf@posteo.net> Date: Fri, 03 Feb 2023 15:40:14 +0100 Message-ID: <87edr6x169.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675435265; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=x1D4s8ixqcNzAj0e0GpA55nn0S2kOWuNgGaCzmoCC1M=; b=iEUkfgMus2Tel6svO8WWBt0p4QyCsp0bXLt5BAUW3AFehdCAGfyK7mQZfTwCmRloQZ3ZB4 suwm2nuAyy8rU8tZAaV+bKIcX9xLPG3/uQbXnmn8hgPc6OLWhqz7j3zBf4BVlosbxxpFuk 1rJuCiW/Ch7jUBGgSnOQvQeQ4AEtBiHJeVaeWyW9qL+MjtCnhEE9HI/cYuRA72c/QD410k uLqbZf16b3ttmhwKhlnpzoNba6hC3liZHU6Ha8CLddQa/di7vTnRyBFav6gaBFJ5b6KuME 7lIghsUXeCxznLLZb/njA0cud3pGQ0xdnJZ5191ixL0/zQFkIiVkSjxBQK3ecg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=pikTHgYu; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675435265; a=rsa-sha256; cv=none; b=jh20Kvb19UCo65cwdv+jUlsVvTSLeuAwxGdebaEGr42V4dczI4165A/Keq6bqVSuwJvrr8 MU6vJk7vklUcM0ZY10DvYg5bXKwPH9QmCEI8e0SKqBMWXrjWRXLl4FjcJgaBqDenmN2kCu XVnRmeJuQh6TNg+PUvStwah0twFsKCqpsEIIqY/59VAGuU31Q73D70ihbtUNeuFPUuRuDK O1xluWEF3cv6TP7d9Xa0QqhZ0IPfzkwwAOLQScOCr8e/UjHWb6s2QYf18puDuA7pJ+BGH7 TKwOHEc+8LU/Kt2lhZ/Hd1pUWB29FkT//UpieIRfNGjmCsV1cbVTXKjft4a+pA== X-Migadu-Spam-Score: -3.57 X-Spam-Score: -3.57 X-Migadu-Queue-Id: 7D3893848E Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=pikTHgYu; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Scanner: scn1.migadu.com X-TUID: u3nzaSP3Vzqj Hi Skylar, Skylar Hill writes: > Thanks, Josselin! Here's an updated patch including the requested > changes. I also took a crack at switching over to G-expressions -- let > me know if I need to fix anything on that front to match best practices > or fully take advantage of the construct. > > Skylar Hill > > [...] Thanks for the quick changes, this looks really good, although you forgot to reply to the bug email address! I've added it again and will resend the patch, I've only removed one extra whitespace and rebased on top of master (there is a new copyright line where you added yours). I am no committer though so someone else will have to look at this, and there might be an issue with the license, although I'm no expert: I see some files with a GPLv2 header, another with a LGPLv2 header, some with none. Also, it's good practice to include the fact that it's the second version of a patch by adding --reroll-count=2 (shortened -v 2) to git format/send-patch, and also adding the base commit you're using using --base=auto. Best, -- Josselin Poiret