From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id QEizI7BHQmRhaAAASxT56A (envelope-from ) for ; Fri, 21 Apr 2023 10:22:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id SAeNI7BHQmQARgEAauVa8A (envelope-from ) for ; Fri, 21 Apr 2023 10:22:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 308A21C23B for ; Fri, 21 Apr 2023 10:22:08 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppm1v-00035p-2p; Fri, 21 Apr 2023 04:22:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppm1r-00034U-Ff for guix-patches@gnu.org; Fri, 21 Apr 2023 04:22:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppm1r-0007ET-7W for guix-patches@gnu.org; Fri, 21 Apr 2023 04:22:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ppm1r-0000T0-1f for guix-patches@gnu.org; Fri, 21 Apr 2023 04:22:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62754] [PATCH v2] doc: Use G-Expressions for package definition example. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 Apr 2023 08:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62754 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 62754@debbugs.gnu.org, ivan-p-sokolov@ya.ru Received: via spool by 62754-submit@debbugs.gnu.org id=B62754.16820653211779 (code B ref 62754); Fri, 21 Apr 2023 08:22:02 +0000 Received: (at 62754) by debbugs.gnu.org; 21 Apr 2023 08:22:01 +0000 Received: from localhost ([127.0.0.1]:39231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppm1o-0000Sb-KM for submit@debbugs.gnu.org; Fri, 21 Apr 2023 04:22:00 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:41119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppm1m-0000SL-M0 for 62754@debbugs.gnu.org; Fri, 21 Apr 2023 04:21:59 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id B58B640004; Fri, 21 Apr 2023 08:21:51 +0000 (UTC) From: Nicolas Goaziou References: <2db67ea84f7a23bf04280ad1e365ac8709167d66.1681215490.git.mirai@makinata.eu> Date: Fri, 21 Apr 2023 10:21:50 +0200 In-Reply-To: <2db67ea84f7a23bf04280ad1e365ac8709167d66.1681215490.git.mirai@makinata.eu> (Bruno Victal's message of "Tue, 11 Apr 2023 13:19:15 +0100") Message-ID: <87edod63xd.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682065328; a=rsa-sha256; cv=none; b=aPsyveiaWpMdPlVNHB7z43gBHfdyUm0ldWrb6c56H21vEhZ5TeITSB+GXBZzuREPuBOBDq yaD7Y6CRVvlyOJo7M2FYvCd6drmEXe8uG89A93KHNs9N7aqEOPngqFwPO3fABruNg6avmQ K8mc5eu0MORcrVnrVbEKjxF8j6VKM9irhpFxbBeIsVt3kuT4pYceXJxNQRXY6T9+F51fPv iHWJakkLVER5Oi5+kPNQA6LfYVjyonW77rB9zVzBSw2AF62SQIz1CMIL72dflGK/4cp5Jx nrqPxv5AdR6QZs7NenmrIwUAfg49YeDB2Yvl2Sp1LgwGq0fACzN4jkJsp3SHng== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682065328; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=zdL+H0nQUQHP4OYBnZvTbjpr1fvTYR6BSGlnaAp6oFI=; b=m89Ezs+2sFo1WPu/l55RSYKzrA7uUzaUp7ihod455kDmiFDPqAnKcyOGLAWgyQDG2/hLbM M3sUaUjewuJ7LKSc7PLltt0/P3TXcDWHJJRRFCdgDutP/1ULTrbyD0g2USSRmK2ChKOBaM L1KACc5Jsd0vv4cFuHQLGgYMn+N24r8pTC/CNti5JzbD8S+/qmci0tCngZ03pWRZhwZFAn IoBz8/D6Hfm6nBnt/o3LGhA/1oYw1/FTUcxEEaRI+Kz5BaD5SMwUcnxJ0WYAdoXtMwKJgh otVjzNIZgxEsk/80szH6uKX3N1TmCMmFdERl8hMzRlLyd2Cb2bTCOOHP4+d1CQ== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.32 X-Spam-Score: -3.32 X-Migadu-Queue-Id: 308A21C23B X-TUID: Btn/bM9M04ef Hello, Bruno Victal writes: > + (list > + #:phases > + #~(modify-phases %standard-phases > + (delete 'configure) > + (add-before 'build 'set-prefix-in-makefile > + (lambda* (#:key inputs #:allow-other-keys) > + ;; Modify the makefile so that its > + ;; 'PREFIX' variable points to #$output and > + ;; 'XMLLINT' points to the correct path. > + (substitute* "Makefile" > + (("PREFIX =.*") > + (string-append "PREFIX = " #$output "\n")) > + (("XMLLINT =.*") > + (string-append "XMLLINT = " > + (search-input-file inputs "/bin/xmllint") > + "\n")))))))))) > @end lisp > > The new phase that is inserted is written as an anonymous procedure, > -introduced with @code{lambda*}; it honors the @code{outputs} parameter > -we have seen before. @xref{Build Utilities}, for more about the helpers > -used by this phase, and for more examples of @code{modify-phases}. > +introduced with @code{lambda*}. @xref{Build Utilities}, for more about > +the helpers used by this phase, and for more examples of > +@code{modify-phases}. I think it still makes sense to refer to `inputs'; it could be unsettling otherwise. Maybe something along those lines: ... introduced with @code{lambda*}; it looks for the @file{xmllint} executable in a @file{"/bin"} directory among package's inputs (@pxref{package Reference}). It also honors the @code{outputs} parameter we have seen before@xref{Build Utilities}, for more... WDYT? Regards, -- Nicolas Goaziou