From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AH5/EeDDUmRjLAEASxT56A (envelope-from ) for ; Wed, 03 May 2023 22:28:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8HtkEeDDUmTp1AAAauVa8A (envelope-from ) for ; Wed, 03 May 2023 22:28:16 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DB3E19EDE for ; Wed, 3 May 2023 22:28:15 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puJ52-0003Zx-MI; Wed, 03 May 2023 16:28:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puJ50-0003ZV-Ou for guix-patches@gnu.org; Wed, 03 May 2023 16:28:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puJ50-0007Gk-EM for guix-patches@gnu.org; Wed, 03 May 2023 16:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puJ4z-0002Pw-Nk for guix-patches@gnu.org; Wed, 03 May 2023 16:28:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62969] [PATCH v3] home: Add msmtp service. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 May 2023 20:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62969 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tanguy LE CARROUR Cc: 62969@debbugs.gnu.org, mirai@makinata.eu Received: via spool by 62969-submit@debbugs.gnu.org id=B62969.16831456369212 (code B ref 62969); Wed, 03 May 2023 20:28:01 +0000 Received: (at 62969) by debbugs.gnu.org; 3 May 2023 20:27:16 +0000 Received: from localhost ([127.0.0.1]:47833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puJ4F-0002OV-Jz for submit@debbugs.gnu.org; Wed, 03 May 2023 16:27:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puJ4C-0002OF-Bv for 62969@debbugs.gnu.org; Wed, 03 May 2023 16:27:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puJ46-00079d-H0; Wed, 03 May 2023 16:27:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=D9PUW3tER+OmvO+QIjBkHjhwh7YnSMFJ8/XLGCQ0LtM=; b=NPCu2yHkP4HB4yydXVS2 gL4StSYsuPTfpDqS2DvO7fHI2MoPHVDX8zxMNix4ife1mWYNJdAWEn+EJ1ANhVsXYePkhD3+PjhzT +/rrp/4KZ0GVaY2vfbRiaCT6YZPmma4+Q1uCNrdotQJVXxJ546JGNcRsd2DOsds5Q7v+5MP+iORZA M/L26F0qNh++eL/Fyj+aISmaVtaKmGjJcU+uoYP5wL92AHZiNo/z/5PsSEq8O6Tq5SuwYkVS0AbB4 qPkgjAUodoz/8JN2O7VUM5l2RoPqvcjSV7YKnsefAoic3fOEVlKl/IBavTIs3TGToI0Z6cRnXgqQf bWgrZY6cTdLnXw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puJ46-00045W-2v; Wed, 03 May 2023 16:27:06 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230420144230.9392-1-tanguy@bioneland.org> <20230423171217.14894-1-tanguy@bioneland.org> <87ilddnjml.fsf_-_@gnu.org> <168310810854.1650.852938763274164245@localhost> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 14 =?UTF-8?Q?Flor=C3=A9al?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du =?UTF-8?Q?Cham=C3=A9risier?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 03 May 2023 22:27:03 +0200 In-Reply-To: <168310810854.1650.852938763274164245@localhost> (Tanguy LE CARROUR's message of "Wed, 03 May 2023 12:01:48 +0200") Message-ID: <87ednxyxd4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683145695; a=rsa-sha256; cv=none; b=MnP7UWDtfiZw12jOGVMig2YSmAzod9Qhg01fRR+rjq/xK6ilribzY8/FgtSSI0w1Qw3MEp MoZKFGxRfemChh4muhlmCppsx242rsJZZ050CUAl9CUakNEXexZyHxHIHnUrfDwDMXN6Me aCpjbaTAPJ0Gwz/8N4L7+jJ1zaK+8oPESgNbtFsfkPXg9xdqD1QjVdZTZc6OjyJ8LC8Oda EYJqHupiEmvZAO26janJKE5tVsGAci/cZ3mxgxOlO6pSgefKn7MyLH46szlwNWztee8WY3 lC1vo4bG1+bdk2C6HZx4dHqa9E5MffnNT8IfZhQi8eA5RVPhMuF8A+/F2cr//w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=NPCu2yHk; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683145695; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=D9PUW3tER+OmvO+QIjBkHjhwh7YnSMFJ8/XLGCQ0LtM=; b=dzAiVJRQxZ3J3iKeJ880TBTqIr39yIqllGzZHpgRA+UjHm4FLQnPvc+zTA5s+D6sKOperi D6cywi0MEcXXZ3Fhyw4s9H+VZDzf7uMy+PKZmB9rJIhQ55z3DpzXvyqqz2g2xarkQ7U9JT wrgvdl+TiR2oJtyyILb/OGDewUrhal1nTMCdoT4tDbssb1d1aPl/RhOLS2EFUaHXttJ/x7 oKTle0y4WRBCEK6LX2Al6oc3NKEPAEBwGLhnldPIWHK4dfKZuC9FRlg9tsXE6JyeOpgicD BdkjS3IW9zJaLpuZ/km+1wh1t78WpBZAVG2OPz1uShCFII6wpXnm0sgbRiLTtw== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=NPCu2yHk; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.61 X-Spam-Score: -2.61 X-Migadu-Queue-Id: DB3E19EDE X-TUID: qIboYqHmUOz3 Hello! Tanguy LE CARROUR skribis: > Quoting Ludovic Court=C3=A8s (2023-04-30 23:30:10) >> Tanguy Le Carrour skribis: >>=20 >> > * gnu/home/services/mail.scm: New file. >> > * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. >> > * doc/guix.texi (Mailing): New node. >>=20 >> I get: >>=20 >> --8<---------------cut here---------------start------------->8--- >> [ 94%] GUILEC gnu/home/services/mail.go >> gnu/home/services/mail.scm:52:0: warning: possibly unbound variable `ser= ialize-string' >> gnu/home/services/mail.scm:53:0: warning: possibly unbound variable `ser= ialize-boolean' >> gnu/home/services/mail.scm:54:0: warning: possibly unbound variable `ser= ialize-integer' >> --8<---------------cut here---------------end--------------->8--- >> >> I guess these procedures should be provided as well? > > I also get them when making `gnu/home/services/mail.go`. But aren't > those "just" warnings. It means that there=E2=80=99s code referring to these procedures, and that = they don=E2=80=99t exist. It=E2=80=99s worth investigating anyway. > Everything seems to work as expected and when I `guix home container > test.home.scm` I get the expected `.config/msmtp/config` file. Perhaps that doesn=E2=80=99t exercise those bits, maybe because you=E2=80= =99re not using string-valued or boolean-valued fields or something? A couple of minor things: > * gnu/home/services/mail.scm: New file. > * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. > * doc/guix.texi (Mailing): New node. > +@subsection Mail Home Services > + > +The @code{(gnu home services mail)} modules provides services that help =E2=80=9Cmodule=E2=80=9D (singular) > +@uref{https://marlam.de/msmtp, MSMTP} is a @acronym{SMTP, Simple Mail > +Transfer Protocol} client. It sends mails to a predefined SMTP server =E2=80=9Cmail=E2=80=9D (singular) > +@code{~/.config/msmtp/config} file. =E2=80=9C@file=E2=80=9D This new intro + example look nice to me! > +@item @code{logfile} (type: maybe-string) [...] > +@item @code{passwordeval} (type: maybe-string) > +Set the password for authentication to the output (stdout) of the > +command cmd. Sorry for not noticing earlier but I=E2=80=99d suggest =E2=80=98log-file=E2= =80=99 and =E2=80=98password-evaluation=E2=80=99 (?) to stick with the established nam= ing convention. So I think beyond this the main issue is figuring out the missing serialization procedures, and then we=E2=80=99re done! Thanks, Ludo=E2=80=99.