* [bug#64083] [PATCH 0/2] gnu: ruby-nokogiri: Update to 1.15.2.
@ 2023-06-15 17:04 gemmaro
2023-06-15 17:08 ` [bug#64083] [PATCH 1/2] gnu: ruby-mini-portile-2: Update to 2.8.2 gemmaro
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: gemmaro @ 2023-06-15 17:04 UTC (permalink / raw)
To: 64083; +Cc: gemmaro, Christopher Baines
gemmaro (2):
gnu: ruby-mini-portile-2: Update to 2.8.2.
gnu: ruby-nokogiri: Update to 1.15.2.
gnu/packages/patches/ruby-nokogiri.patch | 29 ++++++++++++
gnu/packages/ruby.scm | 58 ++++++++++++++----------
2 files changed, 63 insertions(+), 24 deletions(-)
create mode 100644 gnu/packages/patches/ruby-nokogiri.patch
base-commit: 6e1215fb9c03ccb4a2d4440990aee5a66a935268
--
2.40.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#64083] [PATCH 1/2] gnu: ruby-mini-portile-2: Update to 2.8.2.
2023-06-15 17:04 [bug#64083] [PATCH 0/2] gnu: ruby-nokogiri: Update to 1.15.2 gemmaro
@ 2023-06-15 17:08 ` gemmaro
2023-06-15 17:08 ` [bug#64083] [PATCH 2/2] gnu: ruby-nokogiri: Update to 1.15.2 gemmaro
2023-06-24 14:29 ` bug#64083: [PATCH 0/2] " Ludovic Courtès
2 siblings, 0 replies; 4+ messages in thread
From: gemmaro @ 2023-06-15 17:08 UTC (permalink / raw)
To: 64083; +Cc: gemmaro, Christopher Baines
* gnu/packages/ruby.scm (ruby-mini-portile-2): Update to 2.8.2.
---
gnu/packages/ruby.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index f28ad97e111..9587c29a0ab 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -6243,13 +6243,13 @@ (define-public ruby-mini-portile
(define-public ruby-mini-portile-2
(package
(inherit ruby-mini-portile)
- (version "2.8.1")
+ (version "2.8.2")
(source (origin
(method url-fetch)
(uri (rubygems-uri "mini_portile2" version))
(sha256
(base32
- "1af4yarhbbx62f7qsmgg5fynrik0s36wjy3difkawy536xg343mp"))))))
+ "0z7f38iq37h376n9xbl4gajdrnwzq284c9v1py4imw3gri2d5cj6"))))))
(define-public ruby-nokogiri
(package
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#64083] [PATCH 2/2] gnu: ruby-nokogiri: Update to 1.15.2.
2023-06-15 17:04 [bug#64083] [PATCH 0/2] gnu: ruby-nokogiri: Update to 1.15.2 gemmaro
2023-06-15 17:08 ` [bug#64083] [PATCH 1/2] gnu: ruby-mini-portile-2: Update to 2.8.2 gemmaro
@ 2023-06-15 17:08 ` gemmaro
2023-06-24 14:29 ` bug#64083: [PATCH 0/2] " Ludovic Courtès
2 siblings, 0 replies; 4+ messages in thread
From: gemmaro @ 2023-06-15 17:08 UTC (permalink / raw)
To: 64083; +Cc: gemmaro, Christopher Baines
* gnu/packages/ruby.scm (ruby-nokogiri): Update to 1.15.2.
[source]<uri>: Use Git repository.
<patches>: apply a patch to disable unneeded test setups.
[arguments]: Enable check by running plain minitest.
[home-page]: Update to current URL.
---
gnu/packages/patches/ruby-nokogiri.patch | 29 +++++++++++++
gnu/packages/ruby.scm | 54 ++++++++++++++----------
2 files changed, 61 insertions(+), 22 deletions(-)
create mode 100644 gnu/packages/patches/ruby-nokogiri.patch
diff --git a/gnu/packages/patches/ruby-nokogiri.patch b/gnu/packages/patches/ruby-nokogiri.patch
new file mode 100644
index 00000000000..b55b4302344
--- /dev/null
+++ b/gnu/packages/patches/ruby-nokogiri.patch
@@ -0,0 +1,29 @@
+Description: Removed some unnecessary test setup such as SimpleCov and
+ minitest-reporters.
+diff --git a/test/helper.rb b/test/helper.rb
+index ed3133c6..4f5d4f1b 100644
+--- a/test/helper.rb
++++ b/test/helper.rb
+@@ -13,22 +13,10 @@
+ # - NOKOGIRI_GC: read more in test/test_memory_leak.rb
+ #
+
+-require "simplecov"
+-SimpleCov.start do
+- add_filter "/test/"
+- enable_coverage :branch
+-end
+-
+ $VERBOSE = true
+
+ require "minitest/autorun"
+ require "minitest/benchmark"
+-require "minitest/reporters"
+-
+-nokogiri_minitest_reporters_options = { color: true, slow_count: 10, detailed_skip: false }
+-nokogiri_minitest_reporters_options[:fast_fail] = true if ENV["NOKOGIRI_TEST_FAIL_FAST"]
+-puts "Minitest::Reporters options: #{nokogiri_minitest_reporters_options}"
+-Minitest::Reporters.use!(Minitest::Reporters::DefaultReporter.new(nokogiri_minitest_reporters_options))
+
+ require "fileutils"
+ require "tempfile"
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 9587c29a0ab..ae345bd5bfc 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -6254,38 +6254,48 @@ (define-public ruby-mini-portile-2
(define-public ruby-nokogiri
(package
(name "ruby-nokogiri")
- (version "1.13.10")
+ (version "1.15.2")
(source (origin
- (method url-fetch)
- (uri (rubygems-uri "nokogiri" version))
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/sparklemotion/nokogiri")
+ (commit "a6ad20b3edc8f020043ccfe5d9ec6ae9af103720")))
+ (file-name (git-file-name name version))
(sha256
(base32
- "0n79k78c5vdcyl0m3y3l5x9kxl6xf5lgriwi2vd665qmdkr01vnk"))))
+ "1n0vlg6v58jw3qzgyihz1dh5fvp4js1qgdh75j0kn47nvyiw3jxj"))
+ (patches (search-patches "ruby-nokogiri.patch"))))
(build-system ruby-build-system)
(arguments
- ;; Tests fail because Nokogiri can only test with an installed extension,
- ;; and also because many test framework dependencies are missing.
- (list
- #:tests? #f
- #:gem-flags #~(list "--" "--use-system-libraries"
- (string-append "--with-xml2-include="
- #$(this-package-input "libxml2")
- "/include/libxml2" ))
- #:phases
- #~(modify-phases %standard-phases
- (add-after 'install 'delete-mkmf.log
- (lambda _
- ;; Rubygems installs build log files that embed volatile file
- ;; names (see:
- ;; https://github.com/rubygems/rubygems/issues/6259).
- (for-each delete-file (find-files #$output "^mkmf\\.log$")))))))
- (native-inputs (list ruby-hoe))
+ (list #:gem-flags #~(list "--" "--use-system-libraries"
+ (string-append "--with-xml2-include="
+ #$(this-package-input "libxml2")
+ "/include/libxml2"))
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'install 'delete-mkmf.log
+ (lambda _
+ ;; Rubygems installs build log files that embed volatile file
+ ;; names (see:
+ ;; https://github.com/rubygems/rubygems/issues/6259).
+ (for-each delete-file
+ (find-files #$output "^mkmf\\.log$"))))
+ (delete 'check)
+ (add-after 'install 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (setenv "GEM_PATH" (string-append
+ (getenv "GEM_PATH") ":"
+ #$output "/lib/ruby/vendor_ruby"))
+ (when tests?
+ (for-each (lambda (file)
+ (invoke "ruby" "-Itest" file))
+ (find-files "test" "^test_.*\\.rb"))))))))
+ (native-inputs (list ruby-hoe ruby-rubyzip))
(inputs (list zlib libxml2 libxslt))
(propagated-inputs (list ruby-mini-portile-2 ruby-pkg-config))
(synopsis "HTML, XML, SAX, and Reader parser for Ruby")
(description "Nokogiri (鋸) parses and searches XML/HTML, and features
both CSS3 selector and XPath 1.0 support.")
- (home-page "https://www.nokogiri.org/")
+ (home-page "https://nokogiri.org/")
(license license:expat)))
(define-public ruby-method-source
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#64083: [PATCH 0/2] gnu: ruby-nokogiri: Update to 1.15.2.
2023-06-15 17:04 [bug#64083] [PATCH 0/2] gnu: ruby-nokogiri: Update to 1.15.2 gemmaro
2023-06-15 17:08 ` [bug#64083] [PATCH 1/2] gnu: ruby-mini-portile-2: Update to 2.8.2 gemmaro
2023-06-15 17:08 ` [bug#64083] [PATCH 2/2] gnu: ruby-nokogiri: Update to 1.15.2 gemmaro
@ 2023-06-24 14:29 ` Ludovic Courtès
2 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2023-06-24 14:29 UTC (permalink / raw)
To: gemmaro; +Cc: Christopher Baines, 64083-done
Hi,
gemmaro <gemmaro.dev@gmail.com> skribis:
> gnu: ruby-mini-portile-2: Update to 2.8.2.
> gnu: ruby-nokogiri: Update to 1.15.2.
It’s all green:
https://qa.guix.gnu.org/issue/64083
Applied, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-24 14:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-15 17:04 [bug#64083] [PATCH 0/2] gnu: ruby-nokogiri: Update to 1.15.2 gemmaro
2023-06-15 17:08 ` [bug#64083] [PATCH 1/2] gnu: ruby-mini-portile-2: Update to 2.8.2 gemmaro
2023-06-15 17:08 ` [bug#64083] [PATCH 2/2] gnu: ruby-nokogiri: Update to 1.15.2 gemmaro
2023-06-24 14:29 ` bug#64083: [PATCH 0/2] " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.