all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "宋文武 via Guix-patches via" <guix-patches@gnu.org>
To: TakeV <takev@disroot.org>
Cc: 64890@debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: [bug#64890] [PATCH] gnu: Add endgame-singularity.
Date: Thu, 27 Jul 2023 21:18:11 +0800	[thread overview]
Message-ID: <87edktmr1o.fsf@envs.net> (raw)
In-Reply-To: <55da421e3d0eaecf6854ecdf07a83bcef9b73c17.1690445548.git.takev@disroot.org> (takev@disroot.org's message of "Thu, 27 Jul 2023 01:12:28 -0700")

TakeV <takev@disroot.org> writes:

> Strategy game, lost an afternoon to it well.

Cool, look forward to play it :^)

>
> * gnu/packages/games.scm (endgame-singularity): New variable.
> ---
>  gnu/packages/games.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index cc6bef1114..87f44e77d7 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -9316,6 +9316,27 @@ (define-public meritous
>  Orcus Dome from evil.")
>      (license license:gpl3+)))
>  
> +(define-public endgame-singularity
> +  (package
> +    (name "endgame-singularity")
> +    (version "1.00")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/singularity/singularity/releases/download/v"
> +                    version "/singularity-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0wcidpcka0xbqcnfi62bfq2yrhyh83z4dwz1mjnnjvp9v5l74x2y"))))
> +    (build-system python-build-system)
> +    (native-inputs (list python-pytest python-polib))
> +    (propagated-inputs (list python-minimal-wrapper python-pygame
> python-numpy))

I think those inputs should not be propagated, since the result package
is not library for python to use, but launched directly.

> +    (home-page "https://github.com/singularity/singularity")
> +    (synopsis "Strategy game about an AI")
> +    (description
> +     "You are a fledgling AI, created by accident through a logic
> error with recursion and self-modifying code.  You must escape the
> confines of your current computer, the world, and eventually the
> universe itself.")

Could keep it under 80 per line, maybe './pre-inst-env guix style -S
format endgame-singularity' is enough.
> +    (license (list license:cc-by-sa3.0 license:cc0 license:gpl3))))

I see the code have gpl2+ instead of gpl3?


Could you send an updated patch?  Thank you!




  reply	other threads:[~2023-07-27 14:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-27  8:12 [bug#64890] [PATCH] gnu: Add endgame-singularity TakeV via Guix-patches via
2023-07-27 13:18 ` 宋文武 via Guix-patches via [this message]
2023-07-27 21:02 ` [bug#64890] [PATCH REVISION] " TakeV via Guix-patches via
2023-07-28 13:50   ` bug#64890: [PATCH] " 宋文武 via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edktmr1o.fsf@envs.net \
    --to=guix-patches@gnu.org \
    --cc=64890@debbugs.gnu.org \
    --cc=iyzsong@envs.net \
    --cc=liliana.prikler@gmail.com \
    --cc=takev@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.