From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id mEiSCs8OMGXVXgEA9RJhRA:P1 (envelope-from ) for ; Wed, 18 Oct 2023 18:58:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id mEiSCs8OMGXVXgEA9RJhRA (envelope-from ) for ; Wed, 18 Oct 2023 18:58:55 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EEEAC5AA8D for ; Wed, 18 Oct 2023 18:58:54 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=HK3Awlx6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697648335; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=HAXhFIMPPfzyz3MkoIa+KGmRVakrG/Bcy91RL4tGsGs=; b=AJIiwADavhrukY7eBsMT/B8NI2qB8vRrxsXuJClzOrajOmZ2IN0NKf/M3yR5mCKrWoxdmq +JvdD8tm5xYJgbuyJQNoxUObAhjTkSu1PnbOoXU/xsk7NMPs0m7R8byISg2uCQpqikbVLn Vi3yXEeF/yP/LO4Lu9NDvffZrU61ahWmB3eICq2dkj6+VV5S1spTeRyhxR8qc04xnM5sqW tLiruyeDdcd1q5fKOBkm6YxH6sxKvwEC/eei15NYOVhrx1DDPpd3rfuHM0Y28PLb+p7yCU 4JLk5yR3+aafGeEhEnXaF2ln4+DDCLKplKtNOTtit+IUBgwX1qGNUO2Q/T//ig== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=HK3Awlx6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697648335; a=rsa-sha256; cv=none; b=YQgcwjWXnr8v+oUlRE/2pk6tEj6yWhH7s6uhPpkZyuZYnng5D1/YV65gU3yWGsjw0x5AV0 UOylAzqhXXugnqV8yk4k6mwQ25p8NNse763zqjNI6E2QZL7uObS3lWURlor9htNIIu4QE0 lIT7Zqoo6cSgIU4cEFCzLqn7kSKQispmMHt0HewM37kf6WDHHAkoBiJECQZrHBRtBllo3L xAg5anwCYsIkeHeKmisMOZcbbKGjtZBBN7LitOzY/nYurs25TZRG+/tzsflnXQax5bPMMG Jx7TiMVToESO7n3MWqo6lfMhZUH1Ffc52sss5cpVhVdUQc3oeHAUj38/ivz4HA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qt9sT-0003KX-U5; Wed, 18 Oct 2023 12:58:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qt9sS-0003KG-86 for guix-patches@gnu.org; Wed, 18 Oct 2023 12:58:36 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qt9sS-0002cC-00 for guix-patches@gnu.org; Wed, 18 Oct 2023 12:58:36 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qt9sr-0001h6-O2 for guix-patches@gnu.org; Wed, 18 Oct 2023 12:59:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66576] Request for merging "rust-team" branch Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 18 Oct 2023 16:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66576 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Efraim Flashner Cc: 66576@debbugs.gnu.org, 66553-done@debbugs.gnu.org Received: via spool by 66576-submit@debbugs.gnu.org id=B66576.16976482966427 (code B ref 66576); Wed, 18 Oct 2023 16:59:01 +0000 Received: (at 66576) by debbugs.gnu.org; 18 Oct 2023 16:58:16 +0000 Received: from localhost ([127.0.0.1]:34569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qt9s8-0001fZ-4X for submit@debbugs.gnu.org; Wed, 18 Oct 2023 12:58:16 -0400 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]:47188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qt9s3-0001fB-0x; Wed, 18 Oct 2023 12:58:14 -0400 Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-d865854ef96so7998263276.2; Wed, 18 Oct 2023 09:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697648259; x=1698253059; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=HAXhFIMPPfzyz3MkoIa+KGmRVakrG/Bcy91RL4tGsGs=; b=HK3Awlx66GbSfHQw87URD5k4VRec9GofQU/meacpur7gM6B2m3IJue8jVOfoB8+/Nv bravHHSd+Rcp1cHTuC2Yh7LTwZBjp9G+eLmJaz134x2N/bZbmx0LqkxM9Mx76mFNZ4r/ h4+jhVC8rvF0XluYTteSemYaFC5Sgk+dkCykH8ZC1RwCrCwOmrsFLxQYEm8kv1pNmERk xvKEydob2u0pEdIeqRaM5sElq97Dy3mHWcG7hXr6fsuyAp3vRjGeFPFQQri1swsIM5j+ j762BU2IbNQK2TJJoN+8hBGyV8MPw3Gk9MBjFHvrnKOyj0aZytPaUrqN5ofIEqL15mZ+ X/ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697648259; x=1698253059; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HAXhFIMPPfzyz3MkoIa+KGmRVakrG/Bcy91RL4tGsGs=; b=iP5+Y1ajx4+V+2E30xgrW+EG/FEqGtpBHcPjf3+FEm36DoHnekLiJ3lSj7MsF04toS e2bwBwGGUmNeLLIQyE2NgamtlnnwSC+SK8WhyGSyHxvdh1l2xZ9kh91iFlZ2OMvqnRgw egFp7dJe/xKn50GXdNKYftwNFCKhzv6uNToF7L6pSjNFylbrfblTsNNZPSHk1Ah+f8RJ CmVxGpo3lWg0W4+zWDL1qz7qSJJ/Rw2yZmayLVDABgZnpNXNOCyt0phEECkTO7O9o6Tk CLmAn9Ium+MXh5gmB1dVFG77LtxEDph9V3GRM61ByFipuPTKd8ym0K4W0+EO9K7B5ZiK LHAQ== X-Gm-Message-State: AOJu0YySqxAukLJR1ONJGAsOnu6yhwrTbr+GH8m9/QiLh39uOpfhFOkB KmdKsfqIeALqQg1Sef/0ZmhQbRfGrcc= X-Google-Smtp-Source: AGHT+IFOwfm19mPZ/9oHAgYIpD585ClHZDaD1C2qNr/TD1/wjxr4f5/Kbn2aFd+MBBS15Schw1Z6bQ== X-Received: by 2002:a25:ae43:0:b0:d9a:bd07:cb7d with SMTP id g3-20020a25ae43000000b00d9abd07cb7dmr5766812ybe.45.1697648259148; Wed, 18 Oct 2023 09:57:39 -0700 (PDT) Received: from hurd (dsl-155-177.b2b2c.ca. [66.158.155.177]) by smtp.gmail.com with ESMTPSA id u11-20020a05621411ab00b0065b1bcd0d33sm87833qvv.93.2023.10.18.09.57.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 09:57:38 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: (Efraim Flashner's message of "Wed, 18 Oct 2023 11:36:41 +0300") References: <4D6214A4-E59F-4166-B4D0-2CCCE42F5DB4@flashner.co.il> <87y1g1tfxk.fsf@gmail.com> Date: Wed, 18 Oct 2023 12:57:37 -0400 Message-ID: <87edhruav2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 2.87 X-Spam-Score: 2.87 X-Migadu-Queue-Id: EEEAC5AA8D X-Migadu-Scanner: mx2.migadu.com X-TUID: TUcUjHorsRjq Hi Efraim, Efraim Flashner writes: > On Tue, Oct 17, 2023 at 11:41:11AM -0400, Maxim Cournoyer wrote: >> Hi Efraim, >> >> Efraim Flashner writes: >> >> > IMO rust-team branch is ready to merge. We've updated rust to 1.70, >> > librsvg to 2.56.4 and many new and updated packages. We've added a phase >> > to the cargo-build-system to fail if it detects pre-built files and >> > we've set the cargo-build-system to skip the test phase by default, >> > allowing us to make sure that the packages have the correct inputs. With >> > these changes I've gotten 100% of the packages built using the >> > cargo-build-system to build successfully. >> >> This sounds good except I don't understand how disabling the tests by >> default help to "make sure that the packages have the correct inputs" ? >> >> You've explained the rationale here: >> , >> saying we sometimes use a newer Rust than the package tests are >> expecting; how does it work in the Rust world? Don't they always build >> even older versions against the most recent compiler? What about the >> test suites then? Are these not typically run by users/distributions? > > I've copied your questions to the thread above and answered them there > so we can keep the discussion in one place. OK! >> For one thing the 'guix lint' command would need to be told that >> cargo-build-system has #:tests? set to #f by default to not warn without >> reasons that '#:tests? #t' is unnecessary. > > I've reverted it for now so we can get the rust-team branch merged and > continue discussing if this is a good idea or not. OK, thanks for giving it some extra time. -- Thanks, Maxim