From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id ELpzCCaDNmV3+gAA9RJhRA:P1 (envelope-from ) for ; Mon, 23 Oct 2023 16:28:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id ELpzCCaDNmV3+gAA9RJhRA (envelope-from ) for ; Mon, 23 Oct 2023 16:28:54 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B1EDD59238 for ; Mon, 23 Oct 2023 16:28:53 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=IdaFTs7w; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698071334; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Ha8bT+bTC/6qDxdNEMx/vPqx5MqjiZnCPUK9OkOxm9A=; b=KsqJMxDZrykg09toj4kF5eOJehBLSVPVABWDOOG9IgXUv5yP0z7ZLxZkbn582bZth13CKL c/5vouEGnjHxj3QegOnINZmk3qjNed6wAodPzzUwXnr38sSadnuf325dXWKxWVK3uDfUyK i2Sm+O0LyrCmhb0w/d0G4cGw0yvZ563z5+1jtiIpEX1Oxvz4Jcn/7h9yHo1ffs8IA/3tR7 qqbvp4aj3P3yvTuFLUflXqk7eRhADBzaQXDpF8wsa5W0aq7FcrrUxkwXPbX5dzyGzayQh7 8+xM1c+jxn4VSePIUZfl6mGAnmsyH52gUYkidCjVWvK+4aeTq8/typAb1JITJg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=IdaFTs7w; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698071334; a=rsa-sha256; cv=none; b=dIzkkp0mImPJtpmyJ04JB3PkiJB//J2NsvqjgHrWKrqY5wTMQMzN84e/H3zu5luwdxgrFs IjKmDt/bOD52ntUV1/VmY+YF5DntUn0dgeBWN0K1AUC284JjyPNw2+FFGRBdT6Tmb99spw H14ebYW4NId3DPplCaT4wfOlf4N8dfJ4+THVPZemhMEGPU0kXORlTbBdlWd6SijRzXDqtk 7E14synP4+t4CBLBgdEwBytEHEIsyTAG76zfrTc4voY9+mAsaefIhktAGHAaDMizOYiRM+ 0igviWRIZ3a5kzn0k/doXU9MKIY4TFK8kKqNU1aWyZ/CgROXfkrltc+Qus9d3A== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1quvv2-0005uO-7S; Mon, 23 Oct 2023 10:28:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quvuz-0005p8-Rd for guix-patches@gnu.org; Mon, 23 Oct 2023 10:28:33 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quvuz-0002uG-Jn for guix-patches@gnu.org; Mon, 23 Oct 2023 10:28:33 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1quvvS-0002uM-70 for guix-patches@gnu.org; Mon, 23 Oct 2023 10:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66618] [PATCH] etc: gitconfig: Remove the default email address to avoid mistakes. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Oct 2023 14:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66618 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: Simon Tournier Cc: 66618@debbugs.gnu.org, =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Received: via spool by 66618-submit@debbugs.gnu.org id=B66618.169807132611152 (code B ref 66618); Mon, 23 Oct 2023 14:29:02 +0000 Received: (at 66618) by debbugs.gnu.org; 23 Oct 2023 14:28:46 +0000 Received: from localhost ([127.0.0.1]:51280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quvvC-0002tn-0N for submit@debbugs.gnu.org; Mon, 23 Oct 2023 10:28:46 -0400 Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d]:58722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quvv9-0002tZ-69 for 66618@debbugs.gnu.org; Mon, 23 Oct 2023 10:28:44 -0400 Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-7781b176131so170614085a.1 for <66618@debbugs.gnu.org>; Mon, 23 Oct 2023 07:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698071288; x=1698676088; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ha8bT+bTC/6qDxdNEMx/vPqx5MqjiZnCPUK9OkOxm9A=; b=IdaFTs7wSOR2XiY7ptKFULZEAxLj8kiU9iNl31ysTRhlgEqksrnjnP0thRSKuF19uz h3RT03B8pj0iGSkcMTdj9i9TXpVjBVkcpCm10bm5t0VN8TH1UQLVORLcnbteRdSppwN7 uaX2UztYL8b/rXHQR+kGZ12BaxFIWsaKT/W7j8PuwNMo99yhl9lKJfhnr1pEF8LovZjY 7NuZ3leddDD4nKy39NHq3Q2XAwa29TeHY0rELwgtV/ZEc1gxlrk9Nl/W+rnT6mR15IL1 +AdR7bEvDWioK7v/6Nz8MM72uT3kVWBtj+AEkBIXlkKuIK6srZKp60egBS6HGwgcdKOo R+jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698071288; x=1698676088; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ha8bT+bTC/6qDxdNEMx/vPqx5MqjiZnCPUK9OkOxm9A=; b=bRabsLDk4Ej/AlyTgoe6VAgCMU6YWG+l6GHe2PuETYWDhl8NIIrzwq/kJ4RGeznroh beVeqL7SJ8W53xpo4+jyQDC5YOALgRA3cYlfX0rJtOOJvSQuknF/rQdqeAM/1LZiwuW/ AfZLkAEYE9Z6FOz7uIo9D4jtsHGOFdMHwQwAhZkLpOX8P1TV8wn2yNKSUnpIu37Wqn91 UX7pXi+gKqANZ0Fe9ji2Bo+bcRenGcgGQvFmM9VeYQckmDApilyYtSCVwHmAvz5/4mSs chFI8G6kYFlsGXv3T1NxAfaKbar9JcWslEJ4Fn2X9it+DvmjsS9+4K4bCR2m6gXlBb1Z LxPw== X-Gm-Message-State: AOJu0YyNfU5RjACxXBTPY+8GTPkJXfi2KMvIDmCx9qo6KWRsJ3/2HgBX xIpFdtn0FGSDNH9E9Jn5vt4= X-Google-Smtp-Source: AGHT+IHVdFUXI9OSNKkD2BChGAO+LEJ6eN04Lynga2Hq/WWOik4DXEnFcwAO1Jp2JN361c93FG84Qg== X-Received: by 2002:a05:620a:258e:b0:775:92bb:eb25 with SMTP id x14-20020a05620a258e00b0077592bbeb25mr9351516qko.55.1698071287885; Mon, 23 Oct 2023 07:28:07 -0700 (PDT) Received: from hurd (dsl-10-148-194.b2b2c.ca. [72.10.148.194]) by smtp.gmail.com with ESMTPSA id d20-20020a05620a241400b007759a81d88esm2715715qkn.50.2023.10.23.07.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 07:28:07 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87ttqhllcs.fsf@gmail.com> (Simon Tournier's message of "Mon, 23 Oct 2023 11:49:23 +0200") References: <87pm1bqtp1.fsf@gmail.com> <87zg0em529.fsf@gmail.com> <87cyx9mlq4.fsf@gmail.com> <87y1fxguxk.fsf@gmail.com> <87ttqhllcs.fsf@gmail.com> Date: Mon, 23 Oct 2023 10:28:06 -0400 Message-ID: <87edhl8lc9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 2.90 X-Spam-Score: 2.90 X-Migadu-Queue-Id: B1EDD59238 X-Migadu-Scanner: mx2.migadu.com X-TUID: 3ilGSTlb9GZn Hi Simon, Simon Tournier writes: > Hi Maxim, > > On Fri, 20 Oct 2023 at 11:44, Maxim Cournoyer = wrote: > >>> Here, the default >>> >>> [sendemail] >>> to =3D guix-patches@gnu.org >>> >>> makes something implicit =E2=80=93 which is not necessary bad =E2=80=93= but it hides >>> potential errors =E2=80=93 which is not good. >> >> But that's true for any automation of git. > > I disagree. The aim of automation is to hide burden without being > error-prone. > > >> If we follow that logic we >> can remove the other git configurations because they may be surprising, > > The point is about being able to catch and adjust accordingly. Except > this =E2=80=99sendemail.to=E2=80=99 value, all the other values may be su= rprising but if > one is surprised, then one is aware of the non-default Git configuration > and thus one is able to adjust accordingly. The same hold for send-email.to. You may get surprised once, and then you know it. The 'git send-email' command will prompt before sending the email with something like: --8<---------------cut here---------------start------------->8--- $ git send-email -1 ;;; note: source file /home/maxim/src/guix/etc/teams.scm ;;; newer than compiled /home/maxim/.cache/guile/ccache/3.0-LE-8-4.6/= home/maxim/src/guix/etc/teams.scm.go /tmp/YXDTZOc_v8/0001-wip-lfs.patch ;;; note: source file /home/maxim/src/guix/etc/teams.scm ;;; newer than compiled /home/maxim/.cache/guile/ccache/3.0-LE-8-4.6/= home/maxim/src/guix/etc/teams.scm.go (mbox) Adding cc: Maxim Cournoyer from line 'Fr= om: Maxim Cournoyer ' From: [...] To: guix-patches@gnu.org Cc: [...] Subject: [PATCH] wip lfs Date: Mon, 23 Oct 2023 10:11:24 -0400 Message-ID: <88ec0c8ccd84fe5e746c66259b8a41d25022f2f0.1698070284.git.maxim.= cournoyer@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: [...] Content-Type: text/plain; charset=3Dutf-8 Content-Transfer-Encoding: 8bit The Cc list above has been expanded by additional addresses found in the patch commit message. By default send-email prompts before sending whenever this occurs. This behavior is controlled by the sendemail.confirm configuration setting. For additional information, run 'git send-email --help'. To retain the current behavior, but squelch this message, run 'git config --global sendemail.confirm auto'. Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll):=20 --8<---------------cut here---------------end--------------->8--- The 'To: ' field is visible in this summary before confirming whether the email should be sent. [...] > I disagree. For example, I think =E2=80=99sendemail.headerCmd=E2=80=99 i= s a good > default. Because it hides the burden and correct my potential mistake. > > Well, somehow there is =E2=80=9Cgood=E2=80=9D surprise and =E2=80=9Cbad= =E2=80=9D surprise. For me, > =E2=80=99sendemail.to=E2=80=99 leads to =E2=80=9Cbad=E2=80=9D surprise an= d =E2=80=99sendemail.headerCmd=E2=80=99 leads > to =E2=80=9Cgood=E2=80=9D surprise. > > For me, =E2=80=99sendemail.headerCmd=E2=80=99 helps because it behaves in= a way that > most users will expect the system to behave. That=E2=80=99s POLA. Howev= er, > =E2=80=99sendemail.to=E2=80=99 does not appear to me POLA because it hide= s my potential > mistake. That's subjective unfortunately; at least two committers were originally surprised by the then new 'sendemail.headerCmd' behavior. >> The small cost in surprise is >> offset by removing manual work for myself and I'd expect/hope other >> committers. > > Well, from my point of view, it is possible to use other means for > removing some manual work. For instance, it is possible to have an > alias in etc/gitconfig, as =E2=80=9Cgit send-patches=E2=80=9D. Or it is = possible to use > =E2=80=99sendemail.aliasesFile=E2=80=99 for having a short key to pass. = Or else. > > You said: > > OK! I'll leave this opened for a bit longer to allow for others = to tip > in, after which I'll do so. > > and now you have two opinions by two Guix committers :-) =E2=80=93 not > git-send-email experts though but having some habits for using it. ;-) > > That=E2=80=99s said, I do not have a strong opinion either. I can live w= ith the > default value since I always explicitly uses =E2=80=99--to=3D=E2=80=99. := -) And if this > default value suits your productivity, it is totally fine with me. It does! I don't see how forcing everyone to explicitly type --to=3Dguix-patches@debbugs.gnu.org for sending simple patches or cover letters helps our flow. Mistakes will happen, but that's human, and we can merge or close the issue on Debbugs when they occur, without loosing any sleep :-) --=20 Thanks, Maxim