From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 0E0ABXpiSmUqJQEAauVa8A:P1 (envelope-from ) for ; Tue, 07 Nov 2023 17:14:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 0E0ABXpiSmUqJQEAauVa8A (envelope-from ) for ; Tue, 07 Nov 2023 17:14:50 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C71B66228B for ; Tue, 7 Nov 2023 17:14:49 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="V2Cj/g22"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1699373689; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=n7WfCSnPCJJAn7+FAnytuH2RHmKjdS9O5M6gr/uFpww=; b=QpTgP1DSOF4rp++FynsRadTm7iOuCbqSAoG18kZAUSC0r7bNHeLOXczrP+cPMrayfhMkig d9Kjq0HDLRM5Gnw4zGcz/3p2UO4touRiR4TAC8ixcE0IgubFUhErNMQUO/As3gUFMb9TcJ DQhLtMHyKujr6X3ed+licCL7jb3nRJbbbPbooQ1gkwYCSGRb/OdyhpgZ6YG0gtl7QicrIF QhuzfSC0oSHdUoVjQ71GSJgXsJqK/qbRJEHLj1EvG/BK+z+2qSK45Kl5q5uP0j4IbWCGDy O0+T6dxAEZUfPVRAsus20mxjeZfsvxpC8cJfL80OOHiYLymVbFaC6x9oN10KPw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="V2Cj/g22"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1699373689; a=rsa-sha256; cv=none; b=VZS2yvjYvxcbR/suALKg44WCZtpg2y4pIDzDdC6jt7AUR025rNFviVIq6wTC11F3Mhk2ys b3YY/2bLZTfy/S4w3Hn5cleTLllTL9ZrdMsZESQBYWbmu6/TYUWWWckLK574Mb+U/WyfB0 8MIcKMvFAvpETs5p508qNbJ78s5C5ZyBC4Aq4CwZGJrxBQPkjTwbtUIsD6Z+bKex0FvXkc S134f8IrVrHO3l0S9HQeq9caBuA3i3BU94pCsdLYUgVxt+XZMx0bMSObYUzb7BQ9Qrc3ds 0b9jRgWIethrMKcDUJa0LC7i/HXZ+MUirYX1ZBiHCrfsOBZXBffTotQaLWuqHQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0Oig-0007R3-I0; Tue, 07 Nov 2023 11:14:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0Oie-0007Qj-DB for guix-patches@gnu.org; Tue, 07 Nov 2023 11:14:24 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0Oie-0004lc-4q for guix-patches@gnu.org; Tue, 07 Nov 2023 11:14:24 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r0OjF-0003KQ-VK for guix-patches@gnu.org; Tue, 07 Nov 2023 11:15:01 -0500 Subject: bug#66436: [PATCH v3] doc: Add some guidelines for reviewing. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 07 Nov 2023 16:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 66436-done@debbugs.gnu.org, dev@jpoiret.xyz, zimon.toutoune@gmail.com Mail-Followup-To: 66436@debbugs.gnu.org, maxim.cournoyer@gmail.com, maxim.cournoyer@gmail.com Received: via spool by 66436-done@debbugs.gnu.org id=D66436.169937368812747 (code D ref 66436); Tue, 07 Nov 2023 16:15:01 +0000 Received: (at 66436-done) by debbugs.gnu.org; 7 Nov 2023 16:14:48 +0000 Received: from localhost ([127.0.0.1]:43071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0Oj1-0003JX-Hn for submit@debbugs.gnu.org; Tue, 07 Nov 2023 11:14:47 -0500 Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]:51650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0Oiz-0003JI-DY for 66436-done@debbugs.gnu.org; Tue, 07 Nov 2023 11:14:46 -0500 Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-67131800219so40002776d6.3 for <66436-done@debbugs.gnu.org>; Tue, 07 Nov 2023 08:14:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699373642; x=1699978442; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n7WfCSnPCJJAn7+FAnytuH2RHmKjdS9O5M6gr/uFpww=; b=V2Cj/g22AiVQllEj6nBCbdGAkCrh2JQ8+seNNQOlmHj5O1wDlwJcXYCXjy/xRyMTik Z5DO0RYiCYOjT3crQ6dABlwIJbmFe9KVsTIgfAQ6o9mY2XQ/vV+hnsdNFqcej7wKq94S ZC7Wx+1PslJL3HcjO8eG/G1lu5/ANtq2CM+ZPIy8cWSi5bvI/E8bnUR+J+/M7OHyVA7N jGZD/CMrORfSFqdEk6RT3uVhPx2HQtK5NGcDOjZQIa3SJrvqsJAhX5zNQtgaIcLeeSC9 CQAKA6qbsfl0dDAaKIk4U7SQ6GphG9rR5pCInvyPGISgg/czToz4UR6f9is81zMzhebx oywg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699373642; x=1699978442; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=n7WfCSnPCJJAn7+FAnytuH2RHmKjdS9O5M6gr/uFpww=; b=mNybAABlpOIkHmUCqggpO5luhpWgtaj9Uc+h2OQLbkkPQol6lH76g8gXYNWQLyfgfY lzmEO9R6mex1Hkp1uepj6Un4ib7ZwU/NVTGutEtscOsR58Na3BAwRIs8WNN0xHt/I6Wb CSbKPF0jUsjEflqVuMs4pbyNzmD0Y3oVhgd12CZLN9Xc2oC4Wy3LbnG+XU264AWOI0yD ozxuvT7qejL7q62VR5gctzKQULnCYCdB1fQ5FJVtJnsOsyJ4ZAkvhNAq53AxOTgVKED6 wl0E2dH1xcDcYMOQYNJRCXVRiF7FxJI9cqQwa79E9QQ+XoJEWGmd91YRpMOCDtt80Tc8 2s+Q== X-Gm-Message-State: AOJu0Yxi+cc/W7m3eL5SEFlMmC57o7KdHFgqMDf8KAfjsX+3d1bZ5UgR jr2UH9t1VObN9o55VZioik8= X-Google-Smtp-Source: AGHT+IGCWGY81QJrmEPxoF2f1BEFaoME9BOasqYxh8yo0pRJe0Xe03iWMr+M0a0xbJtzUoPxaKytJQ== X-Received: by 2002:a05:6214:2464:b0:65b:a66:3109 with SMTP id im4-20020a056214246400b0065b0a663109mr41025798qvb.8.1699373641786; Tue, 07 Nov 2023 08:14:01 -0800 (PST) Received: from hurd (dsl-10-130-87.b2b2c.ca. [72.10.130.87]) by smtp.gmail.com with ESMTPSA id q10-20020a0cfa0a000000b0065d05c8bb5dsm26360qvn.64.2023.11.07.08.14.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 08:14:01 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <87fs1k1cej.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 05 Nov 2023 15:51:32 +0100") References: <87fs1k1cej.fsf@gnu.org> Date: Tue, 07 Nov 2023 11:14:00 -0500 Message-ID: <87edh1k0c7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 4.39 X-Spam-Score: 4.39 X-Migadu-Queue-Id: C71B66228B X-Migadu-Scanner: mx10.migadu.com X-TUID: FT+R/gh0SMXc Hello, Ludovic Court=C3=A8s writes: > Hello, > > Maxim Cournoyer skribis: > >> * doc/contributing.texi (Contributing) [Reviewing the Work of Others]: N= ew >> section. >> (Debbugs Usertags): Expound with Emacs Debbugs information and document = the >> 'reviewed-looks-good' usertag. >> >> Change-Id: I56630b15ec4fbc5c67e5420dbf2838556a005d6b >> --- >> >> Changes in v3: >> - Replace LGTM with Reviewed-by Git tag >> - Add b4 config >> - Link to the Submitting Patches section for check list >> - Fuse further suggestions by both Ludovic and Simon > > Could you mention the b4 change in the commit log? Otherwise LGTM! Done, thanks for the review. >> +[b4] >> + attestation-check-dkim =3D off >> + attestation-policy =3D off >> + linkmask =3D https://yhetil.org/guix/%s >> + linktrailermask =3D https://yhetil.org/guix/%s >> + midmask =3D https://yhetil.org/guix/%s > > Really cool to have the b4 workflow documented and a default config in > place! Now we could document more extensively some successful workflows in the Cookbook (Debbugs/Gnus-based, QA-based, b4-based, etc.) :-). --=20 Thanks, Maxim