From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 4AqUEjD012V8AwEA62LTzQ:P1 (envelope-from ) for ; Fri, 23 Feb 2024 02:26:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 4AqUEjD012V8AwEA62LTzQ (envelope-from ) for ; Fri, 23 Feb 2024 02:26:08 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=d9c8sVyN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708651568; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=unRv5b0l9sL98H1bbtelU3lQibqt1XN63eTPjfQM0Co=; b=d8LmgWPlbUOkSwpd66XV8BjHXpuJerkkWdbvS39lGgXmdF22H2kdUnQSDbC4eBLFSuALms J0pF5b13vGgzb3AyyqveBIV7FzDxEPeUMucQDGVDOeKT6OqDGuyTy112cca8GlBHDUZNrE N7MGAyhA7iMzYjIQrKIxEobaaftlIzYGP0cO/SQJUPKFe93N6wALspkdtGlouzM+gxME+z L1VodbkV1AQO0QXlJzyY/un3C0ItLU0jliWQMuGBZa+KxGVt4eIOb3xNih0CkwTqxoSqZg wO4V/dmb5KI2l7iU98rWy6NaWrrr/l9MAXKvbV5leYiyUuUPIYsUYSB1cZwS+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=d9c8sVyN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708651568; a=rsa-sha256; cv=none; b=NAriIAIbG6YvpvLp/X/8f0WcmZpjqvbi83VxXtIj+8SinKMQq0stjrU5OFYpm4/JmKKon0 CUT13rVNGeyRPeaUajFxdfQuuuIICSrrlVgNVOd/CSfphqalziGT/31PFiZGCIh2XC7ily un2tE7ShVpee08E25ZloEK6VuBQ7vZmS7snRDqlshBcWXbsXS3XEJEHR5CYVAsSUOYlTkI Oa5IkpvjfIbYqmau8ib1GAPWyVxoaunJPKuEOIZm6Gm2pd+MZc3tHfqeXFCBF3NN9SoNJ0 qvb9gsINnaHp6AzcV7y0t7sK6+a20sZxCsZrWEcIZ47sE5d0VmhLjMD9zWpB3Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CF48B787D3 for ; Fri, 23 Feb 2024 02:26:07 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdKJp-0007be-Ha; Thu, 22 Feb 2024 20:25:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdKJn-0007b0-OF for guix-patches@gnu.org; Thu, 22 Feb 2024 20:25:39 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdKJm-00086k-UK for guix-patches@gnu.org; Thu, 22 Feb 2024 20:25:39 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdKKA-0000hE-2O for guix-patches@gnu.org; Thu, 22 Feb 2024 20:26:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68946] [PATCH v2] guix: Add logging module. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Feb 2024 01:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68946 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 68946@debbugs.gnu.org, Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Josselin Poiret , Ricardo Wurmus , Christopher Baines Received: via spool by 68946-submit@debbugs.gnu.org id=B68946.17086515172546 (code B ref 68946); Fri, 23 Feb 2024 01:26:02 +0000 Received: (at 68946) by debbugs.gnu.org; 23 Feb 2024 01:25:17 +0000 Received: from localhost ([127.0.0.1]:48945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdKJQ-0000ez-Sw for submit@debbugs.gnu.org; Thu, 22 Feb 2024 20:25:17 -0500 Received: from mail-qv1-f41.google.com ([209.85.219.41]:55428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdK9Z-0000CY-Qj for 68946@debbugs.gnu.org; Thu, 22 Feb 2024 20:15:06 -0500 Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-68f78705798so2167266d6.2 for <68946@debbugs.gnu.org>; Thu, 22 Feb 2024 17:14:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708650817; x=1709255617; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=unRv5b0l9sL98H1bbtelU3lQibqt1XN63eTPjfQM0Co=; b=d9c8sVyN/muWspL60czRTEksS26Hou0Isnk8uMS8oeJfUuOcSyuU9A1Zu8mwNH1NNW sZLhc4oVNmw3Et0XMBctXRty3RNSzFNf3K6qKi7BFXasqLTPNRs6d3BNqmhV8mYz/vuF VIOXDk+jmDekoeBz4zLvl0EbnQWTUgT0AfH3JUDX8tISk/vbEk1FBIiKbrWr09ZMlGFg kkbNr5rurXQIi9cA9FaUqqPIhF9Af0fLaI5pYpjqD2jAVD6ji3c3YKv8KNMq0SLXGjfv V9VK7r42tCzmIOsOM76RDr3expE87EzSTT+6pMT8mVjmx/W4OFwyl22hb2RWeVQPjyU3 UCCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708650817; x=1709255617; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=unRv5b0l9sL98H1bbtelU3lQibqt1XN63eTPjfQM0Co=; b=NpY+GFQrhWhr5jOGFDF6U05MBTTrnbBOJ8PJZoJlxgwt8jAPHUbNVKbs+lZtIO1+uD NjtV00KB+CFX4TQj2RSaIUjfDTO3HXR4TQkb5twagpOPgUjQzAjfctASbRMlmnr8dRyq Ggxr6OmS3GYPFASMOELIXMBJ7fgVA91dRgXCUeBzfUzQlOeSxY/Jpi4GSKMH/COa1c+D AyLYPh30+RwMfvtJSERTvqauJLkT//hW+0x8uCosRs9PsvLSVSzKiOJc73EBVPFVMCDL koglV8OQ7pQic3xRTCAK353u++kWYpMyORgdACSydpt1eYZP3H1msc6XS7SfBKyXeumO JeYw== X-Gm-Message-State: AOJu0YwPO+CJ91r43BoEiBzEhYQh+qwW4hMtDvFVGFhm3AwVtZk+LgsR HN4ZKiXMC5xx+bPc0YVndwrCwDBMxSKVqt2ajvQVpUqGRfMMcjBg X-Google-Smtp-Source: AGHT+IFTG+L83IXZ+RhLw4xl3mOd05hRo5VcqCLf5S1UqNY8wguT2dPwbhD5JamSNfLIYsuJCys+LA== X-Received: by 2002:a0c:f3c4:0:b0:68f:5bde:b4a5 with SMTP id f4-20020a0cf3c4000000b0068f5bdeb4a5mr903214qvm.23.1708650816856; Thu, 22 Feb 2024 17:13:36 -0800 (PST) Received: from hurd (dsl-155-144.b2b2c.ca. [66.158.155.144]) by smtp.gmail.com with ESMTPSA id ok23-20020a0562143c9700b0068fbe5a6ff8sm1348044qvb.121.2024.02.22.17.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 17:13:35 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <87bk8dl8mm.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 18 Feb 2024 23:17:53 +0100") References: <0b81168e693a21f7fb08bd7677a5cc3120418fc9.1707626620.git.maxim.cournoyer@gmail.com> <87bk8dl8mm.fsf@gnu.org> Date: Thu, 22 Feb 2024 20:13:33 -0500 Message-ID: <87edd4oude.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -1.81 X-Spam-Score: -1.81 X-Migadu-Queue-Id: CF48B787D3 X-TUID: hdiA0VjXMqrH Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi! > > Maxim Cournoyer skribis: > >> * configure.ac: Require Guile-Lib. >> * guix/logging.scm: New module. >> * Makefile.am (MODULES): Register it. >> * guix/ui.scm (show-guix-help): Document --log-level global option. >> (%log-level): New parameter. >> (run-guix-command): Init logging. >> (run-guix): Parse new --log-level option. >> >> Change-Id: I5026a0d62119615fec3cd0131309f9bcc346a7e9 > > Two quick notes: I think it=E2=80=99s be best to avoid depending on Guile= -Lib > =E2=80=9Cjust=E2=80=9D for this (it=E2=80=99s not clear to me what it=E2= =80=99s maintenance status is), > and it=E2=80=99d be great to have concrete use case. David Pirotte is doing great for Guile-Lib maintenance. It's better maintained, than say, Guile-Git, which we also depend on :-). It has a good test suite and is small. We already depend on it for a couple of our updaters, for its htmlprag HTML parser, so combined with this log facility, that seems enough to justify hard depending on it. > My concern with logging is that it=E2=80=99s not a good fit for the funct= ional > parts (unless it has a functional interface like =E2=80=98pk=E2=80=99, bu= t that=E2=80=99s still > sorta =E2=80=9Ccluttering=E2=80=9D otherwise functional code), and I=E2= =80=99m not sure which > imperative part it could be used for (I don=E2=80=99t doubt there=E2=80= =99s such a > thing, but I lack imagination). I understand the concern, but I think to be able to trace execution easily at run time with a simple `--log-level=3Ddebug' would provide value enough (as a developer aid) to justify it. --=20 Thanks, Maxim