all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Richard Sent <richard@freakingpenguin.com>
To: Dale Mellor <guix-devel-0brg6a@rdmp.org>
Cc: 70226@debbugs.gnu.org
Subject: [bug#70226] Fwd: I haven't been able to trigger this bug
Date: Tue, 30 Apr 2024 16:20:10 -0400	[thread overview]
Message-ID: <87edamd2md.fsf@freakingpenguin.com> (raw)
In-Reply-To: <7138c2308cad21abb86f0ef0095904a9b4030c1a.camel@rdmp.org> (Dale Mellor's message of "Tue, 30 Apr 2024 18:54:40 +0100")

Hi!

Dale Mellor <guix-devel-0brg6a@rdmp.org> writes:

> Can you give a command-line use-case which actually triggers this bug?

Certainly. I've replicated this issue on guix a1ffa8a with:

$ guix search ""

$ guix system search ""

$ guix home search ""

guix search "" takes ~30 seconds before the bug occurs. (Once the first
result is printed to stdout.) system search and home search are
basically instant. That's probably due to the smaller pool of
candidates.

Working on this a bit more the problem isn't the regex search itself.
Instead, I'm confident it has to do with the highlighting performed by
display-search-results when passed a list containing a "" regex. The
issue does not occur for system search with just the following diff:

--8<---------------cut here---------------start------------->8---
modified   guix/scripts/system/search.scm
@@ -189,5 +189,4 @@ (define (guix-system-search . args)
       (leave-on-EPIPE
        (display-search-results matches (current-output-port)
                                #:print service-type->recutils
-                               #:regexps regexps
                                #:command "guix system search")))))
--8<---------------cut here---------------end--------------->8---

V1 of this patch shouldn't be merged. The bug should be fixed in
display-search-results's highlighting logic instead.

-- 
Take it easy,
Richard Sent
Making my computer weirder one commit at a time.




  reply	other threads:[~2024-04-30 20:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 20:16 bug#70223: Search for empty string uses excessive memory Athena Martin via Bug reports for GNU Guix
2024-04-06  1:13 ` Richard Sent
2024-04-30 17:46 ` bug#70223: I haven't been able to trigger this bug Dale Mellor
2024-04-06  1:05   ` [bug#70226] [PATCH] scripts: package: Disable searching with the empty string Richard Sent
2024-04-30 17:54     ` [bug#70226] Fwd: I haven't been able to trigger this bug Dale Mellor
2024-04-30 20:20       ` Richard Sent [this message]
2024-04-30 17:55   ` bug#70223: Scratch: " Dale Mellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edamd2md.fsf@freakingpenguin.com \
    --to=richard@freakingpenguin.com \
    --cc=70226@debbugs.gnu.org \
    --cc=guix-devel-0brg6a@rdmp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.