From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id cIYwKa+RcmZMiwAAqHPOHw:P1 (envelope-from ) for ; Wed, 19 Jun 2024 08:07:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id cIYwKa+RcmZMiwAAqHPOHw (envelope-from ) for ; Wed, 19 Jun 2024 10:07:11 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=clDqVl4d; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718784430; a=rsa-sha256; cv=none; b=ZS0GeWyGjOmWDPHcsIzuEqjLDuT2Q6D+GQKSE3dapIrQ6c43Bayf+6efrx68hwlBIYUuc+ PJfKwR6/sEX/QnA2Ux0p5CdQzGKcNnHMwfdFOq7tcs1pcHfbJCvufTL6wbVqIkELi//yyW TOA+Ab2cxkzJiizNQ3+ImD9oMsONJUJTgahsUZVucE7KSnM2ZeV7vnv+ZIOpl742uwClT8 4RrvWC+bkKZrqEk3ZdN2kuLWcnLwMK3f3/ee340Ty6sXrTNPKgTCR2piZAwVAEZmH562P4 1LiIbBKGMCNUNa+25NmGulkkdl+MYmICUjY63ixYl8SF034zLIM+YvwQ0QaVkA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=clDqVl4d; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718784430; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=boWojQE73ARtmc24IdKdXzeuddoc7BBQ2ZB73BbpR6s=; b=LwEHdwTbIXOohngq7ZozC96vzNGu2R/jC80TnFpM0gDcWs+hnohDI0Ygh1+fUAC4JQP2Ek g7+gZUPyjx0PKMKjj6hVopCHQ1LgB8WxeiqRENx7ipG8H9NBi76ul3pB7cLqI9meXN6WuO DuPPnyWtiOlnD7P2LgHttxHSV5HY3LOFpUajeiv/Nw9QrTk+fzkcqyyBK+/MjJYALYFCRK dJjdnS902hfdCd44PFsYiIsf0mS33BXkv4SEgEUQRNarja3oLQig9Byb0ZhrRlm5ewQ9BH fzbXZ3oUHP0xGC6f/kKqhkHxjtVA7l566e2foe6eKLZgYRFX3LqW/klsslHL/A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 88C5863C8B for ; Wed, 19 Jun 2024 10:07:10 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJqLN-0008Fs-Bt; Wed, 19 Jun 2024 04:07:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJqLL-0008FW-IK for guix-patches@gnu.org; Wed, 19 Jun 2024 04:06:59 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJqLL-0000Ur-9q for guix-patches@gnu.org; Wed, 19 Jun 2024 04:06:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJqLO-0004NJ-CS for guix-patches@gnu.org; Wed, 19 Jun 2024 04:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71581] [PATCH 11/11] gnu: Remove node-bootstrap. Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 19 Jun 2024 08:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71581 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ashvith Shetty , 71581@debbugs.gnu.org Cc: Ashvith Shetty Received: via spool by 71581-submit@debbugs.gnu.org id=B71581.171878437616727 (code B ref 71581); Wed, 19 Jun 2024 08:07:02 +0000 Received: (at 71581) by debbugs.gnu.org; 19 Jun 2024 08:06:16 +0000 Received: from localhost ([127.0.0.1]:36394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJqKd-0004Lj-L8 for submit@debbugs.gnu.org; Wed, 19 Jun 2024 04:06:15 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:35368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJqKa-0004LW-I8 for 71581@debbugs.gnu.org; Wed, 19 Jun 2024 04:06:13 -0400 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1718784367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=boWojQE73ARtmc24IdKdXzeuddoc7BBQ2ZB73BbpR6s=; b=clDqVl4dG7hvgK6RR2pdiZgqU9Phlb72NX8tLG7eu5EA9MxxFuVbXfdnk1IEegAjYMdZsl MgX50dhPNoEFzM7gOIcRr7QZZwcdtopvI9hu3wKS/uM6Yg/Zefdc9uQzwG0wlvai8mmwIV X19ghv99wyxoST+DqKuTFeIe5+JLleQ= In-Reply-To: <62b68f1e5db41296ba22bbc9f9d91f1519fb9982.1718737412.git.ashvithshetty10@gmail.com> References: <361a358ac968efb4148512054e62f0f211abf7f7.1718737412.git.ashvithshetty10@gmail.com> <62b68f1e5db41296ba22bbc9f9d91f1519fb9982.1718737412.git.ashvithshetty10@gmail.com> Date: Wed, 19 Jun 2024 10:06:04 +0200 Message-ID: <87ed8tuzkj.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.26 X-Migadu-Scanner: mx12.migadu.com X-Spam-Score: -5.26 X-Migadu-Queue-Id: 88C5863C8B X-TUID: m3Wx21Lu6CjE Hi Ashvith, Thank you for working on Node.js related things in guix. My apologies for not looking into your set of contributions earlier, I have an longer train ride coming up where I can set aside some time for proper reviews. Ashvith Shetty writes: > * gnu/packages/node.scm (node-bootstrap): Delete variable. It seems there has been a misunderstanding (not on your side!) about the construction of the llhttp package. It is a bunch of javascript that generates code in C, which can subsequently be compiled by any C compiler. This means that the llhttp package that is currently included in guix does not meet our packaging criteria, and should be patched and/or removed. I'll send a bug report for this separate issue later. (IMHO this will boil down to it being built like llhttp-bootstrap, but perhaps using the node package instead of the node-lts package. Either way, the node-bootstrap and llhttp-bootstrap packages would still be needed) Provided I didn't misread the situation, this makes your patches require rework; perhaps we could discuss a way forward that respects your time as much as possible. It might make sense to jump up to the latest Node.js LTS version (20.x.y) instead of the 18 series. I even think we could patch more modern llhttp versions so that we could still build them with Node.js 14 (node-bootstrap), in which case we could move towards the Node.js 22 series. Kind regards, Jelle