all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: Adam Quandour <adam.quandour@gmail.com>, 71184@debbugs.gnu.org
Cc: Adam Quandour <adam.quandour@gmail.com>
Subject: [bug#71184] [PATCH] gnu: Add ruby-appraisal.
Date: Sun, 30 Jun 2024 23:02:18 +0200	[thread overview]
Message-ID: <87ed8ejg9x.fsf@ngraves.fr> (raw)
In-Reply-To: <20240524213807.10537-1-adam.quandour@gmail.com>


Hi,

I notice two different packages, can you split the commit please?

Also notice the lint warning on https://qa.guix.gnu.org/issue/71184 :

gnu/packages/ruby.scm:1530:0: ruby-appraisal@2.5.0: line 1530 is way too long (99 characters)
gnu/packages/ruby.scm:1530:14: ruby-appraisal@2.5.0: no article allowed at the beginning of the synopsis
gnu/packages/ruby.scm:1530:14: ruby-appraisal@2.5.0: synopsis should be
less than 80 characters long

Otherwise: built reproducibly, package definitions themselves LGTM.

-- 
Best regards,
Nicolas Graves




  reply	other threads:[~2024-06-30 21:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24 21:38 [bug#71184] [PATCH] gnu: Add ruby-appraisal Adam Quandour
2024-06-30 21:02 ` Nicolas Graves via Guix-patches via [this message]
2024-07-02 12:58   ` Adam
2024-07-02 13:35 ` [bug#71184] [PATCH 1/2] gnu: Add ruby-thor-0.14.6 Adam Quandour
2024-07-02 13:35   ` [bug#71184] [PATCH 2/2] gnu: Add ruby-appraisal Adam Quandour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed8ejg9x.fsf@ngraves.fr \
    --to=guix-patches@gnu.org \
    --cc=71184@debbugs.gnu.org \
    --cc=adam.quandour@gmail.com \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.