From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id cFTJA9bkjWYzCwEAe85BDQ:P1 (envelope-from ) for ; Wed, 10 Jul 2024 01:33:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id cFTJA9bkjWYzCwEAe85BDQ (envelope-from ) for ; Wed, 10 Jul 2024 03:33:10 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=KvgcFe21; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720575190; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=klpBw02jw1k3WnVOYDW7Xn1yclll4njkgXa+hvgFs8I=; b=CCE99/sD1Kv6qci3lYv4L+wXePihM5PgLQE1d54n1r5Nxip5drtNXcFi+ITsoyloseO8+n XsN4s8DNaq6iVLzX3MKFW8bLvLtl+nfl66XNgaurOjgi9TTzSUAmp+rXR03bn4jARjV9Pw q8DWFgkLKYL+Ql7kgLEfxOnFhx+vG+xR1Ytxte5KC3U/+3csiZGJfBA4Bxwra3ypFOFa4f 7KFW0G7QHy5G5xlRB/b57Z3vT904rxftbfKY3NqaLJzbTumZvqir8RTQ34ytiigeV0FO4w hBrWkR1dS2XQLqrqqFJ1p83o46yiojMBMqTXpaTTGU22Bo3pkPydNawjgmj0HQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720575190; a=rsa-sha256; cv=none; b=mZy4TLl3a6oik9Bt2Lsa5c//kRj8GlKvo4FHLnD+2xJDEZCK+ypm1a06uAUeD5K3fexo43 9sdYxDcuAfWH6Fsae0+wDdL3amdRu5IT/tYS6GFs8c4npRx6hmYHQjHmnjCJbYnquHRP1G a5ItgSo3PmznoPzHrShznvxzjUvQo6wkqlWKbkRRdx2MorF2mBYFqo1hAzNWXAmHG1RN0v LZj+Sw8/9DwZtkJjTpLOkkSYZa9LFUlaeNAIUWOfexmVe68RFo+wjfbh9o6hJpkZidAvBL dJoUiQjeSVkWRPsc3f5C65VO8VnCajJFNIRHoxekm1u67nMPJnCMjPHjItELfw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=KvgcFe21; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A990694C7 for ; Wed, 10 Jul 2024 03:33:09 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRMCZ-0004lo-4B; Tue, 09 Jul 2024 21:32:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRMCW-0004dn-Vm for guix-patches@gnu.org; Tue, 09 Jul 2024 21:32:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRMCW-0001Ty-LA for guix-patches@gnu.org; Tue, 09 Jul 2024 21:32:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sRMCc-00056C-4K for guix-patches@gnu.org; Tue, 09 Jul 2024 21:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71897] [PATCH 3/5] gnu: Add cppgir-for-telegram-desktop. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Jul 2024 01:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71897 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: dan Cc: Liliana Marie Prikler , 71897@debbugs.gnu.org Received: via spool by 71897-submit@debbugs.gnu.org id=B71897.172057516719579 (code B ref 71897); Wed, 10 Jul 2024 01:33:02 +0000 Received: (at 71897) by debbugs.gnu.org; 10 Jul 2024 01:32:47 +0000 Received: from localhost ([127.0.0.1]:54533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRMCN-00055i-8d for submit@debbugs.gnu.org; Tue, 09 Jul 2024 21:32:47 -0400 Received: from mail-qt1-f174.google.com ([209.85.160.174]:58791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRMCK-00055S-Sg for 71897@debbugs.gnu.org; Tue, 09 Jul 2024 21:32:45 -0400 Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-44acdd30c3fso2052151cf.1 for <71897@debbugs.gnu.org>; Tue, 09 Jul 2024 18:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720575093; x=1721179893; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=klpBw02jw1k3WnVOYDW7Xn1yclll4njkgXa+hvgFs8I=; b=KvgcFe21gT2R6JQTDk4RFwmdciwiKc8BXLPYlehfcbR9cz8uXZX2ZZkFnIapf56wVZ ZIUuwk1P6cmWYQWCm5RsvXlFp/c6y8m1fmo5zH5ZU6Vrs8HJ/4pOEhbBKcDeaM2fLJct kUPdY53Zz12V45BedLzm6IskOdUTZp81SY2p+alqTSez3AisF59Ye5AHmmn71kd0dTYZ MDhX9rIfQT70E7nzqrcJabtR7mlH6eK1JAO2gVtk41QLJIdFbHbQM7Gi3Ye69VDZTEY3 j4GAesTiZgMLvUbsnOUSbWvVrd0tSGn0UnDs45jc89W6BMzqi3PC+IcVMWfJaYRCKI5n AxNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720575093; x=1721179893; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=klpBw02jw1k3WnVOYDW7Xn1yclll4njkgXa+hvgFs8I=; b=SrDWfsUiEY+K2hH/99uJzZffcj1PLl3VEet805GZjjC/UhcJWRy2OUrsn2kn2KC+cq XJh7dGwiVQKG12ODXeToWdX3MLS/x1OOvrN2nCCrMvzfdOt/SDHl/ulrflx093KHTKk4 HI4X6CErDgXO0WP6lUlFNVfuBWAR+LQJasNTZzF6WBpnxJeSK1ObSJYrBOLx9hWVPZm7 hnaZb5SjN4Q3xUAEhHr9qQ5df8w/M4515clIH1rTc6+SIQxevT+qjOVTGz4TAuRBWRyM rXvmR00I+AuafK1eGjv6YTG9t6BJyIwZzpBG5fSkOF8U+pejHhNcLBrifMhhL4empGC/ csxQ== X-Gm-Message-State: AOJu0Yz9zdI+uekebkOUXlJ7ClH1NjgfI5c4+MwCBzfaECP9LVcxng7B JM00byPfRvD1d1kL5PACtVPIFMZ3KvOtdzdAx+zICsPwBKIzUolu X-Google-Smtp-Source: AGHT+IHnOIEfhwVO06B9xMlxsF0629ZxefK6+Pl8JWivJeQLq1yDFZuJ3iIWVTBtQpxHNOXtfI7LVA== X-Received: by 2002:a05:622a:52:b0:447:f1a9:64cd with SMTP id d75a77b69052e-447fa853603mr54622211cf.1.1720575093218; Tue, 09 Jul 2024 18:31:33 -0700 (PDT) Received: from hurd (dsl-205-236-230-124.b2b2c.ca. [205.236.230.124]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-447f9b26c83sm15855411cf.2.2024.07.09.18.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 18:31:32 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <82e92de9-50ed-4f7b-91d7-253c41da5965@dan.games> (dan's message of "Tue, 9 Jul 2024 11:07:54 +0800") References: <3743fa793bf867b8112b2883815b573f955c12ce.1720364199.git.i@dan.games> <17a452e63821067a5a3b27a6e4114404e242f290.1720364199.git.i@dan.games> <87h6czxpx7.fsf@gmail.com> <82e92de9-50ed-4f7b-91d7-253c41da5965@dan.games> Date: Tue, 09 Jul 2024 21:31:31 -0400 Message-ID: <87ed82vxqk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 6A990694C7 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.30 X-Spam-Score: -5.30 X-TUID: N1iZvXGXMsDu Hi Dan, dan writes: > On 7/9/2024 10:25 AM, Maxim Cournoyer wrote: >> Hi Dan, >> dan writes: >> >>> * gnu/packages/telegram.scm (cppgir-for-telegram-desktop): New variable. [...] >> That'd be reasonable as a new package if it was very tightly >> developed >> with telegram, but it doesn't seem to be the case. I'd prefer having it >> in (gnu packages glib). >> What is the "compilation error" you had mentioned when using version >> 2.0? Does the cppgir release fails to compile itself, or is it >> telegram that then doesn't build using that one? > > Sorry about not directly replying the previous message. It's the > latter, telegram-desktop fails to compile with cppgir@2.0. > >> If the later, I'd define, in (gnu packages glib) >> --8<---------------cut here---------------start------------->8--- >> (define-public cppgir >> [...] >> "original package at version 2.0") >> (define-public cppgir-for-telegram-desktop >> (package >> (inherit cppgir) >> (source ... (using latest or telegram-specific (?) commit)))) >> --8<---------------cut here---------------end--------------->8--- > > For the lower package definition, I put it in (gnu packages glib) or > (gnu packages telegram)? I think it should be the latter one? It's a bit counter-intuitive, but it has to be in the former, to avoid cyclic module dependencies caused by top level variables referring one another in different modules (that's fine for delayed fields, but the inherit field is not delayed). For more information on this topic, see (info 'guix (Cyclic Module Dependencies)'). >> Sorry for the back and forth, we're narrowing down on the perfect >> submission; keep it up. Don't forget to use -v5 for your next patches >> submission :-), and ensure 'guix lint' is happy with all the packages. >> Thank you for your efforts! Keep it up. >> > > Sorry about forgetting to add revision number to the patch > series. Although we have mumi right now, there are still a bit of > manual works to be done before sending patches. I constantly forget > some of them. I do like the ability of patman of recording where my submission metadata as git trailers in the top commit. Mumi could in theory avoid the need for automatically using -v though, since it can look at the past messages sent to an issue and could infer which revision should be used, in theory. -- Thanks, Maxim