From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id sALkE+G172bHngAA62LTzQ:P1 (envelope-from ) for ; Sun, 22 Sep 2024 06:14:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id sALkE+G172bHngAA62LTzQ (envelope-from ) for ; Sun, 22 Sep 2024 08:14:57 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=HtNFWFRN; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=NwFTsbVa; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726985697; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=L1hhNgYb/ASrqP3VwpKdGAEKW4i2oCMv2GmiSGDkbpM=; b=Wc0Joj0qFw29uyJZvkiq0MDKqhMeInaBqPulBqvLn7bIteBhQw+Wl82+LbjoK33edBzrCV MT6VKvknEDwhw5GGuDpISzMJ2SKVzc+bQTmnjkOisGUftDPY4ng8KUsXMfoLjh8wKL32ca fRb9z3YemxhZ1cty1dkweqBDlHo/sU+iDvdW2u+j5dnxifBoNHZSICajJmIpanfbz/hZbq ry2AP2Rzq2SXH04I3POQE7jPvTZiIGiNapZBNjsII82tXTaMEnrrvOPYZ56fJ+S3/aUFah CSrG6XpTOit4EADWoKt71QFzLCmOe8PH4vMUFmIvXYcDAytMjykon4YakGrA2g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=HtNFWFRN; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=NwFTsbVa; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726985697; a=rsa-sha256; cv=none; b=coqQHdEJCxAKZEBO4qCt0IF5tozmoPOODqcFtZDJHS8eFlOpEuG3MxntY29Gefhk9bwJDR rxhpmrF6TZN4AyPw0iLV5h5YvZfTTQ+7mbFS+2JtPSx7Q0x3s76OFyo9To478Z3otyFJQ5 +WheP6SERUx/e7kkLmtPS44+ZdKE5e+z3fp3fYcahcPNip5I+9FU34QIK0VqfaR7P/ZUhe oG8SNMwDfqL8mos3bCvotu6/Oq1XvtSeJnf1s7202+GMYFVCyVFDvxCjfhHy98piDBsDtG 9EhD2plA4MYEfQ6mLMZ8F70mXwPycAd917F9V2PuHO194wEMIzwEymhm+MwOog== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7516436B2 for ; Sun, 22 Sep 2024 08:14:56 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssFro-0007lX-N7; Sun, 22 Sep 2024 02:14:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssFrk-0007kO-SP for guix-patches@gnu.org; Sun, 22 Sep 2024 02:14:40 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ssFrk-0008HI-IM for guix-patches@gnu.org; Sun, 22 Sep 2024 02:14:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=L1hhNgYb/ASrqP3VwpKdGAEKW4i2oCMv2GmiSGDkbpM=; b=HtNFWFRNTsM/0d0n5i6YaYhsAxqpAuJUxZlheCXVZsYKDfvz1e4ieJ/u+RNpkl5pu5XGxtRlCaxOpn4zEpXlDu+8pYX3QYvfOp/vgHgXxujPverPwrqmwqAKsxvGuYTGqy65prXl5cSluhEn3aRGM5Eo5Q8eHjVQs8t5C1Rz4Vq6ZN1TyPkWl9j0n8jRCVCo1KJG45UGT3lt48yQyqOTiSMbLMbhg2yFVGPrH0DxD/Ly0wexbsnBu0at2SjjyMc5/siV/EXErjSf/WvYL7W+OfB4qeC+mZ0VKsAJo9YFiANHJmRZmHfNDS9HjHSNpLQb5tUWyMiwhGyR/5aTTvsonQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ssFs5-0004CJ-NB for guix-patches@gnu.org; Sun, 22 Sep 2024 02:15:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71897] [PATCH v8 6/8] gnu: Add cpp-ada-url-parser. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 22 Sep 2024 06:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71897 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: dan Cc: Sharlatan Hellseher , Liliana Marie Prikler , 71897@debbugs.gnu.org Received: via spool by 71897-submit@debbugs.gnu.org id=B71897.172698568516093 (code B ref 71897); Sun, 22 Sep 2024 06:15:01 +0000 Received: (at 71897) by debbugs.gnu.org; 22 Sep 2024 06:14:45 +0000 Received: from localhost ([127.0.0.1]:40687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssFro-0004BV-Ph for submit@debbugs.gnu.org; Sun, 22 Sep 2024 02:14:45 -0400 Received: from mail-pj1-f48.google.com ([209.85.216.48]:51543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssFrn-0004BH-Ds for 71897@debbugs.gnu.org; Sun, 22 Sep 2024 02:14:44 -0400 Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2d877dab61fso2311445a91.3 for <71897@debbugs.gnu.org>; Sat, 21 Sep 2024 23:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726985596; x=1727590396; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=L1hhNgYb/ASrqP3VwpKdGAEKW4i2oCMv2GmiSGDkbpM=; b=NwFTsbVamb3+Rwbl4xvKp1tfcOLZbmSKuMgVH/InTb2g4zHdTlQzNMHfBZLEoDFYJS jk911g1U5u9d4chCGXtQhJxzHk/rrTqRySzonkOSGx/HIVaQpXogBRVYZcWomhpg2wjl RP4qSfklod2h/Nc6uGn9ySh6T8GbLDFF0x4CFtLZsv6+j6U0tb2fZKKi8B1gXRnGzl8a FOWMeqxB74TZQmuzeCWeTtBPYMw384Rk2kYNrAb2quZcHFVfttSgAIAIfPSvB9Scnhb1 U+LbGadrAiIkvno2SsHH8czhrhblXxnZHARL7/FFN75vbmu+EAMByjgN0nI31+0pOkAS cJGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726985596; x=1727590396; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L1hhNgYb/ASrqP3VwpKdGAEKW4i2oCMv2GmiSGDkbpM=; b=jcAP3lMTF2Eb5TCeHQPh0VF4RrVsZ+I/xTSS+De79FgNHN4TMF0qeI72JINsGEaW5J fh83ePYvyLB89llRK9FDBplOd1PsbYeD4fI72A9ox0VsCdfx2KZSgVql0JSoHRiQMFy8 h9EkXB7xcswrQjLsmW7hxL8W+v2XOBPeYwqkhwkjT6Q28hTfyBKP4AkbzCEl8l6jNOva wQpHPXHLNx9wx9uNPeldxGw/h5Cq+Lrx02VEVMl1QbJNLDAV5GEdWEJVkvy8a95U3KVB pAY8b31RfEJO8wRXZ9VlehvuiyghsuVbAUGZ4fWVPpNzc2wOW+JxhTPr6ANwY6iJv0Qv Px8Q== X-Gm-Message-State: AOJu0YwKKTikbdVhzw4GHNwD7GqvdMzyPIoRvYQhGmhyGLNPoACyp+fH 2umuVoZsCdyVZDUNpylgL1AoNhGi2uFZNO7YsYYkiAb9O5uOsFPs X-Google-Smtp-Source: AGHT+IG5EGHy1O4QP0B2S6JCe3jZDmZFB2J6FnmeTjSZK6ZhcBu7o3tJ7/8F9t2kuQD95bLSIm94pA== X-Received: by 2002:a17:90b:3850:b0:2d8:c7fb:340a with SMTP id 98e67ed59e1d1-2dd7f763a79mr9938994a91.38.1726985596415; Sat, 21 Sep 2024 23:13:16 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2dd6ef40fe5sm7077200a91.39.2024.09.21.23.13.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Sep 2024 23:13:15 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87a5g0740b.fsf@dan.games> (dan's message of "Sun, 22 Sep 2024 11:37:24 +0800") References: <5fddf9f718d95467cd90d9d2625d749af580205c.1726930328.git.i@dan.games> <2ae23a993d9f52c8a4fd5ef0aff148fa5ab4e509.1726930328.git.i@dan.games> <87setsl6s1.fsf@gmail.com> <87a5g0740b.fsf@dan.games> Date: Sun, 22 Sep 2024 15:13:11 +0900 Message-ID: <87ed5ckyh4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 7516436B2 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -8.96 X-Migadu-Spam-Score: -8.96 X-TUID: 2Y79tkaSj5wK Hi Dan, dan writes: > Hi Maxim, > > Maxim Cournoyer writes: > >> That's not upstreamable work, so should ideally be marked as such as >> a >> patch at the top of the patch file (Upstream-status: N/A or >> similar). >> It's a bit sad that this will need ongoing maintenance (careful >> rebasing >> when they touch that file). I'd like to see the problem with CPM >> commented in a bit more details -- wondering if it could be made to >> work >> without patching it out, e.g. perhaps some CMake variables can be >> set to >> have CPM work offline? > > In the previous iteration, I disabled ADA_TESTING and ADA_TOOLS so > that no patches are needed. However, Liliana suggest that "we should > enable testing, even if we need to patch the cmake files to unvendor > inputs". I think we have to make a decision here: we either accept a > package with testing disabled, or we need extra work to maintain the > patch in the future. I agree with Liliana. We strive to enable test suites in Guix packages, as this gives us a much easier time detecting breakages early when upgrading dependent packages. My suggestion was to look a little bit deeper in the problem at hand in case to see if it can be configured to work for our needs. If it can't, then your approach is perfectly fine (ideally with a feature request upstream requesting an easier way to run their test suite offline); if it can, we should configure it instead and avoid having to maintain extra patches. > I took a brief look at CPM, and it seems possible to fetch > dependencies from local directories, but I assume even we go this way > we still need to patch their CMakeLists.txt files. There's a relatively new FetchContent module in CMake that perhaps CPM abstracts? If it's using FetchContent, it should be possible to have the build system attempt to use a system-provided library instead of fetching from a submodule and building it from source. See the 'jami' package, for example, which sets '-DFETCHCONTENT_TRY_FIND_PACKAGE_MODE=ALWAYS' to have FetchContent do that. -- Thanks, Maxim