From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 4Ki7FUigEme0CQEA62LTzQ:P1 (envelope-from ) for ; Fri, 18 Oct 2024 17:52:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 4Ki7FUigEme0CQEA62LTzQ (envelope-from ) for ; Fri, 18 Oct 2024 19:52:08 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=ElAcoT5j; dkim=fail ("headers rsa verify failed") header.d=fabionatali.com header.s=gm1 header.b=mS11Umr5; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729273928; a=rsa-sha256; cv=none; b=mbaZffLRhmEkte6U+mM5V7jQgbzrEJA1/9QNdgP8FVb5ciBsQ95sBU/gQjOm1tWdtzrxxu tQO0h4b6nna8KRqf9gggWj4aH8NFMkOnoaveHIyJgPZP5ohbdSPpbHDSdLTuqlIAcOm5uK NT+h8jfmMTaKhuPJKhlzVGpXGzpFxwf23Fkj8Bb3neEK91LcyOoPNnz473gNrqHY9GTajU 0GezSGCo61FZoRUFAeoedUm4vBsoME+2f8cIXYEhDbmOKKn2oNbNVj3i4KheOt9bchsKQo SqqPiNIwJz7X4pAG1xMqBbZn2q9R4qC4WXtpZ8AP9xMF2Jq9yhnMDjTwLf3lMg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=ElAcoT5j; dkim=fail ("headers rsa verify failed") header.d=fabionatali.com header.s=gm1 header.b=mS11Umr5; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729273928; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=BfyqaQVzS5HBH4pwaNSO6EWBW67Zyda+E4+/LlDGYCQ=; b=NK+fHmTicnz/nM1MRmnTsg/XHyztpB6fqMynH3RkeMRKUDrLHfDOt2l8OkIawn+pNAGO5t 3NEX23gczSQagpWiXPvwo0xlDAe/Qg/tORjlYMTgRVd4lhoMXwu58Id+DyvmcBipMxyX/v jVYhSj6k13a4yDNYN7yvb7Lvfe3lCkLGwhmZZ2cxkjrrAyhTC7pQQO2uyurVY1eLeN7WXn YxMSCC5HszxYFc/GxaC2iOfcz+bdvxapfn36gLZ+GM7EDx+kMWUPYrdUcc4XuUkDD9K6zr 2ih4K1fR2F7XIVXKpWMkWFGttrnMSo2qlVXOir98a5zzqUqCbmg4FoCw7gr5ZA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CE1E31F140 for ; Fri, 18 Oct 2024 19:52:07 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1r8Z-0006Bc-1v; Fri, 18 Oct 2024 13:51:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1r8W-0006BO-M7 for guix-patches@gnu.org; Fri, 18 Oct 2024 13:51:40 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1r8V-0006Vn-Ui for guix-patches@gnu.org; Fri, 18 Oct 2024 13:51:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=BfyqaQVzS5HBH4pwaNSO6EWBW67Zyda+E4+/LlDGYCQ=; b=ElAcoT5jv90CBY17hDlomKqn2Tggy7nm3JCG2NlGUk/oSQgDTtNpR7Y1U115EeKelv0yVDy3XlUBqKpUQET4HYhuNZ0AX8vOJzG4qLVHI2Rbyn7Cw+Ok65YZJqgC6Heb26Vq8+GPBxn8KXIGS+gr6TVwpNUm1rgdF1G0kyH4muq01mrpvnDTnylWHqb/KeMTuQ9fHYXZ95DKRCYzigCqaRRFEuhtNYiuX7VCFEMvhjrRph/yoCMot2OF3QceTXvOqjL6I3j3wPi7LLo2Eg6y6ETy4mYIUzxaJBE/aEaUNrXmPv+9zr8jnI8z6ceGJMIt9jQprSMnjbnL+trJZvFylw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t1r8s-0003aE-HL for guix-patches@gnu.org; Fri, 18 Oct 2024 13:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72398] [PATCH] services: Add readymedia-service-type. Resent-From: Fabio Natali Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Oct 2024 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72398 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Bruno Victal , 72398@debbugs.gnu.org Received: via spool by 72398-submit@debbugs.gnu.org id=B72398.172927386913704 (code B ref 72398); Fri, 18 Oct 2024 17:52:02 +0000 Received: (at 72398) by debbugs.gnu.org; 18 Oct 2024 17:51:09 +0000 Received: from localhost ([127.0.0.1]:39965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1r80-0003Yy-Qu for submit@debbugs.gnu.org; Fri, 18 Oct 2024 13:51:09 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:43157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1r7x-0003YT-Vg for 72398@debbugs.gnu.org; Fri, 18 Oct 2024 13:51:07 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 01A7EC0003; Fri, 18 Oct 2024 17:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1729273817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BfyqaQVzS5HBH4pwaNSO6EWBW67Zyda+E4+/LlDGYCQ=; b=mS11Umr5ELhrvuYVtFKr6OnmxDYOIsUknITa+FRLetBX/Ncmy1v6JR6vaZ9yQbbeBfZF1O PUPl4440tZJSRib5LNaTuONUvLbLl7Cbz7IxoLx17BwQ6+kUEtpS5xfvagJQ73jtDMx4VW ag0Gjp76TRWW56Sg8hVjrAmHDbyrrPeEc3C+8FsWx+ChnubiZYsFhTRS9cs4c0cJ3LU+ms rGFYZQ74Mkw4th1XQ0W0JBvjtY3Vv/0mFUPkX5ZLzTSI0rQMl6t5iEDfDRGu0WVjSRcZWT 5E7LFialLXfd81j9KZuN+eG8/HuJQ+gnVSZXNnHXjQOYuojMg6GYMfzEmDOH2g== In-Reply-To: <875xpqp5r7.fsf@systemreboot.net> References: <875xpqp5r7.fsf@systemreboot.net> Date: Fri, 18 Oct 2024 18:50:15 +0100 Message-ID: <87ed4duwq0.fsf@fabionatali.com> MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: me@fabionatali.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Fabio Natali X-ACL-Warn: , Fabio Natali via Guix-patches From: Fabio Natali via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.58 X-Spam-Score: -3.58 X-Migadu-Queue-Id: CE1E31F140 X-Migadu-Scanner: mx10.migadu.com X-TUID: LfP7f+thygVP On 2024-10-18, 02:19 +0100, Arun Isaac wrote: > I am sending you a final updated patch v8. I have modified the > indentation of the code, removed single-letter variable names, reduced > the number of variables, etc. I believe everything works. But, if you > could try it out and confirm, I'll push it. Hey Arun, Thanks and sorry, this might have taken quite a bit of your time, it's a non-trivial clean-up. I've checked all the changes and rerun an end-to-end test in a VM. Everything looks good - we're good to go! :) Thanks for the introduction of '@acronym{}' in the docs and 'match', 'match-lambda', and 'match-record' in the code, which simplify things quite a bit. Thanks for some stylistic improvements here and there. Perhaps the only change I'd do at this point is around one or two overflowing lines, personally I'd truncate them down to fit the 80-char limit. Not a big deal and I'm also happy with v8 as it is. Given all the help given, have you considered adding your name to the file header? Thanks, cheers, Fabio. -- Fabio Natali https://fabionatali.com