From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id YBQLEoEdEmfqiQAA62LTzQ:P1 (envelope-from ) for ; Fri, 18 Oct 2024 08:34:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id YBQLEoEdEmfqiQAA62LTzQ (envelope-from ) for ; Fri, 18 Oct 2024 10:34:09 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=uPwAoeJv; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="ffnA/kya"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729240449; a=rsa-sha256; cv=none; b=gYMmsx/d2QPGVHKbd/sNB03L0U4pJpTBroTrZ6XF+zMfVFuH42/ey9zFcI4jfPQ0SN83aL dek+OXp68t4y8Zg6RscoeLsGWuTZiUiGs69VOkaB6YEzNFrgY9M0T+9JW7SlzVoGhEQzeG 4qLv1CJG+seE1ZM6HcbA+Q/nIXARjBqNZx64Dc1j0ZljnxEGoMxL7WAnRCUs+5z5pwWagQ Nk0eSvzAazA6S0nSeqEfb0Y+ftSR12OQADTXXv+9rpiuuPz8RZmKxMO+bADkq19tt0Ivhh soxWQfmuSv+R6ePAz8ozr8my1o9OfzMIkiNBm0fotwgeKViIYo5/7pqMM3Vt4g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=uPwAoeJv; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="ffnA/kya"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729240449; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=oODROXQny58lyn+ie/aJi0xxeh9XiLnh3ccwcWJBKxw=; b=lN4vBjJO3dTRJMk77p36TSuohcn39j92IS5LaQQBOz/oNRMVWOcbBNd3b4S35m/EthMi4a KzKi+vAFVctsdygWKaJE6ROocHLP1WmtFfqZALY6I5Ww9odOSReJIRhBV5p7vc7/LVS7nC QlN3rD9BJ4Tg8bNRHrR4AO/YCcAbmv4MImv3ExUgwr5W3mgaZMCJWXii8wTSOcyVvaKadH T90JL3VD2V6zGbLuCVRXABWDZCiM//Lz/pe065/rXVXmLV1IEiKtbEMV7bqCkMTW4TqGjn UBLWNPqwRSH6LBR8Ues+uH+7F+vD5zkzbdP3FZZGG9o2hlgUmX7ew1su4Aq2fA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CFEE278AB7 for ; Fri, 18 Oct 2024 10:34:08 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1iQa-0006Sz-BP; Fri, 18 Oct 2024 04:33:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1iQX-0006Sq-DP for guix-patches@gnu.org; Fri, 18 Oct 2024 04:33:41 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1iQX-0002Y1-4Z for guix-patches@gnu.org; Fri, 18 Oct 2024 04:33:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=oODROXQny58lyn+ie/aJi0xxeh9XiLnh3ccwcWJBKxw=; b=uPwAoeJv+VVgf05Nrrh+OnopDyzsqbT1cKZum1AC18saAQHmzJYeZTwYe/c4iNIHrFk9b88dsUvCgTtqPcXD38k99WI8EWi72X5GRk+SONCmEt1ez1C4kwxdLvktv+7zl2gcc/97eEnwmMJQX00WXk7El4LuA1KHFbesM3HBTd2KCJ+K1wW2jhlWvrWrpfk7PbsSDZl4gRTOm40Rj0M0HdClnStuQfrFbTJCpnRV1djCxRfkRtWLaRg8xYpEXrPlna8mA2wTtu+n4gQVUkj5bT0eHt6TYmT9YksyIk5Z4uiPaqdMMLIivLsFSAizZVgh3U6zjowH1N2Rpc1JzvzCtw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t1iQs-0002i3-Kr for guix-patches@gnu.org; Fri, 18 Oct 2024 04:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73839] [PATCH 1/5] lisp-xyz: + sbcl-posix-shm References: <20241016120244.12778-1-shegeley@gmail.com> In-Reply-To: <20241016120244.12778-1-shegeley@gmail.com> Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Oct 2024 08:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73839 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 73839@debbugs.gnu.org X-Debbugs-Original-Cc: Grigory Shepelev <73839@debbugs.gnu.org> Received: via spool by 73839-submit@debbugs.gnu.org id=B73839.172924040510361 (code B ref 73839); Fri, 18 Oct 2024 08:34:02 +0000 Received: (at 73839) by debbugs.gnu.org; 18 Oct 2024 08:33:25 +0000 Received: from localhost ([127.0.0.1]:36999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1iQG-0002h3-Gi for submit@debbugs.gnu.org; Fri, 18 Oct 2024 04:33:24 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:48130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1iQD-0002gn-OJ for 73839@debbugs.gnu.org; Fri, 18 Oct 2024 04:33:22 -0400 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4315e9e9642so10867925e9.0 for <73839@debbugs.gnu.org>; Fri, 18 Oct 2024 01:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729240313; x=1729845113; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=oODROXQny58lyn+ie/aJi0xxeh9XiLnh3ccwcWJBKxw=; b=ffnA/kya4AcoXUxkGHRJKOCzxXhPDGN92K0FP1TOGUAmxjDb8BWI/hzeYvDjP1QqAo NhreGZajZ39NmZZ6PUxEuwIlijPzWITDx26Rzj9NjRvkZEixyiluLY4aDrkdVtnH7Fvt mZ9CQoZG+f/6WRUHXcvcBcuxufJtfY+2CA/QIpCiFHIk83hirMf5bwK0tcdNP7JXcItm Tig9do8xVEoL8RsQQKsSwPt8kMUZWszRZwjpzKlEI1GYhYSXeaOn2Pm834xiY/pWOSPm vg0UPeH1Of8KolQscdDlAnlYmScp3Xlnj28A2+y/ljUM5vGgJDeBOqsAuOVbmAquYzK7 g40Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729240313; x=1729845113; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oODROXQny58lyn+ie/aJi0xxeh9XiLnh3ccwcWJBKxw=; b=dHKNmCmQ4dmD15qKNBIOP9U5V4WunCzKJBNdDsq6oLdcEFyyQJfmn2CN/kOFaFRFwC CVYbNdJorJDRhtw+3hfFaF88z4vZ9hiXolNvXAYO/JJjS8oHiuO0iV7cw5OWUWH3hhG2 HjzLqj+pGL2s3X7BywyRdImPMjypGtkrFYnjvVpCWQrUGnBkQZfRD7hI4ca0D0JghiYu fKNGH3yhN/Wd6Xxk4SzHfE3ElFo4DIfWpcLqDyeNuaXpStPpZkbQdaBg7KhKrZjUzzRq QO8ffc4i6RwsazS+MO0ciFLt8NRtZU9kDuaNI25JaO1qjaI+xMzMft33AQJel3XnTCLv huow== X-Gm-Message-State: AOJu0YyHVEYIfyu1oQEJdsLVjkqTYejK1apceo0K4H8zwEISFZY56lvP LPC566AiiNV16rp+wlLV8QLBzt4+vKAXvhTTMjqfxfZrCkIFxw+ZVdxtZCCy X-Google-Smtp-Source: AGHT+IEPT6H9PqOUYi9IXf0JtHv7KLlWMyIzQCNfAobOWGk0t8nn9CcGtpVCcwhc4s4D5EH0BMhENQ== X-Received: by 2002:a05:600c:458e:b0:431:60ac:9b0c with SMTP id 5b1f17b1804b1-4316166b9d2mr10726985e9.20.1729240313382; Fri, 18 Oct 2024 01:31:53 -0700 (PDT) Received: from guxtil (cpc100684-bagu15-2-0-cust967.1-3.cable.virginm.net. [86.8.111.200]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431606c649csm20828755e9.33.2024.10.18.01.31.52 for <73839@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 01:31:52 -0700 (PDT) From: Sharlatan Hellseher Date: Fri, 18 Oct 2024 09:31:49 +0100 Message-ID: <87ed4dq0ay.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.98 X-Spam-Score: -2.98 X-Migadu-Queue-Id: CFEE278AB7 X-Migadu-Scanner: mx10.migadu.com X-TUID: kL2cdiicne7H --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Than you for the patches. I see all patches has no commit message, it would be reasonable to split each package into individiual commit/patch. You may apply etc/commiter.scm script which will add commit message and commit each package individually. I've not applied patches or built them yet, here are some suggestions on package style in general. =2D-8<---------------cut here---------------start------------->8--- +(define-public sbcl-posix-shm + (let ((commit "9443da23bcda0a2bd727aed675f92ee7d3c51802") + (revision "0.0.7") + (hash "0ah7xh7dxvdk58slic60gx7k56idjw5x30q5ifg90hxfhd32qz6l")) =2D-8<---------------cut here---------------end--------------->8--- Please check other packages in lisp-xyz and maybe try to follow the same style, e.g. "hash" field is extra here. Check possibility of adding "sbcl-package->cl-source-package" and "sbcl-package->ecl-package" variants of sbcl implementation of each package. =2D-8<---------------cut here---------------start------------->8--- + (inputs (list sbcl-cffi sbcl-alexandria sbcl-trivial-features + ;;=E2=86=93 for tests + sbcl-osicat sbcl-parachute)) =2D-8<---------------cut here---------------end--------------->8--- Any tests inputs goes to native-inputs =2D-8<---------------cut here---------------start------------->8--- + (description "This library provides two strata to access the POSIX s= hm API: +@itemize =2D-8<---------------cut here---------------end--------------->8--- Start sentence from a new line in description. =2D-8<---------------cut here---------------start------------->8--- +@item Open, close, create, resize, change ownership of, change permissions= of, and memory map to shared memory objects. =2D-8<---------------cut here---------------end--------------->8--- Feature lists may be started from lower case and don't have to be finalized with full stop (.) . Indent long lines with C-M-\ (Emacs). =2D-8<---------------cut here---------------start------------->8--- + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "cl-xkb.lisp" + (("/usr/lib64/libxkbcommon.so.0") + (search-input-file inputs "/lib/libxkbcommon.so")))))))) =2D-8<---------------cut here---------------end--------------->8--- As far as I noticed the new style to link to libraries is to use "this-package-input" or "this-package-native-input" procedures. =2D-8<---------------cut here---------------start------------->8--- + (description "cl-xkb started development to support @url{https://git= hub.com/malcolmstill/ulubis, ulubis}. =2D-8<---------------cut here---------------end--------------->8--- Description starts from Capital letter. Waiting v2 for the second round of review =3D)! =2D- Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmcSHPUACgkQdtcnv/Ys 0rX2VxAAv/8qdxzez0PNKvLs9svT34ofFDPssxXUOaATXiUqaIpe//e5eRhNRaT8 mlifU1RyrCZ2A9SjfjpDcW7jrHTn3idYw6K0jJLV1FKDHk0fyOtyu73UFh5RVI/x pyLJYDmIy8weYCnFZ+hiGyNfgGsqAG8gQYkwGBww1jfOBa7JEkrtK7ABSiM3capN AM5SouFxErjAmcYRlGQD2QA9VI913WYrpf1wTELWqjnE3uevc4lOx6Kj43cVjB5O yPVSTtMPkIC36zl/UfIwqS2TDF+P8LBLLCYyDobsvLl7496rFSxCaSpXKIGQheHN nQnghnN9Cj9/jhfdBrlnQDn5bSqW9Hqe2B4XBZaDdXk4k0gZjlZmG4u+B/109Q1F UbUfCwv3ZTvVodAGdKfSmtd2brdrQ52Z8BrU1MKpRKMzYIdSmRgZWhc7qLxT9a5X qz9ZweixZs+7CVPxZvu/XqCiMwj3DzlTxRHHO2iWq4pUX/N/OYIWS2ARwnEwqotW cThu0aFTVFQIATNWUAZ3itdFJV9sGa99O82L+FV+RKWXBEp0IZNSmjfi4JjusoVm GoJ2eGmIMShHVcin5OnfiaW7Ndq9UtU/WSE/COTOIXXUjb7dW1vfJ5E213Js5tIm PBlWwvOBwTO0IBx1cI4jOWjYNi+GuBuAvbe2SiZmGGYJ66QAYag= =vAJT -----END PGP SIGNATURE----- --=-=-=--