all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: John Kehayias via "Development of GNU Guix and the GNU System distribution." <guix-devel@gnu.org>
To: Rutherther <rutherther@ditigal.xyz>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/1] qt-build-system: Wrap with build variables to allow %outputs in arguments
Date: Thu, 05 Dec 2024 06:18:46 +0000	[thread overview]
Message-ID: <87ed2m8xfh.fsf@protonmail.com> (raw)
In-Reply-To: <cover.1733339135.git.rutherther@ditigal.xyz>

Hi Rutherther,

On Wed, Dec 04, 2024 at 11:17 PM, Rutherther wrote:

> It is impossible to refer to %outputs in arguments like #:configure-flags
> (ie. `(assoc-ref %outputs "out")` leads to unbound-variable %outputs).

You should be able to use gexps, e.g. #$output (see
<https://guix.gnu.org/manual/devel/en/html_node/G_002dExpressions.html>
for more details). That is actually the preferred way now, though
there are still instances of assoc-ref.

I believe the commit in question is
<https://git.savannah.gnu.org/cgit/guix.git/commit?id=7d873f194ca69d6096d28d7a224ab78e83e34fe1>.

> I think the issue is in qt using different system than build systems such
> as cmake or gnu. Since I am unsure about the reason for qt not having
> the same structure, I am submitting this to guix devel for discussion,
> as well as opening a patch in case this is fine to be merged. If not,
> could someone please explain what the reason behind not adding
> inputs and outputs is, and what is the alternative?
>

Though perhaps you are getting at that you'd expect the older way to
still work? Perhaps qt-build purposefully left the older procedure
behind as it should have much fewer dependents (which may rely on the
old assoc-ref)?

Hope that helps! The short of it is to use gexps :)

John



  parent reply	other threads:[~2024-12-05  6:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-17 19:15 [bug#74406] [PATCH 0/1] antlr4 package does not refer to java executable by full path Rutherther via Guix-patches via
2024-11-17 19:17 ` [bug#74405] [PATCH 1/1] gnu: antlr4: Pass full path to java in bin executable Rutherther via Guix-patches via
2024-12-04 19:12 ` [bug#74405] [PATCH 0/1] qt-build-system: Wrap with build variables to allow %outputs in arguments Rutherther via Guix-patches via
2024-12-04 22:17   ` Rutherther
2024-12-04 19:14   ` [bug#74405] " Rutherther via Guix-patches via
2024-12-04 19:15   ` [bug#74695] [PATCH 1/1] guix: qt: add inputs and outputs build variables in qt-build Rutherther via Guix-patches via
2024-12-05  6:18   ` John Kehayias via Development of GNU Guix and the GNU System distribution. [this message]
2024-12-05  7:35     ` [PATCH 0/1] qt-build-system: Wrap with build variables to allow %outputs in arguments Rutherther
2024-12-15  2:56       ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed2m8xfh.fsf@protonmail.com \
    --to=guix-devel@gnu.org \
    --cc=john.kehayias@protonmail.com \
    --cc=rutherther@ditigal.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.