From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] distro: Add libtiff.
Date: Thu, 17 Jan 2013 23:39:25 +0100
Message-ID: <87d2x35t9e.fsf@gnu.org>
References: <201301172256.26807.andreas@enge.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:39311)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Tvy7O-0007KC-3f
	for bug-guix@gnu.org; Thu, 17 Jan 2013 17:39:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Tvy7M-0000Mc-G2
	for bug-guix@gnu.org; Thu, 17 Jan 2013 17:39:30 -0500
Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:57641)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Tvy7M-0000MU-8x
	for bug-guix@gnu.org; Thu, 17 Jan 2013 17:39:28 -0500
In-Reply-To: <201301172256.26807.andreas@enge.fr> (Andreas Enge's message of
	"Thu, 17 Jan 2013 22:56:26 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: bug-guix@gnu.org

Andreas Enge <andreas@enge.fr> skribis:

> Two patches attached, since "make check" did not work for libtiff with=20
> libjepg 9, so I also added libjpeg 8d.

Great!

> +(define-public libjpeg-8
> +  (package
> +   (name "libjpeg-8")
> +   (version "8d")

Please, move the definition after that of =E2=80=98libjpeg=E2=80=99, and wr=
ite it like this:

  (define-public libjpeg-8
    (package (inherit libjpeg)
      (version "8d")
      (source (origin
               (method url-fetch)
               (uri (string-append "http://www.ijg.org/files/jpegsrc.v"
                      version ".tar.gz"))
               (sha256 (base32
                        "1cz0dy05mgxqdgjf52p54yxpyy95rgl30cnazdrfmw7hfca9n0=
h0"))))))

This way, only the fields that differ need to be defined.

Other than that, go ahead.

Note that I=E2=80=99d like to rename (distro ...), and then tag the release=
, so
I will ask you not to commit after this one.

Thanks!

Ludo=E2=80=99.