From: ludo@gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas@enge.fr>
Cc: bug-guix@gnu.org
Subject: Re: [PATCH 2/2] distro: Add libtiff.
Date: Thu, 17 Jan 2013 23:39:25 +0100 [thread overview]
Message-ID: <87d2x35t9e.fsf@gnu.org> (raw)
In-Reply-To: <201301172256.26807.andreas@enge.fr> (Andreas Enge's message of "Thu, 17 Jan 2013 22:56:26 +0100")
Andreas Enge <andreas@enge.fr> skribis:
> Two patches attached, since "make check" did not work for libtiff with
> libjepg 9, so I also added libjpeg 8d.
Great!
> +(define-public libjpeg-8
> + (package
> + (name "libjpeg-8")
> + (version "8d")
Please, move the definition after that of ‘libjpeg’, and write it like this:
(define-public libjpeg-8
(package (inherit libjpeg)
(version "8d")
(source (origin
(method url-fetch)
(uri (string-append "http://www.ijg.org/files/jpegsrc.v"
version ".tar.gz"))
(sha256 (base32
"1cz0dy05mgxqdgjf52p54yxpyy95rgl30cnazdrfmw7hfca9n0h0"))))))
This way, only the fields that differ need to be defined.
Other than that, go ahead.
Note that I’d like to rename (distro ...), and then tag the release, so
I will ask you not to commit after this one.
Thanks!
Ludo’.
next prev parent reply other threads:[~2013-01-17 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 21:56 [PATCH 2/2] distro: Add libtiff Andreas Enge
2013-01-17 22:39 ` Ludovic Courtès [this message]
2013-01-17 23:19 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2x35t9e.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=andreas@enge.fr \
--cc=bug-guix@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.