From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 'python-build-system'
Date: Mon, 29 Apr 2013 21:33:03 +0200
Message-ID: <87d2tdrv2o.fsf@gnu.org>
References: <87sj34zvn1.fsf@karetnikov.org> <87ehdwkntv.fsf@gnu.org>
	<87sj2b8llf.fsf@karetnikov.org> <877gjmr2to.fsf@karetnikov.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:41898)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UWtp5-0004Y4-V0
	for bug-guix@gnu.org; Mon, 29 Apr 2013 15:33:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UWtp4-0005KD-Kt
	for bug-guix@gnu.org; Mon, 29 Apr 2013 15:33:15 -0400
Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=38238
	helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UWtp4-0005IQ-G8
	for bug-guix@gnu.org; Mon, 29 Apr 2013 15:33:14 -0400
In-Reply-To: <877gjmr2to.fsf@karetnikov.org> (Nikita Karetnikov's message of
	"Sun, 28 Apr 2013 21:18:43 +0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: bug-guix@gnu.org

Oh, I see now!

Nikita Karetnikov <nikita@karetnikov.org> skribis:

> --- a/guix/build/utils.scm
> +++ b/guix/build/utils.scm
> @@ -680,8 +680,8 @@ contents:
>  This is useful for scripts that expect particular programs to be in $PAT=
H, for
>  programs that expect particular shared libraries to be in $LD_LIBRARY_PA=
TH, or
>  modules in $GUILE_LOAD_PATH, etc."
> -  (let ((prog-real (string-append "." prog "-real"))
> -        (prog-tmp  (string-append "." prog "-tmp")))
> +  (let ((prog-real (string-append (dirname prog) "/." (basename prog) "-=
real"))
> +        (prog-tmp  (string-append (dirname prog) "/." (basename prog) "-=
tmp")))

OK.

>      (define (export-variable lst)
>        ;; Return a string that exports an environment variable.
>        (match lst
> @@ -709,11 +709,11 @@ modules in $GUILE_LOAD_PATH, etc."
>      (with-output-to-file prog-tmp
>        (lambda ()
>          (format #t
> -                "#!~a~%~a~%exec ~a~%"
> +                "#!~a~%~a~%exec ~a $@~%"

Make it "#!~a~%~a~%exec ~a \"$@\"~%".

>                  (which "bash")
>                  (string-join (map export-variable vars)
>                               "\n")
> -                (canonicalize-path prog-real))))
> +                prog-real)))

Keep =E2=80=98canonicalize-path=E2=80=99 here, it doesn=E2=80=99t hurt.

I think this can go in (in =E2=80=98core-updates=E2=80=99) with these two s=
mall
changes.  And then we can merge =E2=80=98core-updates=E2=80=99.

Thanks!

Ludo=E2=80=99.