From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/6] gnu: Add libpeas.
Date: Sun, 01 Dec 2013 23:13:22 +0100
Message-ID: <87d2lgp6d9.fsf@gnu.org>
References: <1385774016-1418-1-git-send-email-tipecaml@gmail.com>
	<1385774016-1418-4-git-send-email-tipecaml@gmail.com>
	<87y545wnqo.fsf@gnu.org> <529AB0F3.1070005@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58174)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VnFGc-00063i-Bi
	for guix-devel@gnu.org; Sun, 01 Dec 2013 17:13:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VnFGW-0004md-Bw
	for guix-devel@gnu.org; Sun, 01 Dec 2013 17:13:30 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:17885)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1VnFGW-0004lL-5U
	for guix-devel@gnu.org; Sun, 01 Dec 2013 17:13:24 -0500
In-Reply-To: <529AB0F3.1070005@gmail.com> (Cyril Roelandt's message of "Sun,
	01 Dec 2013 04:45:55 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> On 11/30/2013 11:03 PM, Ludovic Court=C3=A8s wrote:
>> Cyril Roelandt <tipecaml@gmail.com> skribis:
>>
>>> * gnu/packages/gnome.scm (libpeas): New variable.
>>
>> OK!
>>
>>> +         (lambda* (#:key inputs #:allow-other-keys #:rest args)
>>> +          (let ((configure (assoc-ref %standard-phases 'configure))
>>> +                (gir-path (lambda (pkg-name)
>>> +                           (string-append
>>> +                            (assoc-ref inputs pkg-name)
>>> +                            "/share/gir-1.0"))))
>>> +           (substitute* "libpeas-gtk/Makefile.in"
>>> +            (("--add-include-path")
>>> +             (string-append
>>> +               " --add-include-path=3D" (gir-path "atk")
>>> +               " --add-include-path=3D" (gir-path "gdk-pixbuf")
>>> +               " --add-include-path=3D" (gir-path "gtk+")
>>> +               " --add-include-path=3D" (gir-path "pango")
>>> +              " --add-include-path")))
>>
>> If this =E2=80=98gir-path=E2=80=99 thing is frequent, we should factoriz=
e it in a
>> build-side module, say (guix build gnome).  WDYT?
>>
>> (That shouldn=E2=80=99t block this particular patch, though.)
>>
>
> Yes, I think that every package using gobject-introspection will need
> a gir-path method. I guess I could implement it in (guix build gnome)
> in this patch.

Or that can be another patch later, so we can move forward; either way.

Ludo=E2=80=99.