From: ludo@gnu.org (Ludovic Courtès)
To: Raimon Grau <raimonster@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: luajit recipe
Date: Wed, 05 Feb 2014 00:17:14 +0100 [thread overview]
Message-ID: <87d2j2a2o5.fsf@gnu.org> (raw)
In-Reply-To: <87iosulff2.fsf@gmail.com> (Raimon Grau's message of "Tue, 04 Feb 2014 22:46:25 +0100")
Hello!
Raimon Grau <raimonster@gmail.com> skribis:
> I've been following this project for some time, and finally got through
> using it for a few packages, and made my first recipe.
Great, welcome aboard! :-)
Overall this looks good to me,
> (arguments
> '(#:modules ((guix build gnu-build-system)
> (guix build utils)
> (srfi srfi-1))
Actually srfi-1 is not needed because ‘alist-delete’ is re-exported by
(guix build utils), which is used by default. So the #:modules argument
can be dropped altogether.
> #:phases
> (alist-replace
> 'install
> (lambda* (#:key system outputs #:allow-other-keys)
> (let ((out (assoc-ref outputs "out")))
> (zero? (system* "make" "install"
> (string-append " PREFIX=" out)))))
> (alist-replace
> 'build
> (lambda* (#:key system outputs #:allow-other-keys)
> (let ((out (assoc-ref outputs "out")))
> (zero? (system* "make" (string-append " PREFIX=" out)))))
> (alist-delete
> 'check
> (alist-delete 'configure
> %standard-phases))))))
This works well, but it can be simplified as:
#:tests? #f
#:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> (description
> "LuaJIT is a Just-In-Time Compiler (JIT) for the Lua
> programming language. Lua is a powerful, dynamic and light-weight programming
> language. It may be embedded or used as a general-purpose, stand-alone
> language.
>
> LuaJIT is Copyright © 2005-2014 Mike Pall")
The description doesn’t contain a copyright statement in general.
Could you send an updated version with these changes in the format
produced by ‘git format-patch’, and using a ChangeLog-style commit log
(see ‘HACKING’ for details)? That makes it easier to apply the patch.
Let us know if you have any questions.
Thanks!
Ludo’.
next prev parent reply other threads:[~2014-02-04 23:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 21:46 luajit recipe Raimon Grau
2014-02-04 23:17 ` Ludovic Courtès [this message]
2014-02-04 23:27 ` Andreas Enge
2014-02-05 1:31 ` Cyril Roelandt
2014-02-05 13:54 ` Ludovic Courtès
2014-02-06 0:11 ` Raimon Grau
2014-02-06 0:37 ` Cyril Roelandt
2014-02-06 0:47 ` Raimon Grau
2014-02-06 1:00 ` Cyril Roelandt
2014-02-06 1:28 ` Raimon Grau
2014-02-06 18:09 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2j2a2o5.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=raimonster@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.