From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add abbaye
Date: Thu, 01 May 2014 12:54:21 +0200
Message-ID: <87d2fx3h2a.fsf@gnu.org>
References: <878uqmwcom.fsf@labrys.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52831)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WfodJ-0004Bj-4o
	for guix-devel@gnu.org; Thu, 01 May 2014 06:54:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WfodE-0003dO-8h
	for guix-devel@gnu.org; Thu, 01 May 2014 06:54:29 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:54103)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WfodE-0003dI-0z
	for guix-devel@gnu.org; Thu, 01 May 2014 06:54:24 -0400
In-Reply-To: <878uqmwcom.fsf@labrys.i-did-not-set--mail-host-address--so-tickle-me>
	(David Thompson's message of "Wed, 30 Apr 2014 20:43:53 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> skribis:

> From 040828eabadf401743c4811c26dfb9220f8052d0 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson@member.fsf.org>
> Date: Wed, 30 Apr 2014 20:36:32 -0400
> Subject: [PATCH 2/2] gnu: Add abbaye.
>
> * gnu/packages/games.scm (abbaye): New variable.

Minor comments:

>  gnu/packages/games.scm | 63 ++++++++++++++++++++++++++++++++++++++++++++=
++++++
>  1 file changed, 63 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 46fbd21..3caef32 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm

Please add add a copyright line for you in this file.

> +                   ;; Modify CPATH variable to point to include/SDL for =
SDL header
> +                   ;; files.
> +                   (set-path-environment-variable "CPATH"
> +                                                  '("include/SDL")
> +                                                  input-directories))

So the crux of the problem is that this package doesn=E2=80=99t use pkg-con=
fig,
right?

> +    (description "l'Abbaye des Morts is a 2D platform game set in 13th c=
entury

Capital =E2=80=9CL=E2=80=9D.

OK to push with these changes.

Thank you!

Ludo=E2=80=99.