all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add abbaye
Date: Thu, 01 May 2014 12:54:21 +0200	[thread overview]
Message-ID: <87d2fx3h2a.fsf@gnu.org> (raw)
In-Reply-To: <878uqmwcom.fsf@labrys.i-did-not-set--mail-host-address--so-tickle-me> (David Thompson's message of "Wed, 30 Apr 2014 20:43:53 -0400")

David Thompson <dthompson2@worcester.edu> skribis:

> From 040828eabadf401743c4811c26dfb9220f8052d0 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson@member.fsf.org>
> Date: Wed, 30 Apr 2014 20:36:32 -0400
> Subject: [PATCH 2/2] gnu: Add abbaye.
>
> * gnu/packages/games.scm (abbaye): New variable.

Minor comments:

>  gnu/packages/games.scm | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 63 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 46fbd21..3caef32 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm

Please add add a copyright line for you in this file.

> +                   ;; Modify CPATH variable to point to include/SDL for SDL header
> +                   ;; files.
> +                   (set-path-environment-variable "CPATH"
> +                                                  '("include/SDL")
> +                                                  input-directories))

So the crux of the problem is that this package doesn’t use pkg-config,
right?

> +    (description "l'Abbaye des Morts is a 2D platform game set in 13th century

Capital “L”.

OK to push with these changes.

Thank you!

Ludo’.

  reply	other threads:[~2014-05-01 10:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-01  0:43 [PATCH] gnu: Add abbaye David Thompson
2014-05-01 10:54 ` Ludovic Courtès [this message]
2014-05-01 11:45   ` David Thompson
2014-05-01 16:27     ` Ludovic Courtès
2014-05-01 16:38       ` Thompson, David
2014-05-02  7:05         ` Ludovic Courtès
2014-05-02 12:55           ` Thompson, David
2014-05-02 13:02             ` Andreas Enge
2014-05-02 15:47               ` Ludovic Courtès
2014-05-02 13:59             ` Andreas Enge
2014-05-02 14:03               ` Thompson, David
2014-05-02 15:44                 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2fx3h2a.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=dthompson2@worcester.edu \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.