Re: [PATCH] gnu: Add gsegrafix and depdendent libraries.

[ludo@gnu.org (Ludovic Courtès)]

Woow, nice!  Overall looks good to me, modulo the mostly cosmetic
comments below.

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/math.scm (gsegrafix): New variable.
> * gnu/packages/gnome.scm (libIDL, ORBit2, libbonobo, GConf, gnome-mime-data,
>   gnome-vfs, libgnome, libart_lgpl, libgnomecanvas, libgnomeui,
>   libglade, libgnomeprint, libgnomeprintui, pangox-compat, libbonoboui): New variables.
> * gnu/packages/gtk.scm (pangox-compat): New variable.

Please, 80 chars max per line.

> +(define-public libIDL

Lower-case.

> +  (package
> +    (name "libIDL")

Ditto.

> +    (synopsis "create trees of CORBA Interface Definition Language files")

“Create”.

> +    (description  "libIDL is a library for creating trees of CORBA Interface Definition Language (IDL) files, which is a specification for defining portable interfaces. libIDL was initially written for ORBit (the ORB from the GNOME project, and the primary means of libIDL distribution). However, the functionality was designed to be as reusable and portable as possible.")

80 chars.

> +(define-public ORBit2
> +  (package
> +    (name "ORBit2")

Lower-case both.

> +   (arguments
> +    ;; The programmer kindly gives us a hook to turn off deprecation warnings ...
> +    `(#:configure-flags '("DISABLE_DEPRECATED_CFLAGS=-DGLIB_DISABLE_DEPRECATION_WARNINGS")

Would passing CPPFLAGS=-DGLIB_DISABLE_DEPRECATION_WARNINGS as
#:configure-flags work?  If yes, that’s preferable to modifying
Makefile.in.

> +    (description  "ORBit2 is a CORBA 2.4-compliant Object Request Broker (ORB) featuring mature C, C++ and Python bindings.")

80 chars.

> +;; Licence notice is unclear.  The Web page simply say "GPL" without giving a version.
> +;; SOME of the code files have licence notices for GPLv2+
> +;; The tarball contains files of the text of GPLv2 and LGPLv2
> +    (license license:gpl2+))) 

Please align the comment (indent-for-tab-command in Emacs should get it
right.)

> +   (arguments
> +    ;; The programmer kindly gives us a hook to turn off deprecation warnings ...
> +    `(#:configure-flags '("DISABLE_DEPRECATED_CFLAGS=-DGLIB_DISABLE_DEPRECATION_WARNINGS")

CPPFLAGS?

> +    (synopsis "framework for creating reusable components for use in GNOME applications")

“Framework”.

> +    (description "Bonobo is a framework for creating reusable components for use in GNOME applications, built on top of CORBA.")

80 chars.

> +;; Licence not explicitly stated.  Source files contain no licence notices.
> +;; Tarball contains text of both GPLv2 and LGPLv2
> +;; GPLv2 covers both conditions

Indent.

> +(define-public GConf
> +  (package
> +    (name "GConf")

Case.

> +    (synopsis "store application preferences")

“Store”.

> +    (name "gnome-vfs")
> +    (version "2.24.4")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "mirror://gnome/sources/" name "/" (string-take version 4)  "/" name "-"
> +                   version
> +                   ".tar.bz2"))
> +            (sha256
> +              (base32 "1ajg8jb8k3snxc7rrgczlh8daxkjidmcv3zr9w809sq4p2sn9pk2"))))
> +    (build-system gnu-build-system)
> +   (arguments
> +    ;; The programmer kindly gives us a hook to turn off deprecation warnings ...
> +    `(#:configure-flags '("DISABLE_DEPRECATED_CFLAGS=-DGLIB_DISABLE_DEPRECATION_WARNINGS")

CPPFLAGS?

> +    (synopsis "access files and folders in GNOME applications")

“Access”

> +    (name "libgnome")
> +    (version "2.32.1")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "mirror://gnome/sources/" name "/" (string-take version 3)  "/" name "-"
> +                   version
> +                   ".tar.bz2"))
> +             (sha256
> +              (base32
> +               "197pnq8y0knqjhm2fg4j6hbqqm3qfzfnd0irhwxpk1b4hqb3kimj"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (alist-cons-before
> +        'configure 'enable-deprecated
> +        (lambda* (#:key inputs #:allow-other-keys)
> +          (substitute* "libgnome/Makefile.in"
> +            (("-DG_DISABLE_DEPRECATED") "-DGLIB_DISABLE_DEPRECATION_WARNINGS")))

CPPFLAGS?

> +    (synopsis "useful routines for building applications")

“Useful”

> +(define-public libart_lgpl
> +  (package
> +    (name "libart_lgpl")

Hyphen instead of underscore.

> +    (name "libgnomecanvas")
> +    (version "2.30.3")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "mirror://gnome/sources/" name "/" (string-take version 4)  "/" name "-"
> +                   version
> +                   ".tar.gz"))
> +             (sha256
> +              (base32
> +               "1nhnq4lfkk8ljkdafscwaggx0h95mq0rxnd7zgqyq0xb6kkqbjm8"))))
> +    (build-system gnu-build-system)
> +    (propagated-inputs `(("libart_lgpl" ,libart_lgpl)
> +                         ("gtk+" ,gtk+-2)))

Please add a comment saying why they’re propagated.

> +    (synopsis "flexible widget for creating interactive structured graphics")

“Flexible”.

> +    (name "libgnomeui")
> +    (version "2.24.5")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "mirror://gnome/sources/" name "/" (string-take version 4)  "/" name "-"
> +                   version
> +                   ".tar.bz2"))
> +             (sha256
> +              (base32
> +               "03rwbli76crkjl6gp422wrc9lqpl174k56cp9i96b7l8jlj2yddf"))))
> +    (build-system gnu-build-system)
> +    (propagated-inputs `(("libgnome" ,libgnome)
> +                         ("libgnome-keyring" ,libgnome-keyring)))

Comment on why they’re propagated.

> +    (synopsis "additional widgets for applications")

“Additional”

> +    (synopsis "load glade interfaces and access the glade built widgets")

“Load Glade user interfaces” maybe?

> +    (synopsis "high-quality printing framework for GNOME")

Maybe just “Printing framework for GNOME”.

> +    (synopsis "high-quality printing framework for GNOME")
> +    (description  "Gnome-print is a high-quality printing framework for GNOME.")

Copy-paste here, should be “User interface for GNOME’s printing framework”?

> +    (native-inputs
> +     `(("intltool" ,intltool)
> +       ("xorg-server" ,xorg-server) ;; For running the tests

Use one semicolon for margin comments.

> +    (synopsis "some user interface controls using Bonobo")

“Some”

> +    (synopsis "functions now obsolete in pango")

“Functions”

>  
> +
>  (define-public superlu-dist

Extraneous newline.

Thank you!

Ludo’.