From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: kde: Add kdelibs. Date: Wed, 05 Nov 2014 14:18:24 +0100 Message-ID: <87d2917plr.fsf@gnu.org> References: <20141104213754.GA15142@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm0To-0001iN-OY for guix-devel@gnu.org; Wed, 05 Nov 2014 08:18:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xm0Tj-00061R-OW for guix-devel@gnu.org; Wed, 05 Nov 2014 08:18:32 -0500 Received: from hera.aquilenet.fr ([2a01:474::1]:47864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm0Tj-000610-Ib for guix-devel@gnu.org; Wed, 05 Nov 2014 08:18:27 -0500 In-Reply-To: <20141104213754.GA15142@debian> (Andreas Enge's message of "Tue, 4 Nov 2014 22:37:54 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org Andreas Enge skribis: > thanks to Ludovic's help with debugging Qt and dbus, I finally have a wor= king > recipe for kdelibs that allows me to compile the KDE "Hello, world" > tutorial at > https://techbase.kde.org/Development/Tutorials/First_program This is good news. :-) > It looks like all KDE programs require at least kdelibs, qt, phonon and > automoc4 to compile; but as these are not needed for running the program, > it seems inappropriate to make them propagated inputs. Right, this is not a reason to propagate them. Perhaps eventually you=E2=80=99ll find it convenient to have a specific bui= ld system with those listed as implicit inputs, though. > The configure flags > "-DCMAKE_SHARED_LINKER_FLAGS=3D-lQtNetwork -lQtXml" > "-DCMAKE_EXE_LINKER_FLAGS=3D-lQtCore" > look like bugs in kdelibs to me; but I wonder if reporting them makes sen= se. What does it fix? Would be nice to leave a comment above it. > Quite a few of the tests fail, and already the first one (which is a simp= le > compression and archiver test) hangs at 100% CPU before being killed after > 1500s. I can try to run all the tests and see whether there is some useful > output. Otherwise hunting down the test failures looks hopeless. It would be nice to investigate a bit, but IMO it can be done incrementally (commit with #:tests? #f and a FIXME, and then see what can be done.) > - #:use-module ((guix licenses) #:select (bsd-2 lgpl2.0+ lgpl2.1 lgpl2.1= + lgpl3+)) > + #:use-module ((guix licenses) #:select (bsd-2 lgpl2.0 lgpl2.0+ lgpl2.1= lgpl2.1+ lgpl3+)) At this point, it=E2=80=99s probably better to just use #:prefix. :-) > + (inputs > + `(("attica" ,attica) > + ("automoc4" ,automoc4) > + ("bison" ,bison) > + ("docbook-xml" ,docbook-xml) > + ("docbook-xsl" ,docbook-xsl) > + ("flex" ,flex) I suspect automoc4, bison, flex, and docbook-* should be in =E2=80=98native-inputs=E2=80=99. > + (synopsis "Main libraries for the KDE desktop") > + (description "KDE desktop environment") Make sure to improve it before committing. > + (license lgpl2.0))) ; the libraries; examples are under GPL It=E2=80=99s version 2.0 only? Thanks! Ludo=E2=80=99.