Re: [PATCH] gnu: kde: Add kdelibs.

[ludo@gnu.org (Ludovic Courtès)]

Andreas Enge <andreas@enge.fr> skribis:

> thanks to Ludovic's help with debugging Qt and dbus, I finally have a working
> recipe for kdelibs that allows me to compile the KDE "Hello, world"
> tutorial at
>   https://techbase.kde.org/Development/Tutorials/First_program

This is good news.  :-)

> It looks like all KDE programs require at least kdelibs, qt, phonon and
> automoc4 to compile; but as these are not needed for running the program,
> it seems inappropriate to make them propagated inputs.

Right, this is not a reason to propagate them.

Perhaps eventually you’ll find it convenient to have a specific build
system with those listed as implicit inputs, though.

> The configure flags
>    "-DCMAKE_SHARED_LINKER_FLAGS=-lQtNetwork -lQtXml"
>    "-DCMAKE_EXE_LINKER_FLAGS=-lQtCore"
> look like bugs in kdelibs to me; but I wonder if reporting them makes sense.

What does it fix?  Would be nice to leave a comment above it.

> Quite a few of the tests fail, and already the first one (which is a simple
> compression and archiver test) hangs at 100% CPU before being killed after
> 1500s. I can try to run all the tests and see whether there is some useful
> output. Otherwise hunting down the test failures looks hopeless.

It would be nice to investigate a bit, but IMO it can be done
incrementally (commit with #:tests? #f and a FIXME, and then see what
can be done.)

> -  #:use-module ((guix licenses) #:select (bsd-2 lgpl2.0+ lgpl2.1 lgpl2.1+ lgpl3+))
> +  #:use-module ((guix licenses) #:select (bsd-2 lgpl2.0 lgpl2.0+ lgpl2.1 lgpl2.1+ lgpl3+))

At this point, it’s probably better to just use #:prefix.  :-)

> +    (inputs
> +     `(("attica" ,attica)
> +       ("automoc4" ,automoc4)
> +       ("bison" ,bison)
> +       ("docbook-xml" ,docbook-xml)
> +       ("docbook-xsl" ,docbook-xsl)
> +       ("flex" ,flex)

I suspect automoc4, bison, flex, and docbook-* should be in
‘native-inputs’.

> +    (synopsis "Main libraries for the KDE desktop")
> +    (description "KDE desktop environment")

Make sure to improve it before committing.

> +    (license lgpl2.0))) ; the libraries; examples are under GPL

It’s version 2.0 only?

Thanks!

Ludo’.