From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: [PATCH] gnu: Add Wine. Date: Mon, 17 Nov 2014 20:34:25 +0800 Message-ID: <87d28mc8fi.fsf@gmail.com> References: <1416062479-26430-1-git-send-email-iyzsong@gmail.com> <87sihkiatr.fsf@gnu.org> <874mtzrgrt.fsf@gmail.com> <87mw7rf446.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqLW2-0004WS-3d for guix-devel@gnu.org; Mon, 17 Nov 2014 07:34:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqLVs-00019O-Iz for guix-devel@gnu.org; Mon, 17 Nov 2014 07:34:41 -0500 In-Reply-To: <87mw7rf446.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s writes: > =E5=AE=8B=E6=96=87=E6=AD=A6 skribis: > >> I can't get tests working, so leave them disabled. > > It=E2=80=99s OK to do that so we can move forward, but please leave a com= ment > that explains the situation, above #:tests? #f. The goal remains to > have tests running, eventually. By run it manually, it seem to me that many tests of wine are known to fail= ed. > >> + (arguments >> + `(#:system "i686-linux" > > No, that=E2=80=99s not possible. :-) > People should be able to use Wine regardless of their platform. > > What is the reason behind it? The goal is to have 32bit version wine for x86_64-linux. IMO, it's what most people want: to run 32bit windows applications. Yeah, for pure 64bit system `x86_64-linux', we can add wine64, which can run 64bit windows applications. I have not try `mips64el-linux', but it sound mostly not working to me. > > If some platforms are inherently not supported by Wine, then please add > a =E2=80=98supported-platforms=E2=80=99 field (there are examples in othe= r files.) By set #:system to `i686-linux', I assume it's same as: `(supported-systems '("i686-linux" "x86_64-linux"))' > > The rest looks good to me. > > Thanks, > Ludo=E2=80=99.