Re: [PATCH 1/2] gnu: xfce4-panel: Support panel plugins from other packages

[ludo@gnu.org (Ludovic Courtès)]

Mark H Weaver <mhw@netris.org> skribis:

> In the past, xfce4-panel had a way to configure paths for per-user
> plugin directories, but later this was changed to use only compile-time
> constant paths, for reasons described here:
>
>   https://bugzilla.xfce.org/show_bug.cgi?id=5455
>
> Nix's current solution is simply to change the compile-time constant
> paths to /run/current-system/sw/..., which I found unsatisfying.

Agreed.  Users should be able to choose which plug-ins they wanna use.

> The following patch modifies xfce4-panel to search for panel plugins in
> directories specified by the XDG_DATA_DIRS and X_XFCE4_LIB_DIRS
> environment variables.  That latter name is my own invention, and I've
> waffled a bit on what to call it and how much of the pathname prefixes
> it should contain.

That sounds like the right approach to me.  I’d have called it just
‘XFCE4_LIB_DIRS’, but I guess you already discarded that for a good
reason, so that’s fine.  :-)

> From ffc34f08feb9175c140e7ee7d9dcfef07b0cb751 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Sat, 13 Dec 2014 20:50:00 -0500
> Subject: [PATCH 1/2] gnu: xfce4-panel: Support panel plugins from other
>  packages.
>
> * gnu/packages/patches/xfce4-panel-plugins.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.
> * gnu/packages/xfce.scm (xfce4-panel): Add the patch, and a
>   native search path specification for X_XFCE4_LIB_DIRS.

[...]

> +    ;; XXX This probably belongs somewhere else.
> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "X_XFCE4_LIB_DIRS")
> +            (directories '("lib/xfce4")))))

It those plug-ins are dlopened by xfce-panel, then this is the right
place, no?

LGTM!

Thank you,
Ludo’.