From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add ninja.
Date: Mon, 12 Jan 2015 10:53:19 +0100 [thread overview]
Message-ID: <87d26kuxyo.fsf@gnu.org> (raw)
In-Reply-To: <87d26lk149.fsf@gmail.com> ("宋文武"'s message of "Sun, 11 Jan 2015 19:28:22 +0800")
宋文武 <iyzsong@gmail.com> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> 宋文武 <iyzsong@gmail.com> skribis:
>>
>>> From 712f161a358a4bbcf005c5875e6d91eff21bdef4 Mon Sep 17 00:00:00 2001
>>> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
>>> Date: Fri, 9 Jan 2015 21:37:30 +0800
>>> Subject: [PATCH] gnu: Add ninja.
>>>
>>> * gnu/packages/ninja.scm: New file.
>>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>>
>> Yes, OK to push, thanks!
> Even with 'system', the test InterruptChild failed on hydra for x86_64,
> but it passed for i686, mips64el and my x86_64 locally by 'guix build'.
I don’t see any failures actually:
http://hydra.gnu.org/job/gnu/master/ninja-1.5.3.i686-linux
http://hydra.gnu.org/job/gnu/master/ninja-1.5.3.mips64el-linux
http://hydra.gnu.org/job/gnu/master/ninja-1.5.3.x86_64-linux
Are you sure it failed?
> Perhaps it's a random issue?
It looks like it. It builds fine on my machine (x86_64).
I’ve looked at the test in question and it’s not obvious what could go
wrong:
--8<---------------cut here---------------start------------->8---
TEST_F(SubprocessTest, InterruptChild) {
Subprocess* subproc = subprocs_.Add("kill -INT $$");
ASSERT_NE((Subprocess *) 0, subproc);
while (!subproc->Done()) {
subprocs_.DoWork();
}
EXPECT_EQ(ExitInterrupted, subproc->Finish());
}
--8<---------------cut here---------------end--------------->8---
I think the idea is that ‘subproc_.Add’ launches a shell that gets
interrupted by the ‘kill’ subprocess, which ‘Finish’ must reflect.
Thanks,
Ludo’.
next prev parent reply other threads:[~2015-01-12 9:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 13:40 [PATCH] gnu: Add ninja 宋文武
2015-01-09 14:34 ` Ludovic Courtès
2015-01-10 11:07 ` 宋文武
2015-01-10 13:46 ` Ludovic Courtès
2015-01-11 3:07 ` 宋文武
2015-01-11 10:53 ` Ludovic Courtès
2015-01-11 11:28 ` 宋文武
2015-01-12 9:53 ` Ludovic Courtès [this message]
2015-01-14 0:31 ` Mark H Weaver
2015-01-15 11:15 ` 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d26kuxyo.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=iyzsong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.