From: ludo@gnu.org (Ludovic Courtès)
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel <Guix-devel@gnu.org>
Subject: Re: [PATCH 2/4] gnu: cross-base: Make it aware of non-Linux (ie. Hurd)
Date: Tue, 10 Feb 2015 17:25:34 +0100 [thread overview]
Message-ID: <87d25h4ttt.fsf@gnu.org> (raw)
In-Reply-To: <CAFtzXzPb-gH6ZnZDqY_pShp3pW_z9ZEoHvXEqbLm6aNSnFNmGQ@mail.gmail.com> (Manolis Ragkousis's message of "Tue, 10 Feb 2015 16:20:21 +0200")
Manolis Ragkousis <manolis837@gmail.com> skribis:
> From aaa968bbe01a57ceadf8d0c46c44e0d75d2f90cd Mon Sep 17 00:00:00 2001
> From: Marek Benc <dusxmt@gmx.com>
> Date: Thu, 5 Feb 2015 17:01:14 +0100
> Subject: [PATCH] gnu: cross-base: Make it aware of non-Linux (ie. Hurd)
> systems.
>
> * gnu/packages/cross-base.scm (cross-gcc-arguments): Make 'set-cross-path aware of the Hurd.
Please wrap line.
> (setenv "CROSS_CPATH"
> - (string-append libc "/include:"
> - linux "/include"))
> + (string-append libc "/include"
> + (if linux
> + (string-append ":" linux "/include") "")
> + (if hurd
> + (string-append ":" hurd "/include"
> + ":" mach "/include") "")))
Please align ‘else’ branch with ‘then’ branch:
(if hurd
consequent
alternate)
> (setenv "CROSS_LIBRARY_PATH"
> - (string-append libc "/lib"))
> + (string-append libc "/lib"
> + (if hurd-minimal
> + (string-append ":" hurd-minimal "/lib") "")))
Ditto.
As I suggested to Manolis, could you make sure that this doesn’t break
the existing GNU/Linux cross-toolchains?
Namely, could you run:
guix build -e '(@ (gnu packages cross-base) xgcc-armhf)'
If that passes, OK to push to wip-hurd.
Thank you!
Ludo’.
next prev parent reply other threads:[~2015-02-10 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 16:27 [PATCH 2/4] gnu: cross-base: Make it aware of non-Linux (ie. Hurd) Marek Benc
2015-02-07 23:18 ` Ludovic Courtès
2015-02-10 14:20 ` Manolis Ragkousis
2015-02-10 16:25 ` Ludovic Courtès [this message]
2015-02-10 16:37 ` Marek Benc
2015-02-10 17:09 ` Ludovic Courtès
2015-02-11 16:39 ` Manolis Ragkousis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d25h4ttt.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=Guix-devel@gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.