[PATCH] gnu: ecl: Update to version 15.2.21.

[PATCH] gnu: ecl: Update to version 15.2.21.

[Taylan Ulrich Bayırlı/Kammer]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: patch --]
[-- Type: text/x-diff, Size: 3514 bytes --]

From 33e2fa3853b067ff46513b58a485fef53c1f406b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
 <taylanbayirli@gmail.com>
Date: Sat, 21 Feb 2015 22:28:45 +0100
Subject: [PATCH] gnu: ecl: Update to version 15.2.21.

* gnu/packages/lisp.scm (ecl): Update to version 15.2.21, and disable the test
  suite which now seems to require the presence of /etc/protocols.
---
 gnu/packages/lisp.scm | 43 ++++++++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 21 deletions(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index fe9cdab..f7fa4f8 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -94,7 +94,7 @@ interface to the Tk widget system.")
 (define-public ecl
   (package
     (name "ecl")
-    (version "13.5.1")
+    (version "15.2.21")
     (source
      (origin
        (method url-fetch)
@@ -102,7 +102,7 @@ interface to the Tk widget system.")
                            (version-major+minor version)
                            "/ecl-" version ".tgz"))
        (sha256
-        (base32 "18ic8w9sdl0dh3kmyc9lsrafikrd9cg1jkhhr25p9saz0v75f77r"))))
+        (base32 "05di23v977byf67rq5bdshw8lqbby1ycbscdcl1vca0z6r1s204j"))))
     (build-system gnu-build-system)
     (native-inputs `(("which" ,which)))
     (inputs `(("gmp" ,gmp)
@@ -110,25 +110,26 @@ interface to the Tk widget system.")
               ("libgc" ,libgc)
               ("libffi" ,libffi)))
     (arguments
-     '(#:phases
-       ;; The test-suite seems to assume that ECL is installed.  So re-order
-       ;; the phases, then reference the installed executable.
-       (let* ((check-phase (assq-ref %standard-phases 'check))
-              (rearranged-phases
-               (alist-cons-after 'install 'check check-phase
-                                 (alist-delete 'check %standard-phases))))
-         (alist-cons-before
-          'check 'pre-check
-          (lambda* (#:key outputs #:allow-other-keys)
-            (substitute* '("build/tests/Makefile")
-              (("ECL=ecl")
-               (string-append
-                "ECL=" (assoc-ref outputs "out") "/bin/ecl"))))
-          rearranged-phases))
-       ;; Parallel builds explicitly not supported:
-       ;; http://sourceforge.net/p/ecls/bugs/98/
-       #:parallel-build? #f
-       #:parallel-tests? #f))
+     '(#:tests? #f
+       ;; The test-suite seems to require /etc/protocols to be in place, which
+       ;; our build environment doesn't have.  Should the test suite be
+       ;; enabled, the following might be necessary:
+       ;; #:phases
+       ;; ;; The test-suite seems to assume that ECL is installed.  So re-order
+       ;; ;; the phases, then reference the installed executable.
+       ;; (let* ((check-phase (assq-ref %standard-phases 'check))
+       ;;        (rearranged-phases
+       ;;         (alist-cons-after 'install 'check check-phase
+       ;;                           (alist-delete 'check %standard-phases))))
+       ;;   (alist-cons-before
+       ;;    'check 'pre-check
+       ;;    (lambda* (#:key outputs #:allow-other-keys)
+       ;;      (substitute* '("build/tests/Makefile")
+       ;;        (("ECL=ecl")
+       ;;         (string-append
+       ;;          "ECL=" (assoc-ref outputs "out") "/bin/ecl"))))
+       ;;    rearranged-phases))
+       ))
     (home-page "http://ecls.sourceforge.net/")
     (synopsis "Embeddable Common Lisp")
     (description "ECL is an implementation of the Common Lisp language as
-- 
2.2.1

Re: [PATCH] gnu: ecl: Update to version 15.2.21.

[Mark H Weaver]

taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") writes:

> From 33e2fa3853b067ff46513b58a485fef53c1f406b Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Sat, 21 Feb 2015 22:28:45 +0100
> Subject: [PATCH] gnu: ecl: Update to version 15.2.21.
>
> * gnu/packages/lisp.scm (ecl): Update to version 15.2.21, and disable the test
>   suite which now seems to require the presence of /etc/protocols.
> ---
>  gnu/packages/lisp.scm | 43 ++++++++++++++++++++++---------------------
>  1 file changed, 22 insertions(+), 21 deletions(-)
>
>
> diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
> index fe9cdab..f7fa4f8 100644
> --- a/gnu/packages/lisp.scm
> +++ b/gnu/packages/lisp.scm
> @@ -94,7 +94,7 @@ interface to the Tk widget system.")
>  (define-public ecl
>    (package
>      (name "ecl")
> -    (version "13.5.1")
> +    (version "15.2.21")
>      (source
>       (origin
>         (method url-fetch)
> @@ -102,7 +102,7 @@ interface to the Tk widget system.")
>                             (version-major+minor version)
>                             "/ecl-" version ".tgz"))
>         (sha256
> -        (base32 "18ic8w9sdl0dh3kmyc9lsrafikrd9cg1jkhhr25p9saz0v75f77r"))))
> +        (base32 "05di23v977byf67rq5bdshw8lqbby1ycbscdcl1vca0z6r1s204j"))))
>      (build-system gnu-build-system)
>      (native-inputs `(("which" ,which)))
>      (inputs `(("gmp" ,gmp)
> @@ -110,25 +110,26 @@ interface to the Tk widget system.")
>                ("libgc" ,libgc)
>                ("libffi" ,libffi)))
>      (arguments
> -     '(#:phases
> -       ;; The test-suite seems to assume that ECL is installed.  So re-order
> -       ;; the phases, then reference the installed executable.
> -       (let* ((check-phase (assq-ref %standard-phases 'check))
> -              (rearranged-phases
> -               (alist-cons-after 'install 'check check-phase
> -                                 (alist-delete 'check %standard-phases))))
> -         (alist-cons-before
> -          'check 'pre-check
> -          (lambda* (#:key outputs #:allow-other-keys)
> -            (substitute* '("build/tests/Makefile")
> -              (("ECL=ecl")
> -               (string-append
> -                "ECL=" (assoc-ref outputs "out") "/bin/ecl"))))
> -          rearranged-phases))
> -       ;; Parallel builds explicitly not supported:
> -       ;; http://sourceforge.net/p/ecls/bugs/98/
> -       #:parallel-build? #f

Did they fix parallel builds upstream?

> -       #:parallel-tests? #f))
> +     '(#:tests? #f
> +       ;; The test-suite seems to require /etc/protocols to be in place, which
> +       ;; our build environment doesn't have.  Should the test suite be
> +       ;; enabled, the following might be necessary:
[...]

Could we disable only the specific tests that need /etc/protocols?
How many failures are there?

     Thanks,
       Mark

Re: [PATCH] gnu: ecl: Update to version 15.2.21.

[Taylan Ulrich Bayırlı/Kammer]

Mark H Weaver <mhw@netris.org> writes:

> Did they fix parallel builds upstream?

Apparently (or supposedly, see below) it was fixed upstream some time,
and there was just no release in a long time:

http://sourceforge.net/p/ecls/bugs/98/

User "jackdaniel" is apparently the new maintainer, and the project will
be moving to Gitorious soon:

http://sourceforge.net/p/ecls/news/2015/02/ecl-15221-released-new-maintainer-found/

That being said, your following inquiry tempted me to run the build
process again to get the exact output, and I faced what I describe in
the second additional message in this bug report:

http://sourceforge.net/p/ecls/bugs/300/

> Could we disable only the specific tests that need /etc/protocols?
> How many failures are there?

Sadly, as now mentioned in the above bug report, the whole system fails
to start with a "protocol not supported" error.


I guess the best way to go is to keep the test suite disabled for now,
but add additional comments pointing to the above bug report as well as
<http://sourceforge.net/p/ecls/bugs/299/> so someone updating the
package will know what changes to look forward to.  WDYT?


Taylan

Re: [PATCH] gnu: ecl: Update to version 15.2.21.

[Taylan Ulrich Bayırlı/Kammer]

Mark H Weaver <mhw@netris.org> writes:

> Did they fix parallel builds upstream?

Apparently (or supposedly, see below) it was fixed upstream some time,
and there was just no release in a long time:

http://sourceforge.net/p/ecls/bugs/98/

User "jackdaniel" is apparently the new maintainer, and the project will
be moving to Gitorious soon:

http://sourceforge.net/p/ecls/news/2015/02/ecl-15221-released-new-maintainer-found/

That being said, your following inquiry tempted me to run the build
process again to get the exact output, and I faced what I describe in
the second additional message in this bug report:

http://sourceforge.net/p/ecls/bugs/300/

> Could we disable only the specific tests that need /etc/protocols?
> How many failures are there?

Sadly, as now mentioned in the above bug report, the whole system fails
to start with a "protocol not supported" error.


I guess the best way to go is to keep the test suite disabled for now,
but add additional comments pointing to the above bug report as well as
<http://sourceforge.net/p/ecls/bugs/299/> so someone updating the
package will know what changes to look forward to.  WDYT?


Taylan

Re: [PATCH] gnu: ecl: Update to version 15.2.21.

[Taylan Ulrich Bayırlı/Kammer]

[-- Attachment #1: Type: text/plain, Size: 60 bytes --]

Here's an updated patch for my proposal in my last e-mail.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 3587 bytes --]

From 1ecd96ab33df9809786f01730a6bf531e56c6dcb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
 <taylanbayirli@gmail.com>
Date: Sat, 21 Feb 2015 22:28:45 +0100
Subject: [PATCH] gnu: ecl: Update to version 15.2.21.

* gnu/packages/lisp.scm (ecl): Update to version 15.2.21, and disable the test
  suite because ECL now seems to require the presence of /etc/protocols during
  its initialization.
---
 gnu/packages/lisp.scm | 45 ++++++++++++++++++++++++---------------------
 1 file changed, 24 insertions(+), 21 deletions(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index fe9cdab..91354e9 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -94,7 +94,7 @@ interface to the Tk widget system.")
 (define-public ecl
   (package
     (name "ecl")
-    (version "13.5.1")
+    (version "15.2.21")
     (source
      (origin
        (method url-fetch)
@@ -102,7 +102,7 @@ interface to the Tk widget system.")
                            (version-major+minor version)
                            "/ecl-" version ".tgz"))
        (sha256
-        (base32 "18ic8w9sdl0dh3kmyc9lsrafikrd9cg1jkhhr25p9saz0v75f77r"))))
+        (base32 "05di23v977byf67rq5bdshw8lqbby1ycbscdcl1vca0z6r1s204j"))))
     (build-system gnu-build-system)
     (native-inputs `(("which" ,which)))
     (inputs `(("gmp" ,gmp)
@@ -110,25 +110,28 @@ interface to the Tk widget system.")
               ("libgc" ,libgc)
               ("libffi" ,libffi)))
     (arguments
-     '(#:phases
-       ;; The test-suite seems to assume that ECL is installed.  So re-order
-       ;; the phases, then reference the installed executable.
-       (let* ((check-phase (assq-ref %standard-phases 'check))
-              (rearranged-phases
-               (alist-cons-after 'install 'check check-phase
-                                 (alist-delete 'check %standard-phases))))
-         (alist-cons-before
-          'check 'pre-check
-          (lambda* (#:key outputs #:allow-other-keys)
-            (substitute* '("build/tests/Makefile")
-              (("ECL=ecl")
-               (string-append
-                "ECL=" (assoc-ref outputs "out") "/bin/ecl"))))
-          rearranged-phases))
-       ;; Parallel builds explicitly not supported:
-       ;; http://sourceforge.net/p/ecls/bugs/98/
-       #:parallel-build? #f
-       #:parallel-tests? #f))
+     '(#:tests? #f
+       ;; During 'make check', ECL fails to initialize with "protocol not
+       ;; supported", presumably because /etc/protocols is missing in the
+       ;; build environment.  See <http://sourceforge.net/p/ecls/bugs/300/>.
+       ;;
+       ;; Should the test suite be re-enabled, the following might be
+       ;; necessary (see <http://sourceforge.net/p/ecls/bugs/299/>):
+       ;;
+       ;; #:phases
+       ;; (let* ((check-phase (assq-ref %standard-phases 'check))
+       ;;        (rearranged-phases
+       ;;         (alist-cons-after 'install 'check check-phase
+       ;;                           (alist-delete 'check %standard-phases))))
+       ;;   (alist-cons-before
+       ;;    'check 'pre-check
+       ;;    (lambda* (#:key outputs #:allow-other-keys)
+       ;;      (substitute* '("build/tests/Makefile")
+       ;;        (("ECL=ecl")
+       ;;         (string-append
+       ;;          "ECL=" (assoc-ref outputs "out") "/bin/ecl"))))
+       ;;    rearranged-phases))
+       ))
     (home-page "http://ecls.sourceforge.net/")
     (synopsis "Embeddable Common Lisp")
     (description "ECL is an implementation of the Common Lisp language as
-- 
2.2.1

Re: [PATCH] gnu: ecl: Update to version 15.2.21.

[Taylan Ulrich Bayırlı/Kammer]

taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") writes:

> Here's an updated patch for my proposal in my last e-mail.
> [...]

I went ahead and pushed a slightly edited version of that.

Taylan