From: ludo@gnu.org (Ludovic Courtès)
To: "Taylan Ulrich \"Bayırlı/Kammer\"" <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Add sysfsutils, cpufrequtils
Date: Wed, 25 Feb 2015 14:42:00 +0100 [thread overview]
Message-ID: <87d24yyuon.fsf@gnu.org> (raw)
In-Reply-To: <874mqionl1.fsf@taylan.uni.cx> ("Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\= message of "Wed, 18 Feb 2015 23:35:06 +0100")
taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis:
> From a2edf2d2cec85d02e3a3848499706544be0e0961 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
> <taylanbayirli@gmail.com>
> Date: Wed, 18 Feb 2015 21:20:38 +0100
> Subject: [PATCH 1/3] gnu: Add sysfsutils.
>
> * gnu/packages/linux.scm (sysfsutils): New variable.
LGTM.
> From e7a1705f8d5719cdd88ca681252d34a0f7b586c0 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
> <taylanbayirli@gmail.com>
> Date: Wed, 18 Feb 2015 22:17:01 +0100
> Subject: [PATCH 2/3] gnu: Add sysfsutils-1.
>
> * gnu/packages/linux.scm (sysfsutils-1): New variable.
[...]
> + (substitute* '("Makefile.in")
> + (("includedir = /usr/include/sysfs")
> + "includedir = @includedir@"))
> + (substitute* '("configure")
> + (("includedir='(\\$\\{prefix\\}/include)'" all orig)
> + (string-append "includedir='" orig "/sysfs'"))))
Could you make these a ‘snippet’ in the ‘origin’ instead?
Also, note that the first argument to ‘substitute*’ can be a plain
string instead of a list.
> From ae4cba1a57fc64294d5ec3b667ab482f7cc7d27e Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
> <taylanbayirli@gmail.com>
> Date: Wed, 18 Feb 2015 21:20:57 +0100
> Subject: [PATCH 3/3] gnu: Add cpufrequtils.
>
> * gnu/packages/linux.scm (cpufrequtils): New variable.
> * gnu/packages/patches/cpufrequtils-fix-aclocal.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.
LGTM.
Thanks!
Ludo’.
prev parent reply other threads:[~2015-02-25 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 22:35 Add sysfsutils, cpufrequtils Taylan Ulrich Bayırlı/Kammer
2015-02-25 13:42 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d24yyuon.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=taylanbayirli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.