From: Mark H Weaver <mhw@netris.org>
To: Paul van der Walt <paul@denknerd.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Update ncmpcpp to v0.6.2
Date: Fri, 27 Feb 2015 13:21:22 -0500 [thread overview]
Message-ID: <87d24v6wrh.fsf@netris.org> (raw)
In-Reply-To: <87oaofiak5.fsf@denknerd.org> (Paul van der Walt's message of "Fri, 27 Feb 2015 17:27:54 +0100")
Paul van der Walt <paul@denknerd.org> writes:
> On 2015-02-27 at 17:13, quoth Mark H Weaver:
>>> Paul van der Walt <paul@denknerd.org> writes:
>> [...]
>>>> + (arguments
>>>> + '(#:configure-flags
>>>> + '("BOOST_LIB_SUFFIX=")
>>>> + #:phases
>>>> + (alist-cons-after
>>>> + 'unpack 'autogen
>>>> + (lambda _
>>>> + (substitute* "autogen.sh"
>>>> + (("/bin/sh") (which "bash")))
>>>
>>> Is "autogen.sh" not executable? If it starts with a shebang, Guix
>>> should patch the file appropriately.
>>
>> The problem here is that this 'autogen' phase is run before the
>> 'patch-source-shebangs' phase, at my suggestion. It has to be that way,
>> because 'patch-source-shebangs' (and 'patch-usr-bin-file') will need to
>> be run on the files created by 'autogen.sh'.
>
> This is the case. Is this therefore the cleanest way to do it?
Actually, having looked more carefully, I see that the only occurrence
of /bin/sh in autogen.sh is the shebang at the top. Therefore, you
shouldn't need the 'substitute*' call at all, because of the way you are
running it below:
>>>> + (setenv "NOCONFIGURE" "true")
>>>> + (zero? (system* "bash" "autogen.sh")))
Also, since the shebang asked for /bin/sh, it's probably marginally more
correct to use "sh" instead of "bash" here. Bash modifies its behavior
somewhat when run as "sh".
On the whole, I think the preferable approach (and the one I've used in
a large commit that cleans up all of these autogen-style phases) is
this:
--8<---------------cut here---------------start------------->8---
(alist-cons-after
'unpack 'autogen
(lambda _
(setenv "NOCONFIGURE" "true")
(zero? (system* "sh" "autogen.sh")))
--8<---------------cut here---------------end--------------->8---
> One last question:
>
>>> From e1382a9df3e7df94e794df8aa247920b7e28c0c6 Mon Sep 17 00:00:00 2001
>>> From: Paul van der Walt <paul@denknerd.org>
>>> ...
>>
>> Could you please add a copyright line for yourself at the top of this
>> file?
>
> Are these from lines not enough? My previous patch which i generated the
> same way was accepted.
That was my mistake. I asked you to add a copyright line, but then
forgot about it when I looked at the updated patch. Can you submit a
patch that adds your copyright line for your previous package update?
Or is there a reason you'd like to avoid adding your copyright?
Mark
next prev parent reply other threads:[~2015-02-27 18:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 10:13 [PATCH] Update ncmpcpp to v0.6.2 Paul van der Walt
2015-02-27 12:50 ` David Thompson
2015-02-27 16:13 ` Mark H Weaver
2015-02-27 16:18 ` David Thompson
2015-02-27 16:27 ` Paul van der Walt
2015-02-27 17:13 ` David Thompson
2015-02-27 18:21 ` Mark H Weaver [this message]
2015-02-27 18:53 ` Paul van der Walt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d24v6wrh.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=paul@denknerd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.