From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 1/5] gnu: Add efl. Date: Sun, 01 Mar 2015 21:31:14 +0100 Message-ID: <87d24sa299.fsf@gnu.org> References: <1425161466-4681-1-git-send-email-sleep_walker@suse.cz> <1425161466-4681-2-git-send-email-sleep_walker@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSAWM-0003iV-Eg for guix-devel@gnu.org; Sun, 01 Mar 2015 15:31:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSAWH-0004Yh-Ka for guix-devel@gnu.org; Sun, 01 Mar 2015 15:31:26 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSAWH-0004Yc-HS for guix-devel@gnu.org; Sun, 01 Mar 2015 15:31:21 -0500 In-Reply-To: <1425161466-4681-2-git-send-email-sleep_walker@suse.cz> (=?utf-8?B?IlRvbcOhxaEJxIxlY2giJ3M=?= message of "Sat, 28 Feb 2015 23:11:02 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Cc: guix-devel@gnu.org Tom=C3=A1=C5=A1 =C4=8Cech skribis: > * gnu/packages/enlightenment.scm: New file > * gnu/packages/enlightenment.scm (efl): New variable. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. [...] > + (propagated-inputs > + ; all these inputs are in package config files in section > + ; Require.private Please use two semicolons for comments like this one. Capitalize sentences and add a period at the end. > + (alist-cons-before > + 'configure 'patch-config-files > + (lambda _ > + (substitute* "po/Makefile.in.in" > + (("/bin/sh") (which "bash")))) I persist to think that this is not needed, is it? If not, please remove it. > + (description > + "Enlightenment Foundation Libraries is set of libraries developed > +for Enlightenment, but is used for more applications because it is resou= rce > +friendly, energy efficient and good looking. It consists of: > + > + * Eina - defining data types and low level abstractions > + * Eo - generic object concept for EFL > + * Eet - binary data parser and serializer > + * Evas - canvas library > + * Ecore - abstraction to operating system > + * Embryo - script engine > + * Escape - Playstation portability layer > + * Evil - Microsoft Windows portability layer > + * Eio - library for asynchronous input/output > + * Eldbus - DBus integration > + * Efreet - support for Freedesktop.org standards > + * Eeze - hardware interface > + * EPhysics - integration of physics engine > + * Edje - UI layout library, themes support > + * Emotion - multimedia integration > + * Ethumb - image thumbnail support") You=E2=80=99ll hate me for saying that ;-) but please make it just a plain paragraph: the UIs may reformat the paragraph to their without caring for the bullet list. The text probably doesn=E2=80=99t need to be exhaustive, just to list some = of the main functionality. > + (license (list license:bsd-2 license:lgpl2.1 license:zlib)))) ; diff= erent parts under different licenses Line too long. OK to push with these changes. Thanks! Ludo=E2=80=99.