From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Add guile-minikanren Date: Thu, 23 Apr 2015 20:57:22 +0200 Message-ID: <87d22uekq5.fsf@gnu.org> References: <87wq14dwd9.fsf@earlgrey.lan> <20150423131751.GA12941@debian.math.u-bordeaux1.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlMJX-0007qe-TD for guix-devel@gnu.org; Thu, 23 Apr 2015 14:57:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlMJS-0007Ba-An for guix-devel@gnu.org; Thu, 23 Apr 2015 14:57:31 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlMJS-0007BW-75 for guix-devel@gnu.org; Thu, 23 Apr 2015 14:57:26 -0400 In-Reply-To: (David Thompson's message of "Thu, 23 Apr 2015 09:46:19 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: "Thompson, David" Cc: guix-devel "Thompson, David" skribis: > On Thu, Apr 23, 2015 at 9:17 AM, Andreas Enge wrote: >> On Wed, Apr 22, 2015 at 10:15:27AM -0500, Christopher Allan Webber wrote: >> >>> I named it guile-minikanren which isn't really accurate. I'm not sure >>> how else I could name it though? I'd be open to suggestions! >> >> There is a chapter in the documentation about this: >> https://www.gnu.org/software/guix/manual/guix.html#Package-Naming >> The main idea is to not think too much, but to simply use the upstream >> project name. Here this seems to be "minikanren" without "guile-". >> We have special rules for perl and python; maybe we also need a special >> rule for guile? > > The prefix "guile-" is important here because the build system > installs the Scheme modules into a directory that is specifically for > Guile, not other R6RS compliant Scheme implementations. I agree with you an Taylan; =E2=80=9Cguile-minikanren=E2=80=9D sounds right= here. >>> + (source (origin >>> + (method git-fetch) >>> + (uri (git-reference >>> + (url "https://github.com/ijp/minikanren.git") >>> + (commit "10d507785eab30b0f8b47bf8bb37d880731fc031"= ))) >> >> Is there no tarball? If possiblem we would prefer this. > > No tarball. I would recommend that the first 7 characters of the > commit SHA be used as the package version, and this string here could > just be replaced with 'version'. Maybe make the version (string-append "0-" commit) so we can eventually increment that zero to make upgrades work, as Andreas notes? (I think upstream minikanren is frozen anyway.) >>> + (native-inputs `(("guile" ,guile-2.0))) >> >> "native-inputs" are used during the build of the package, which is not >> the case here. Is guile needed at all as an input? > > It will be needed. The build system should compile the Scheme files, > but it doesn't. Even when it does this won=E2=80=99t be needed: there=E2=80=99s implicitly = a Guile running the build script already. :-) > As a final note, I would like to add that the 'license' field can be > simply 'expat', instead of using the 'non-copyleft' procedure. +1 Chris, could you post an updated patch taking into account alllll these comments? :-) I hope the thorough review did not drive you away already. ;-) At any rate, welcome, and thanks for helping out! Ludo=E2=80=99.