From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCHES] for Haskell packages
Date: Wed, 10 Jun 2015 21:42:13 +0200
Message-ID: <87d213gxka.fsf@gnu.org>
References: <20150606073647.6cc504fb@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58057)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Z2ltE-0004gT-0X
	for guix-devel@gnu.org; Wed, 10 Jun 2015 15:42:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Z2ltA-0006XS-0L
	for guix-devel@gnu.org; Wed, 10 Jun 2015 15:42:19 -0400
In-Reply-To: <20150606073647.6cc504fb@openmailbox.org> (Eric Bavier's message
	of "Sat, 6 Jun 2015 07:36:47 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org

Federico would be the expert, but it looks good to me:

Eric Bavier <ericbavier@openmailbox.org> skribis:

> From 75a4305391cd246a6e8db5b11223f9ce243edd35 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Sat, 6 Jun 2015 06:38:58 -0500
> Subject: [PATCH 1/3] profiles: Search for ghc conf files only if package =
db
>  exists.
>
> This avoids having 'find-files' report warnings about searching in
> non-existent directories.
>
> * guix/profiles.scm (ghc-package-cache-file)[conf-files]: Only search
>   for *.conf files if the search directory exists.

OK, makes sense.

> From 08d67857d9726a2fddbc834c34caaae3e5a5d4f2 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Sat, 6 Jun 2015 06:43:19 -0500
> Subject: [PATCH 2/3] profiles: Process ghc conf files only once.
>
> A package may be listed in the manifest inputs multiple times.  Avoid
> copying ghc *.conf files twice by deleting duplicates.
>
> * guix/profiles.scm (ghc-package-cache-file)[conf-files]: Delete
>   duplicate manifest inputs before copying conf files.

OK.

> From 480d18c683d3d74fab46578c93fb4cbf81d1a8be Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Sat, 6 Jun 2015 07:28:57 -0500
> Subject: [PATCH 3/3] build-system/haskell: install config for any package=
 that
>  creates it.
>
> A Cabal package is allowed to declare an "empty" library, in an
> otherwise executable-only package, for the purpose of allowing Cabal
> to use it as a dependency for other packages.  See e.g. hspec-discover.
>
> * guix/build/haskell-build-system.scm (register): Unconditionally call
>   setup script with "register", and install any config file generated.

OK!

Ludo=E2=80=99.